Re: NUMA aware slab allocator V3

[Matthew Dobson <colpatch@us.ibm.com>]

Christoph Lameter wrote:
> On Fri, 20 May 2005, Matthew Dobson wrote:
> 
> 
>>Christoph, I'm getting the following errors building rc4-mm2 w/ GCC 2.95.4:
> 
> 
> Works fine here with gcc 2.95.4.ds15-22 but that is a debian gcc 
> 2.95.4 patched up to work correctly. If you need to address the pathology in pristine 
> gcc 2.95.4 by changing the source then declare the entry field with 0 
> members.
> 
> Index: linux-2.6.12-rc4/mm/slab.c
> ===================================================================
> --- linux-2.6.12-rc4.orig/mm/slab.c	2005-05-19 21:29:45.000000000 +0000
> +++ linux-2.6.12-rc4/mm/slab.c	2005-05-20 19:18:22.000000000 +0000
> @@ -267,7 +267,7 @@
>  #ifdef CONFIG_NUMA
>  	spinlock_t lock;
>  #endif
> -	void *entry[];
> +	void *entry[0];
>  };
>  
>  /* bootstrap: The caches do not work without cpuarrays anymore,
> 
> 
> 
> gcc 2.95 can produce proper code for ppc64?
> 
> 
> 
> 
>>mm/slab.c:281: field `entry' has incomplete typemm/slab.c: In function
>>'cache_alloc_refill':
> 
> 
> See patch above?

I can't for the life of me explain why, but the above patch makes ALL the
warnings go away, despite the fact that they seem unrelated.  I dunno...
Maybe we should upgrade the compiler on that box?

-Matt
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>