From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e1.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id j4IHRvTd019335 for ; Wed, 18 May 2005 13:27:57 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4IHRtPE136650 for ; Wed, 18 May 2005 13:27:56 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11/8.13.3) with ESMTP id j4IHRtaa003798 for ; Wed, 18 May 2005 13:27:55 -0400 Message-ID: <428B7B16.10204@us.ibm.com> Date: Wed, 18 May 2005 10:27:50 -0700 From: Matthew Dobson MIME-Version: 1.0 Subject: Re: NUMA aware slab allocator V3 References: <714210000.1116266915@flay> <200505161410.43382.jbarnes@virtuousgeek.org> <740100000.1116278461@flay> <1116289613.26955.14.camel@localhost> <428A800D.8050902@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Dave Hansen , "Martin J. Bligh" , Jesse Barnes , Christoph Lameter , Andy Whitcroft , Andrew Morton , linux-mm , Linux Kernel Mailing List , shai@scalex86.org, steiner@sgi.com List-ID: Christoph Lameter wrote: > On Tue, 17 May 2005, Matthew Dobson wrote: > > >>You're right, Dave. The series of #defines at the top resolve to the same >>thing as numa_node_id(). Adding the above #defines will serve only to >>obfuscate the code. > > > Ok. > > >>Another thing that will really help, Christoph, would be replacing all your >>open-coded for (i = 0; i < MAX_NUMNODES/NR_CPUS; i++) loops. We have >>macros that make that all nice and clean and (should?) do the right thing >>for various combinations of SMP/DISCONTIG/NUMA/etc. Use those and if they >>DON'T do the right thing, please let me know and we'll fix them ASAP. > > > Some of that was already done but I can check again. Thanks! I just looked at V2 & V3 of the patch and saw some open-coded loops. I may have missed a later version of the patch which has fixes. Feel free to CC me on future versions of the patch... -Matt -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org