> Instead of moving all that around why don't we just drop the duplicate > and the if altogether? I tested and sent a patch back in March that > cleaned up the non-numa case pretty well. > > http://sourceforge.net/mailarchive/message.php?msg_id=11320001 Ok, Mike also expressed the feeling that it was no longer necessary to handle the first block separatly. I've tested the attached patch on the machines I have to hand and it seems to boot just fine in the flat memory modes with this applied. Joel, Mike, Dave could you test this one on your platforms to confirm its widly applicable, if so we can push it up to -mm. The patch attached applies to the patches proposed for the next -mm. A full stack on top of 2.6.12-rc3-mm2 can be found at the URL below (see the series file): http://www.shadowen.org/~apw/linux/sparsemem/sparsemem-2.6.12-rc3-mm2-V3/ Cheers. -apw