From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF64E7717D for ; Wed, 11 Dec 2024 07:02:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABB8E8D0016; Wed, 11 Dec 2024 02:02:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A929A8D0013; Wed, 11 Dec 2024 02:02:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 932C98D0016; Wed, 11 Dec 2024 02:02:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 749EA8D0013 for ; Wed, 11 Dec 2024 02:02:46 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E8012AE375 for ; Wed, 11 Dec 2024 07:02:45 +0000 (UTC) X-FDA: 82881784818.10.9E8DEE2 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf10.hostedemail.com (Postfix) with ESMTP id D27BFC0015 for ; Wed, 11 Dec 2024 07:02:33 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733900553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a3U6sJJr51d+uvYBWomkAO/Tl1+s17Lgl9jX78s56w4=; b=r54jswOLAmQb187aR226cH1efGM81YvFjFoCjs5LGf2Z0nNKLNdLw3AuwBajKyQ7mzvING LfTAcuWPTxX55VJxi5Ys4porUq2ggrUOhPbl/PnIsI+vJ+4Au/Q9uLsL7oi+UxS5fFCdW8 gWsyOh4bHucrk6HN8/FtC6GuIj6x7Hg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733900553; a=rsa-sha256; cv=none; b=leqUg9rBQk8FAarfe26mFuq4pfuzquMW9pjEiqlFbjZ6egE2LriFgLIW63sMqkdbsQ0AI9 B8w0dXPKafdBYATmPl6g/aAmzmRA03kjvjmJqBhCk/wSxWNZTa+XiSGCJh7GMseY8JVICL ZCk36VAWnBLXLL5Qhmw87h/8JtG9MgU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Y7RPZ12ljz9t4b; Wed, 11 Dec 2024 08:02:42 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VhF7djCc-JgY; Wed, 11 Dec 2024 08:02:42 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Y7RPY0l0qz9t4Y; Wed, 11 Dec 2024 08:02:41 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EEE098B770; Wed, 11 Dec 2024 08:02:40 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 8IeVCYesgdWz; Wed, 11 Dec 2024 08:02:40 +0100 (CET) Received: from [10.25.209.139] (unknown [10.25.209.139]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2664A8B763; Wed, 11 Dec 2024 08:02:40 +0100 (CET) Message-ID: <427e840b-d4f5-4554-b798-c70a5b67040e@csgroup.eu> Date: Wed, 11 Dec 2024 08:02:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/19] powerpc/papr_scm: Convert timeouts to secs_to_jiffies() To: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-5-ddfefd7e9f2a@linux.microsoft.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <20241210-converge-secs-to-jiffies-v3-5-ddfefd7e9f2a@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D27BFC0015 X-Stat-Signature: 46c4fbpekzuhkxdu3ucbx86fytim1b34 X-Rspam-User: X-HE-Tag: 1733900553-559821 X-HE-Meta: U2FsdGVkX1+krMaZZL9iVJ8fEw0nTTlZyo2VKH25i/logXeaDK79gxRrZqpFM6WQH+8gfMc0yb2dsmLI/0w17AvYvU14Fde+NVabsz/W+8AReoNoF3FfDh4Ggac0bTdfBdca8CVb7bJVVJHb2LL31XZKel8ywaBdD3f8nDQ0vUDDz0GTj7CYUXnixpxEMS1fsY2oZkv8MwkBLQKtIxaAz1L/rTOfwMmU+jNuCcP6dypSJ/sf4ECSwAn0cREpscHg4AgJsRY2BMRMWibjiq2lV7wFOVEFjSK+R6BPXrQhKdn1R5Qb4RyYxg0bixAe3keRRG/HDYoqYy2+WmkLxeQXPyg8JYdn39Hi0q9CTLIwXWlGZqbXzFOtD8xZDMhhssiw9AtV4zy+EiGZ6VoAnnNBEzh9WofA94fHSAvTBpgV8mOKxOMDKcxstJm6WwO0EPXSoYW7IdwCx49bA5eZHmxko/MO/HY490TVNg71simiABq5o3MYtmmioy3B+qZhY0GP/8Mte9ZxsAQliAARxRn3wRxPuweQntznkMbLKrv4fo3qB9DPfKo1ujepQMb2Mm+F1ZKksSjhIzsQXAesa5xBqhKB0JdO1hkkOw/1b8vukSInh3sHbh9LP+WEYKvWdXXkKeEcdP/oPKvP20/Uv5o7cobwt+OFXPa9pXDxAFZNE8l2KcbsbTLItWLcqV9bfuaQDQALUUVEObevaCJhn68k56BZO46oiUPf3ASLAlg2oln8Du/jZ8cJ99kvaw4N7sIKBfICLUuktze8FbxZu2XgJ7V53V+BpRQWvoSuOyvu0n8qbRML4lNQ2zVPqNW+98w8i6k8SiEq8s5YvhSO5sNOBz6JPM3Qa3WDgaFZ4sFcUAX1vEmBLCMXpJcSVueUdalI+RWS81NtbeOyofXrhDGLNJm5/fjMGRj1CkgO7bgg3Piv6w6XwpMoDAEBJPOchFxDpgJqBYguUiWF5CPlYzU vOCdsvcr 7c5m7pJo/Sbar9j/EPg+Wtd64HQt/ClV1g5RsFeJ9hQOjF1CPZnfSOd5l/1mILdQt4E99+AMefKPNOlZXJmwhnPxCZ87hIkAaNTdHDRdDlzkwucZuU+dFA/JGGb0dNxXFFIFESXJ8Mk0gTDPodykGLFOUZ6Aj5Kzpbi0yqpRMnuyi/SsmRBwgN+FmFWlJBH9mBrp3SjScoK24VSykcGTGnlmsENhVQKzo83Qpadu4eo2xHTOM43KK+kve+8fe5p49YgZyv4/p1lLYV2Im4/AuauSKqSCSTsSW3686lhxbxY/sC1AUn7Dx0d8M1/7NAe57csesMc7v4U0886618wa/g3xah/di6qV/Vg+Fd/2I1MRjnB/ydHD4BB0j8ERAg0j7WRRVg5CjJoP7TCzXCDufTYmyidQMy6sVTRRghx1oHTELmXhSzjRQmdkSS2Ll1Qd7RTSthSv2okBqCJU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 10/12/2024 à 23:02, Easwar Hariharan a écrit : > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with > the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan Reviewed-by: Christophe Leroy > --- > arch/powerpc/platforms/pseries/papr_scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c > index f84ac9fbe203c111046464b9100866dddae687bb..f7c9271bda58433f395648063e60409a8d3c11d9 100644 > --- a/arch/powerpc/platforms/pseries/papr_scm.c > +++ b/arch/powerpc/platforms/pseries/papr_scm.c > @@ -544,7 +544,7 @@ static int drc_pmem_query_health(struct papr_scm_priv *p) > > /* Jiffies offset for which the health data is assumed to be same */ > cache_timeout = p->lasthealth_jiffies + > - msecs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL * 1000); > + secs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL); > > /* Fetch new health info is its older than MIN_HEALTH_QUERY_INTERVAL */ > if (time_after(jiffies, cache_timeout)) >