From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F60C7115A for ; Thu, 19 Jun 2025 11:13:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9B656B00A7; Thu, 19 Jun 2025 07:13:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E72CD6B00A8; Thu, 19 Jun 2025 07:13:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61FF6B00A9; Thu, 19 Jun 2025 07:13:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C87BC6B00A7 for ; Thu, 19 Jun 2025 07:13:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 73C1E10202F for ; Thu, 19 Jun 2025 11:13:31 +0000 (UTC) X-FDA: 83571889422.19.063F8B1 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2076.outbound.protection.outlook.com [40.107.102.76]) by imf18.hostedemail.com (Postfix) with ESMTP id 7FDA31C0003 for ; Thu, 19 Jun 2025 11:13:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=LWD1cmo0; spf=pass (imf18.hostedemail.com: domain of shivankg@amd.com designates 40.107.102.76 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750331608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DpOMMTdjB6BrY9M7K5wNsKOL5MirLyu39PCyT0SKg64=; b=NM9yMme+Wz9Cr922IjF5l21cL5SRjS936qlBL38L81MVZjJSkw9WtZfaRqvtLuIxlafuVi Mkh5V4x13MhBwWY5ofQR/QRhYkkysF7alSWZXJ38vnw5o2BJKYgnWUibwqMJVoasDFvSd3 mwkUf13B8MRY8P57snnxrMfT1lfSfmI= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=LWD1cmo0; spf=pass (imf18.hostedemail.com: domain of shivankg@amd.com designates 40.107.102.76 as permitted sender) smtp.mailfrom=shivankg@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750331608; a=rsa-sha256; cv=pass; b=iBQtTLr+Il0QDbo7zqx0FZw6/Gh6bcwvETuv0TXPg22uWCAjbt+2RwjxmaVc8LATych6ri l36QH/Ygk/H6R8CHHh+TTgw3vn4Hq3e9EVvX3QftwBKJs85f1tserzixxzFELJVqWVWFYR +eEiL2aQpm0Ga5n8Z/Yqk2hWIjB2YFs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DUQYrJeLY2mT+K57xLsjbVRNvVaqrExXnAqhvGzK7DHhCV/CKWYn9oQfXepJBm179njuQCy9c5hTpsWxMP2tGoZKliAQdhL/uTf6l/5p/56Jn9OjBZn+68VHCuN2Dg5ejhnewkLsca6l0ykDSgJXT+YLBd/DPC1gCgbU69Wt3IpOyN4K47M2sjFqYzuOgF2cPZ6trTJGLUuXuUkOiY9VKfFY5j2BM+XDvj5tJYW1GqhvDW3m/fbOpY/Ct602uBEUBZJy7HjM12LxaA3l5F4vSEuz3KEzimEpgmEOHi9I5RoX9cPjD9xp74I/L8u23lJiAvG+Czm65iZGOo6n2cHE/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DpOMMTdjB6BrY9M7K5wNsKOL5MirLyu39PCyT0SKg64=; b=LPM/9uSeHwlZL24fguDtjrAJLNwkN1IT5UalKAXcYBDKmFgPE2R/DPFcpnYrcblt8CnMoZku0bDVdXt4xPWPDzO68fPS+7/JMh4jiL8p9j55p+thLh0AYs5ZPZ1uFWfmkfcHcRUfJBxvN+cY47EP0513NRjvHT+d6mU7wSX4VfmgDeqdX2THs2LqLjCt3tlYsaKpUNNtqPDw5mQWGLGHQrMQaB40YIAui3cTU/GDaDIKdrFEkZNVF4v26JgCVZ7FMaLhMtxy6/rADcNaaXts53Ls6mrnRcMcvwUhXXrAZNsDIKCfyq7uZcC+SU30UdVftjalELSmj9weq/9URbxr6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DpOMMTdjB6BrY9M7K5wNsKOL5MirLyu39PCyT0SKg64=; b=LWD1cmo0u4Hcxj2YkTZXFpUyPA0yJf+BH9//4/pbrKQT1ZFqb699B7YAr3zEHTVsr0BajcisAIxPOpOkksqz0G3ztVuwfV68P/fTkZrL6jj3eWTk3O99I3dfwflm6+e/HgsImGffvcDfATmgdauiSBXuDWQTaod11n1ev/X9Y6M= Received: from CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) by SA3PR12MB9178.namprd12.prod.outlook.com (2603:10b6:806:396::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.36; Thu, 19 Jun 2025 11:13:25 +0000 Received: from CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870]) by CH2PR12MB4262.namprd12.prod.outlook.com ([fe80::3bdb:bf3d:8bde:7870%5]) with mapi id 15.20.8835.027; Thu, 19 Jun 2025 11:13:24 +0000 Message-ID: <4267108c-ac26-4528-97cc-0d160568baee@amd.com> Date: Thu, 19 Jun 2025 16:43:00 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v8 4/7] mm/mempolicy: Export memory policy symbols To: Gregory Price Cc: seanjc@google.com, david@redhat.com, vbabka@suse.cz, willy@infradead.org, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev References: <20250618112935.7629-1-shivankg@amd.com> <20250618112935.7629-5-shivankg@amd.com> Content-Language: en-US From: Shivank Garg In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BMXPR01CA0082.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:54::22) To CH2PR12MB4262.namprd12.prod.outlook.com (2603:10b6:610:af::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4262:EE_|SA3PR12MB9178:EE_ X-MS-Office365-Filtering-Correlation-Id: 6da1ae5a-f926-48dc-7735-08ddaf224ecc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MVhhdk0vTVU0SERGaUNGemRZTEMwUXp6dlY0cTZHenJ6Z2JMODdHTDdOWElB?= =?utf-8?B?T3N2aDVkbnllNnpRaHMyd053N3hRbjBsNmpKY0dpVmJQVUlHay8rZTdLWGNM?= =?utf-8?B?WmtrUk94TmtuSTQ0WEpUVENaenRYakVhODBOQXhkSzlhcmpjVm5ocEdyQlRl?= =?utf-8?B?anJJUWhvVllRQnQwbmRqdFVsM1BYRGwzK2MwVkMrRnVtSVo3Y1VDaFhLSWNE?= =?utf-8?B?TUd6UmhqUGpNVEFUaFM3TE0zTllQeXNNazRVbG5CWjRmU3F2U3c2MHVsb0x1?= =?utf-8?B?cTREcUxjMUcwUUphaHk1N0FyMTc1ZkR5NlR1cThBQUdUa0JLWVIwMS9ZM3hR?= =?utf-8?B?NGlGMjJ1TzJJOWFWUjlLbk92WFRMbjZXZHplU2c5WEZ0SFpGRUNKR0JuR1Ex?= =?utf-8?B?RURQc0JLQzRxbnBwVzBuMmhHODZnTUZzUGR6ek5iVjRkd0ZPd28zeThLNTNq?= =?utf-8?B?MkpuOHUvSjVML2tUdnBhVURYemJTcWJ0M0laOE1MdzlvRTFZTHFKSmNqd3dF?= =?utf-8?B?cTl2Vnp1bVQ3TFRLWjN2L1NlSFArUllXNDFralhTMUxsQ3JOUEw4eGx6Vjli?= =?utf-8?B?N3ZRU3RxMG1VZ3diZEZrMXJyV1pRczJ3NnpweXRwbEpQdjdrN2RQMTU4ejJu?= =?utf-8?B?WW5EaVNNWHJCejhmUEM2b2w0VnBIUkpUd29sNnRIWis3MnQrSXdTcFhoZTds?= =?utf-8?B?czZhOVV1ZVVPQ2NZM3NnZ2lPcmx1YkUzYVhEbUV1WGlFWC91MWYwTHRtVjhK?= =?utf-8?B?Z09oZkxZR1prNDhSanlvdWdxNzZsb2FzV2w1M2ozOGplbUdhK1Jxd1FmWW5i?= =?utf-8?B?eWtlTUx1SVNGcFo0eUhDcjZIVWp4Ym4vYkJTdzZ1UUxqaUREd1JOQWdyYnpw?= =?utf-8?B?dkJiQ3NCRkt5eVVrNVFMZmk3aEozci9aVEo0MVBlSWFaYmVobjhhdS9KVHlK?= =?utf-8?B?RTR3OXFZWHo1RWdKRy85NTR5Nm8wQWsvRnIvVmd0enNIYllrWVRrTUovUjU3?= =?utf-8?B?R0R2VHNkcXdaUUdqcGtoZWs4eGtBNVRHZ25WWFdUeDlTVVQ1U2VRSE81VG5N?= =?utf-8?B?ZCswaDR2WHRFT3ZVMFdxVXFqVUNGV2dZY1IxWHF6QVBseUJZVFpVM05qeUNh?= =?utf-8?B?UDBNL2hHSFNMWnVjWmJhd2dqdnFlUlZ0MEpBbWZsNnJiWGNPOEZzUFJ4Q0g5?= =?utf-8?B?a0JXR2tSaVBsdHRwM2FNR0JqNWpINXdwWTJVMDRwcnp2YzBoSzZqMDBXM2Ro?= =?utf-8?B?TmRIQmJwT281dkE1ZHY3cG1OUmJPbC9BWGFKb1NyOHVhZHZ2YkZTeWc5VDhI?= =?utf-8?B?Z2NNMU5oVVU1ZncxZEdwSEk3b0ROMXI5aENtbVdMVCtQT0dsQVdjc0dyU3R6?= =?utf-8?B?ZnpTNnVEa0I2QkIrVzcvaUpXTm1XK25qRUtMUnFCb3R1dGM3clNZd1l1aEEr?= =?utf-8?B?RmZmQ24wZkU5Nno3dXh0b1REYnc5clR3aFI3YUttTzM4V0xnUkxvOHFtc3Bn?= =?utf-8?B?U3VpRjVpTldHYThLY1FybmNvTTJmWUhvUjB0MlVnMno2a2pmdE5JTUZmbTcx?= =?utf-8?B?WVE0MWVBYWRaS0lvYU1MdS8zajNyYmxLZExpSDdnYUtzbzErdmFQaW4yMzlW?= =?utf-8?B?d21DMFFZYmVEUG9EMkFaY2pxSUVYMEpoNEYzMS90a1dMYTFadTRWSDJMUm1i?= =?utf-8?B?ZnhSOWJHYk9Tc09VZ29ZWWVUZGNUOUhPNGpoL0xqeGxLYkx1S1NMNEVxMXpY?= =?utf-8?B?bXhnUHhtSGl0cjhCcXpxVDF6Z0hDZHZOcnQ3YnYzNFk0TkE5UE14Y3hyM0Fl?= =?utf-8?B?a1JnZUMzcVRDWFF1T3J0UG1lOTE0b2JpaENPVjROWjhpZU15WWNiYlVGTjdY?= =?utf-8?B?TFptVk5sTmxLdVNydjVmaVplK2RMYmp2UFB3MHhMS3ZsREZkZnBqRlNaZjRs?= =?utf-8?Q?vi0ZfYqDgk8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB4262.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHdDM3hPRjV3ekVXa0RQaXNWWFcyOUVZRlpCMEwrc0d1N0RMYWdlNjJ4YXB6?= =?utf-8?B?cHkxZVB0Nk54V282UUhsK1pzU0tlbHEzbkZHVmJYYk5WL0lLWTlndXlpMUZ6?= =?utf-8?B?ck0vaDBwaWg3c2tzRU5odnlVZ29KSS8rWUh5eldsRUlkaWJINDc5dG8xQit4?= =?utf-8?B?TDBpd05CSmlGNUlzdFU0TlhBZ1plWEpaNUh5K1B0OGYwS21WOEM0eFZ2TlV3?= =?utf-8?B?cW4yWFpKZ1pLQ1o4K2MyYWZiNGhCeDN4Z215d2d6Nk5vMk15RGNtSGpoMjRX?= =?utf-8?B?RlU5VmRHRW5LN0tTNDdlSDZyd2Q0UDl0cUVIRHZtM2ZDejB5Y0VaYXJKNm5F?= =?utf-8?B?NFlrUmNjK0dGRTVIRm5JQld4UXFVeFFrZm9ONGJSd3Jtd3V6NkVDOGJPR1hk?= =?utf-8?B?K2h3VXBreFh2eFJZbTZhVmJacnVLcW82Nmx2eDl0ZkRVMW0wVU1FV0xUYW92?= =?utf-8?B?ekhQU2hjTEl3YWh0VEd1cEZIQkdGaGhHQ1pSV3BNSzdVaFkvV2UraVluVGpt?= =?utf-8?B?TG80M0E1S05TZWRsVjA3RllLdEpObUdBZkFUOE9vMkYrNjkxdXJhVHM3bWRp?= =?utf-8?B?cDBpbm5lOFhLU2E1UVVBUUxXakt4ajRobWFOc0xHcEVrUFNBYXhJVUF3d0c2?= =?utf-8?B?QXZ4ZTc3MnRKLzhXMVA5eGZUUVVsK0RqVk5iNkZKQm9rKzFRbm1PQlRpQkVh?= =?utf-8?B?OXZhNWZiV3RtZDc0UEhhZHlsS2xzby9ETXEzay9TaVJXU2YrL0grUnpLVWRp?= =?utf-8?B?a2J6NGQ0U3BvU2FpWk5aTHNSVERIR3QwbjU0L3JLZzNBTkdiK29pRmRpNUta?= =?utf-8?B?a1VZNUxGZUUwVUxjbjYzRjJmV2RpbWpzNXBhbk9icUlmVkJtQ1dOZkJqVDVP?= =?utf-8?B?OGpEOFNoc1hXVjYyYktxdTRLblpoWnZhcWs1MTVMbmlZWUt5S1ZpaGY2cmdk?= =?utf-8?B?T0xjZDFic0o4VW1oT3k3cWNscTZaWDZ2cldqVmxraFFlSlpqeXRxdW4xNm1r?= =?utf-8?B?RUY4eE1sNitOeXNUUzkyKy9TSXBmSWRwZVNVczlYSnNZMnR2KzloeTFDSzRk?= =?utf-8?B?TlptUng5K2d3ci96R2RvcWt6R3dUdHh6RWhHTG1RZnZFbGhBRjhMbStuZG5O?= =?utf-8?B?a1JDdklaZlg2N2o5bVVBb1RVckJXc2hKL0xVRkdsNkw1dXFuT0NvaW1oQkpM?= =?utf-8?B?WkV4SmlnV1dxaTdHMkhMSHI0aGZpSWhNbUNhSVRTK3UzUjhYWkNWUEc2eFY1?= =?utf-8?B?TUtOSjZaSTF3RHRjdVg5ZFAyWjdqNWROV0NEK1h0eGFZQXpOaE1iL244QnEy?= =?utf-8?B?L2pxNTN4V1ZzS1M5Zjh1VFFmY0FackxOUCtmRmIweTlnbmpsa0hVZWNHUGJq?= =?utf-8?B?RnFOT3pZRXZoUTlwYVE2NElyTUhjb20vVVFlSm1mRnJ4U09qcDZhOVh0MXJH?= =?utf-8?B?Nmg5cG5uL3dhVkNGNHR3TWxLQTJ0NlhmQTI0cTB1T2VldVFFSWx1ZjR2a05T?= =?utf-8?B?QkNNZWhHTWNyY3JPSU1uL01tcnFWMDY2RTlrRzlFVERoWFlXRzZWWUUrVHBj?= =?utf-8?B?TVVnNllBbGNYd3pUZEdZRVVTN1BIcjVYNERITUFhay9HdkRIQ2RlTGRnb2Ra?= =?utf-8?B?REV6YVZXU3daTUNGZEFSdlRuVXEwcSt4QjYvNnlZdVRKZ3BxS1N0aTFrSkJ4?= =?utf-8?B?ZktoTERybWg3Z0w4Z0V0Q1VwQUd3ZnN5V2d5NWZ4bEIzWVJzWlFPSHB4TTBy?= =?utf-8?B?dHpTNklaZC95aWNNNGJqalQxLzVIOXF1bGhuUTVYOEoyNGp1cnNRWG8yaTlF?= =?utf-8?B?bC8vNzgwMVBXZk8zdGlaSXlSc2psYU1lUzJMN3NSNTcwYWZCYmRtRUcxWmZl?= =?utf-8?B?NmdjMmEydmhCY0NSNENUUGxIYVF0M21MaFQrTG01Rld4OHdET1ZBQlE2aklL?= =?utf-8?B?MElubHp2THFwOGdpTTVmVEhRYWNpc0VTWmlWeU1XYXlJVWtSUnpmYUs4Y3VV?= =?utf-8?B?eW1Mc2I1Y2VPK21JY3J1SzZ1UEd1am43MjRSSFo3RnlxNk9zLzIxazVMNUxm?= =?utf-8?B?ZE9BUHBqd3lLWjU3MTU3ZEtiZUxGOC9jWS9rbVlnMUt3MG91d2NyNTVuZ00w?= =?utf-8?Q?utzaa49KUsriS74NwJ4PYrwy1?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6da1ae5a-f926-48dc-7735-08ddaf224ecc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4262.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 11:13:24.6368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z2W2SBhDTnyN1P2wln9L5cX00Lrsv5FZnr2M8ZuTrXy7vnJDWLaNBnEF22yKKW91/xUey0phZa4Ma0HR2t+NIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9178 X-Rspam-User: X-Rspamd-Queue-Id: 7FDA31C0003 X-Rspamd-Server: rspam01 X-Stat-Signature: zcqp9mj15wubi8tf7ufnddphs4go8ba5 X-HE-Tag: 1750331608-849730 X-HE-Meta: U2FsdGVkX1/RObeM9c1IXL1LRlf/7EKwSEeqB/or72mo3rCp2fUf+QKAR1pNr2mMveyzy22it3ppjvC6Pqd3cYwELz2Ft1ypzpkAE9D0CcBN3s4iWt1jH0yIHTjrpxiYoBWbiiuGxd0K+lfFAn54UeCgfF4M7jPxzMnRf/tE2VRkHO4zu3GxtdcmmDq+z/f93LVAzaF6AkX3ONUFUFvlnFzCPNKq+Eub0Bod98Vl/nTmaH0oSaF1E+amPhHzmp6NpzKIY1IhUkcsj0S4YkOndJLiFvDVpQoqQhgMan2FeqITbCFn0TOHRjyo25hNyPY6wPNapUsj+xssQ88MP6gyjH8gKjYBaWlflfyT6Oxr6mSFc0qE7MUgbZ3qphF9/4HP1pNh+79/HpLIFdfXA2uUejakTQDsmw9fXjahvaqoVdNslydjxsCzWggAA3BL0BCvFKna+ZbZUBapRQUCcZooaKRYEuVi7ujh3y6jombJ6kZKD+lYbkPew0mPpoEnybOcimh5b84AIxVNbmfXmCNaclFjejrOQBi8AapTOJo+v7Eao7arMuqYawkAI1TLL0Gt6GeEqGl4RuU2f7rr9lxK5DgK05pTrmXVKPe9w7S/5YdwmH5inc5QrApCfMNpUkLjgHmsLKCzrxGNd6P3HR1lyPKgwHvlwI+WJ7z7t3xyTkwJqfE5T1ujzo7rzsaS8TBgI/ladxhaFYWpEdstzcjXySa+wnpclvNLwSN7OIjMYE6iovw/9eRECgAaCzckkf1WJRtySAsiXln52NvZngX00/WlOuyiWiMbnJFyxRE/0sFvGfPp28Xt0n09f1EDpRxHRXAxqGaYtMQfM/bcRE8uAtilrJwGzoEieJgSupXOfY9iH9irvzvobilWypZUkxvyWBZlRUbm9AetyOitornloBV5B5YRsSoQFgd1rbnXz4xkpJYhgNlqGHJ8WYV+m5/Tm8UbFai8+eD782BRHw8 lAw6XEwZ 54rdxVAwdEL2ynxt8LwAXR7oS5Xw2WpAcCO3xzizcN0lbu4oAcr1eyr/RXPMfXP2v+StF/wlROtgqtrmPOugIP8FewAXEsjrS/HfO0jwcd5Cdie/BAJJNbVM9jcV3HfoOdnyIsCITsoqRa/6jKYA8r+URVwAFatzNCS2QsaxN/sSXhzyyJhBLQhukpmjkisPiCFa4SvE8wvVM/HSp3PWfGkhh9HUw1ECAnHcvwPfEF/0Hd2Oulxvbe5pZPJ7NwsQJFrulYdNCb/okPgiKg/jLEJ/3fT0lyaumZZpdU882Dts6G4pZcieJSoB5xhTZ4ftLgR9arx2Mslr9/UZrb1t/jumlw/1tv2JhRQ748ghEVY13SvWmgMnT+SjKY+qLTWSFZfJuwt3RHHZPTdiC9c3z185TMziiTr7Ed+d1dAxgbEHr6kznS0Ol6TjAwqwJg9HMtFtzZRcSv8Wkmp3FaRoU3JttQF8EQUDWLV+HwzAA77o/UQ08ZWTGJRRgpTVddu1jP8TNHx4Nc5xa6C8U9fvIYZKXofybSpL3rxnm91VfhV6IZolv9HCPpaNJyFWf+eUWzw1R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/18/2025 8:42 PM, Gregory Price wrote: > On Wed, Jun 18, 2025 at 11:29:32AM +0000, Shivank Garg wrote: >> KVM guest_memfd wants to implement support for NUMA policies just like >> shmem already does using the shared policy infrastructure. As >> guest_memfd currently resides in KVM module code, we have to export the >> relevant symbols. >> >> In the future, guest_memfd might be moved to core-mm, at which point the >> symbols no longer would have to be exported. When/if that happens is >> still unclear. >> >> Acked-by: David Hildenbrand >> Acked-by: Vlastimil Babka >> Signed-off-by: Shivank Garg >> --- >> mm/mempolicy.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/mm/mempolicy.c b/mm/mempolicy.c >> index 3b1dfd08338b..d98243cdf090 100644 >> --- a/mm/mempolicy.c >> +++ b/mm/mempolicy.c >> @@ -354,6 +354,7 @@ struct mempolicy *get_task_policy(struct task_struct *p) >> >> return &default_policy; >> } >> +EXPORT_SYMBOL_GPL(get_task_policy); >> >> static const struct mempolicy_operations { >> int (*create)(struct mempolicy *pol, const nodemask_t *nodes); >> @@ -487,6 +488,7 @@ void __mpol_put(struct mempolicy *pol) >> return; >> kmem_cache_free(policy_cache, pol); >> } >> +EXPORT_SYMBOL_GPL(__mpol_put); >> > > I'm concerned that get_task_policy doesn't actually increment the policy > refcount - and mpol_cond_put only decrements the refcount for shared > policies (vma policies) - while __mpol_put decrements it unconditionally. > > If you look at how get_task_policy is used internally to mempolicy, > you'll find that it either completes the operation in the context of the > task lock (allocation time) or it calls mpol_get afterwards. I agree. But the semantics of my usage isn't new. shmem use this in same way. I think the alloc_frozen_pages_noprof(), alloc_pages_bulk_mempolicy_noprof() calls get_task_policy without task_lock or calling mpol_get. > > Exporting this as-is creates a triping hazard, if only because get/put > naming implies reference counting. Since KVM is the only user, we could consider newly added EXPORT_SYMBOL_GPL_FOR_MODULES(..., "kvm") to avoid wider exposure. Does this solve your concern? Or should we rename these functions. What should be the preferred approach? Thanks, Shivank