From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF84FCD1284 for ; Thu, 11 Apr 2024 10:15:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BC2E6B0085; Thu, 11 Apr 2024 06:15:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26C656B0087; Thu, 11 Apr 2024 06:15:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 132D26B0089; Thu, 11 Apr 2024 06:15:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E7B536B0085 for ; Thu, 11 Apr 2024 06:15:41 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5BBB7160B2D for ; Thu, 11 Apr 2024 10:15:41 +0000 (UTC) X-FDA: 81996844482.17.C0977EA Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 6F4401C0012 for ; Thu, 11 Apr 2024 10:15:39 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=m+POWdd7; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712830539; a=rsa-sha256; cv=none; b=7sDlQhRvYCUs4oRzxte2QWJkYwx3QBA74Ts7ZFw2qupPuOBzQ5tNpBDt29Cd9J4PCRx4o8 dgQqkKfiqv0cvtB3cQtu+IzT7Us586M/ehQ0uNkpgJfgZZSaI4edQR/SnEsIy6RHPi6iBY wWB4bkRn6qR04bmJC1vtQAtvJ9AroqY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=m+POWdd7; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712830539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=WiVmZ6cq6HixfqxYNA972rbKxcwD9JRiQEpuhMop1E8=; b=agXAHyPuBpUqsmiN20mLycslRnKJNhPoV/OLvIshtYSSktXGJlXpjgQfoXTF8t5o6u4HPF 3TBdGzq+Z9n79BZL1md0MPi3Sce2POSzi5NojqHYGz6+qQlfmazhEnyb2PoFGm9SrxWOOx 0f4Aq01EGHZTdzqGo+KB6D4pRHu7F04= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a52223e004dso46808166b.2 for ; Thu, 11 Apr 2024 03:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712830538; x=1713435338; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=WiVmZ6cq6HixfqxYNA972rbKxcwD9JRiQEpuhMop1E8=; b=m+POWdd7GKaUJsHUZ7WSy4GYea9BHprsi1t+KIiohIFWN1BtLJ/QMdrHVsB6TaoFLH yRg9REAwpDrAjSPIk9i66flrPxP/abe8qZjJnvbHhC/McQtY2FLeDdyyUBMSIfXa8ILU Yrl07PfB7vY2Y9Rc/se2hB7+gSinAMdRFAx9rUiSAUyF7Dhc0boOvxY7JDIcYYSKiy4Z NfqnCxR4WRUBchOwHIJub0nj8+BU0i3wdEbKRaFsn2WD+XY7qL+xhg3yCLpyvvAhmN9i r/iYPF3UfxPQdHsNZAVpi2g4/oR+k+H9I6foP9FBAeD4saqPh+XJ53QXZHtwzGv3HmAN IVsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712830538; x=1713435338; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WiVmZ6cq6HixfqxYNA972rbKxcwD9JRiQEpuhMop1E8=; b=XpJLgkUsZe2vBiJnbft4Sh/pP4vqK0s51xekymwd6XmGaakbVAPNb9XT3/ciaXO20c 1EKJ5qqraMCG+GxoCadmH76NjAu1t1L6ayDvIfGe2d9YkBR+KI+zFmwhzBxKlg38BODV L4c2NCCsquulK2FiYGJBPXQADPzrjE6oL2W77Uf0Uup4lrlGjlMzQpTJrtXOuCgfBM4H 9Su9x3PjbQD3oHrE77yyuROafJq9awTVhxnbO3w2+M84Xwbt79oUF6XGDS6VW/WKfs1M NQSCtBt0ervQ8mIsspyiXZWaVoVxewGchn9qK+YLzqL0OeiMi5aUd93JC4Oypl2LC1Ub IqvA== X-Forwarded-Encrypted: i=1; AJvYcCX4+ThoYvRGs8Ffd261rjjCTOkgQVTo2hDI8iU12EugRr3TTJnHgWJQZI7HfxxJRXdBOBSBwVr1J0/CGjZDYa42yUQ= X-Gm-Message-State: AOJu0YzY8t1YHTh9tMXaqZwI1AaQ16EvAPZfbSfUD5u32i9mU0GbxGLR 3XNAqOf/RTDCxGnx8sqpTZ7AuZbFTC+K02MVL1LM1d67DdjS2wg9Nv6A9j4K3eU= X-Google-Smtp-Source: AGHT+IFpTNg5pJuUDJkIczk50XOHfll1lCLgYdqCedfxH2svtnTfZm/iKGHRjoAl16XU8bYTi1cMfA== X-Received: by 2002:a17:907:1b1a:b0:a51:abb0:a8a1 with SMTP id mp26-20020a1709071b1a00b00a51abb0a8a1mr5127101ejc.54.1712830537648; Thu, 11 Apr 2024 03:15:37 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id jw9-20020a170906e94900b00a52241b823esm354394ejb.109.2024.04.11.03.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 03:15:37 -0700 (PDT) Date: Thu, 11 Apr 2024 13:15:34 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Frank Li Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Vinod Koul Subject: [linux-next:master 3454/5042] drivers/dma/fsl-edma-main.c:133 fsl_edma_xlate() warn: inconsistent returns '&fsl_edma->fsl_edma_mutex'. Message-ID: <425abe00-438e-4736-98f7-89609789b3d4@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6F4401C0012 X-Stat-Signature: 85enozzm7rsebippks5b4hcbxxtjm19d X-Rspam-User: X-HE-Tag: 1712830539-721582 X-HE-Meta: U2FsdGVkX1/gHfoG6PdYPS/DaxKHqqu5v97PkcXQ5P/e7B4UhvofPQBNxd0r0W73cqZxsUwYayooBv7yS0ccci7B7j62UnTnlt6VvxA+SaeTy2ePcZSYe4JvDn53ZjGmFXk9y3CA0NK8ax9nmQEkdgQ9UblTtejGtBGhI9vOntaXtEUtXplXdpj6MWACvaxFrIO6mCpRDt77Hwzm4ce50I9Z0TBBz/fp/ZR94zcMObmCeqkF4Pdd8PMoXD98Mlaf7kT13Sqt4Mmn5/x1La8ltywdMyrVui+FUdmHnjAocLu4qrzosaYU4if2Z46khFt5z9hg6WOrqzWGYAcfPKNa36f5uo75jgr17utjal8OVUU2hI2Ev6/QR15+Vrgb8EWAzF+gNe9KDeccufr/YuXKyLOjgjixkvX06yup1ebOZUJMm7w66C2uBuKBJsMxrQjdH7vST2CaFLNSBstFvXppO/eG0+E/8zYygjbcpklZCzzQYi/bOve4MIXceBb3vn3wOd+qEHvfSEfLPpH5hSZvA0xaeIdblWAjSgchER11JFnrNtyj0ey4iIYXwWBuqLMKUCTPQ8xSczJLIMf34lunwp7z9qjhJK0xzNgphSbqZRzqrWEvpHWUP61XuiM3V5jyvEJySP4uMao6M/ZrU1hIGf4Gsisi0DXQszCbHlrXvgZVZK3rnE7XI/6TPdOyL485KJAoEKCAGmce+50ehYHctFI8uzXQSSeP63pJ1FzrRJK6edrk/6q+GzOCIPe3+9r+mFPefm0b8DtYASAItcFW0lUbQyczY7zHVvdkY4QXC7jz44p93M5Ya9rpRVPiShit7HOMLZjYvxO1HhstnLx++0kYWEj5Svr6Q+ygb/VmdMgSVhN26KSh4cyqKgNz11ufxNqleBvnwY8mXq21J6OHvyIVH2evopSZISIkyMwbHt3LfBP7DXN83kwjE8NHwYxdnm2Grdc8iiC7Q1xXO+4 g+hMyYAG SChw2cm2NiW8wxP2eK0hyPLSkUQ2es0r1KkKCB6s3JgeDzwiouvr5c1/GgrO3sv2ehrITFnwU7qRHydu9Ug8CAnWjoiQgbQjUFuXQPHY0F8NabpR0nu4VdhR3PY5H8DY3TWrTi3j+F7M/r2PAf0mqF5kUz6T6zTgyLeQF6GbCs0yAsMnM0PmMhgFemMBP/SWTopsQpcaSgK+Ub3qbtDGEZ21qMN+DLGpoR/ap7S8OXpOBaMS2K/X2meZu/3CjdtRaqrLhbAZsUe2HjqhJAJhQLBmLy35iIfMAr/TT9iU76enI6SXG/SwzVc1pXRpPPBSGzM04aCEWo9vp02jm1T19Y+KuSZIOz0mV91/qJmV/ah4af7NbaUqZ6gazjFvqfDZOsSA2zZ1+HNvXhLC9CHnt8VAXHOetfWsdA3uLDPM6zMHVmIQioVeRqODrlkuG4pQt8/AprVyAHNoR/4wQNXAJ2NzT8fY7EtmRtOOZymNi+feT8hJs9HZBiKaKZTresyHWVeStpAS9DBfYEnqol0DrVrewyvM62qSB19FQeKa4SH3UdZkSdksGdSWWgXR24L5OGt1g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 6ebf211bb11dfc004a2ff73a9de5386fa309c430 commit: 6aa60f79e6794bbbc571ea4e0501b9fcc26026e2 [3454/5042] dmaengine: fsl-edma: add safety check for 'srcid' config: i386-randconfig-141-20240411 (https://download.01.org/0day-ci/archive/20240411/202404110915.riwV3ZAC-lkp@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202404110915.riwV3ZAC-lkp@intel.com/ smatch warnings: drivers/dma/fsl-edma-main.c:133 fsl_edma_xlate() warn: inconsistent returns '&fsl_edma->fsl_edma_mutex'. vim +133 drivers/dma/fsl-edma-main.c d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 96 static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec, d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 97 struct of_dma *ofdma) d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 98 { d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 99 struct fsl_edma_engine *fsl_edma = ofdma->of_dma_data; 178c81e58e9155 drivers/dma/fsl-edma.c Jingchang Lu 2014-02-21 100 struct dma_chan *chan, *_chan; 82d149b86d31e1 drivers/dma/fsl-edma.c Yuan Yao 2015-10-30 101 struct fsl_edma_chan *fsl_chan; af802728e4ab07 drivers/dma/fsl-edma.c Robin Gong 2019-06-25 102 u32 dmamux_nr = fsl_edma->drvdata->dmamuxs; af802728e4ab07 drivers/dma/fsl-edma.c Robin Gong 2019-06-25 103 unsigned long chans_per_mux = fsl_edma->n_chans / dmamux_nr; d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 104 d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 105 if (dma_spec->args_count != 2) d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 106 return NULL; d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 107 d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 108 mutex_lock(&fsl_edma->fsl_edma_mutex); 178c81e58e9155 drivers/dma/fsl-edma.c Jingchang Lu 2014-02-21 109 list_for_each_entry_safe(chan, _chan, &fsl_edma->dma_dev.channels, device_node) { d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 110 if (chan->client_count) d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 111 continue; 211bfef7c2bc8c drivers/dma/fsl-edma.c Jingchang Lu 2014-07-01 112 if ((chan->chan_id / chans_per_mux) == dma_spec->args[0]) { d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 113 chan = dma_get_slave_channel(chan); d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 114 if (chan) { d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 115 chan->device->privatecnt++; 82d149b86d31e1 drivers/dma/fsl-edma.c Yuan Yao 2015-10-30 116 fsl_chan = to_fsl_edma_chan(chan); cee8cbfc7be8ff drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 117 fsl_chan->srcid = dma_spec->args[1]; 6aa60f79e6794b drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 118 6aa60f79e6794b drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 119 if (!fsl_chan->srcid) { 6aa60f79e6794b drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 120 dev_err(&fsl_chan->pdev->dev, "Invalidate srcid %d\n", 6aa60f79e6794b drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 121 fsl_chan->srcid); mutex_unlock(&fsl_edma->fsl_edma_mutex); before returning 6aa60f79e6794b drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 122 return NULL; 6aa60f79e6794b drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 123 } 6aa60f79e6794b drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 124 cee8cbfc7be8ff drivers/dma/fsl-edma-main.c Frank Li 2024-03-23 125 fsl_edma_chan_mux(fsl_chan, fsl_chan->srcid, 82d149b86d31e1 drivers/dma/fsl-edma.c Yuan Yao 2015-10-30 126 true); d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 127 mutex_unlock(&fsl_edma->fsl_edma_mutex); d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 128 return chan; d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 129 } d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 130 } d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 131 } d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 132 mutex_unlock(&fsl_edma->fsl_edma_mutex); d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 @133 return NULL; d6be34fbd39b7d drivers/dma/fsl-edma.c Jingchang Lu 2014-02-18 134 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki