From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7163CF9C6B for ; Tue, 24 Sep 2024 10:50:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 296276B0082; Tue, 24 Sep 2024 06:50:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 245AA6B0083; Tue, 24 Sep 2024 06:50:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1354F6B0085; Tue, 24 Sep 2024 06:50:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E9D8C6B0082 for ; Tue, 24 Sep 2024 06:50:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 776ED161917 for ; Tue, 24 Sep 2024 10:50:21 +0000 (UTC) X-FDA: 82599312642.09.FD7C3BC Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 6C819A0004 for ; Tue, 24 Sep 2024 10:50:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727174900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3ulTNaLTdXQKd7FSLz32cbPtDXklPPN6vWZaA/VLFg=; b=sgoeaSpLTqs12VHfLnv9oU73kNO0h/daW1J5IeWbEWJa8PJGFiw5ct4tAwOjoTiBb3/vxP zGJHHYoZe4WUoOLq7txIiMaZoGGewM8ocnVtUxdjvIvfWU0mqfe5rhzNnCKumfaeXNL6g1 7u2H6FSJ4QXCLa0iArqiZgdjEo1gn+A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727174900; a=rsa-sha256; cv=none; b=BVxaibQoIdIEpj7110QMyrCkEXehqt/RVToKTeRlh+05D4/9hqsTMygIcYAdcIjAeL2L+k nXfKQs8fH34q8jsmuebYnwBY4MVUpC5ESp3fw8LwBc+Ui+rTpMDVKKWJx2en11IoWfgoCP y7+ChUEm3nHZZ8sKt6kqpk8Sm66RTEQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07105DA7; Tue, 24 Sep 2024 03:50:48 -0700 (PDT) Received: from [10.163.37.113] (unknown [10.163.37.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9FA4A3F528; Tue, 24 Sep 2024 03:50:16 -0700 (PDT) Message-ID: <42545fc6-8c91-4f20-9959-2416b9e112c2@arm.com> Date: Tue, 24 Sep 2024 16:20:13 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory_hotplug: Print the correct pfn in do_migrate_range() To: Li Zhijian , linux-mm@kvack.org Cc: David Hildenbrand , Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org References: <20240924101555.327091-1-lizhijian@fujitsu.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240924101555.327091-1-lizhijian@fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 31xcjtb5tnkbw5pke476n64za5eer8xe X-Rspamd-Queue-Id: 6C819A0004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727175019-605207 X-HE-Meta: U2FsdGVkX1+mQlGXvkL9VDPfdwDfAJnvnTbi4GaOSip22YBHXFlkvoYxlH4PtNPZ27rF9Iv4J3WrpE0EUO0FU03G1iTuIpPPhwPTgRJ0ZLMHz1T/KLyhESQ8+Ncv7y5jfBuNl7/5jY0v6oqugOTxk/CfVyTQqepIpOMM2f2PlpH3cQYra9VibGDMLHG9jhxQIDo9ZL2TbRCwit5GOkW+6ejtAyn2dSOp4MTnEx/0mrcFnak9UXooHuxL1pJvS0JC4bRCoj/Cz/ljfiQNNs37K5cYZbUwLBWm3+IqX4EYKDZGV6Zwsv8vo1+p421bP4Tmbaa/h7id9ybpRks5y4GP4e8JEkIF9WbsatURGg0zI/KCIzZnCbhPj8NZtj+JCA1NvXtWy39NyV8hd+eFd3WvMFvzm7eBH1a+WjQ58iuDH5E/mc8ImoRU5m8ZzTYEgEHwUpnXonkA55uKkXEMBfoA/wMcIz+0n7y3/dQiQD8rnuftTsrbG0Uuawzy1lFr0fXja2dkvJnir8zi49KlQVA8X/bLB3ZPoHQ1eT/eKbuVmXaLRCpmtOYyhxTrJW+WjimAK8c2NvXOVuY+fyXvAToaf0IfTYHYTQXnlSbe13JbOHp52ZfEmHjuUj/EUyZ9W08/lwwN4h81/BFpq7XjBCFz3PXPGoc8rdiAj/67YxBGA9a9Gyf0/7y8eWjbzhRDQONg+bQBwC68ByBfm2bIQl3Rw/g6IdK9UMwe7EmMpUb526TrDQ5ZqkKy5ngIYBGjXvCOmUjyU0ofP9s93YS65VxKM1Knfir/h8x34PdsvpKT35bxduyUKXWSnyLMXzEEKJGyv9Ws5dZtpOFenJE/r2ypkJW9PnzVlZ3lETP5+EgpS0rgFSwi9wRltxRqZfZpJVKnVydIrXoGYZDqt5apBSlUZzWCS3O5kULB7ygtoGyy6aYXJHJ7DvNHXYk+lUHfLPfUoZ4y57yK+h4wBJmyAYo 95MT2SWc H77P9SA2+3dwFDvhNFFuOfyPxthCvpnVCKxCnxjUXIbcNZSm5je7Y8M1hHHN7FZDfX63hqNrYt4Q6zz+5jtwFATRtjh7azMMqQtzfzgYuxhdcMpq2W/FdE6E32dgyEdiiu2SQepXCG49dgF3gLHHllCyS/kjVcFfeP+QABgT6S3899kTvklSzpZH9lbzddh68kOlUrOVSoD9lhTqN5ySIX9L6Wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/24/24 15:45, Li Zhijian wrote: > The pfn value needs to be retrieved correctly when PageTransHuge(page) Where the pfn could have been modified with pfn = page_to_pfn(head) + compound_nr(head) - 1 So retrieving from page will get the original pfn value ? > is true. Fix it by replacing the usage of 'pfn' with 'page_to_pfn(page)' > to ensure the correct pfn is printed in warning messages when isolation > fails. > > Signed-off-by: Li Zhijian > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 26790c8d5b43..000430406a9e 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1829,7 +1829,7 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > } else { > if (__ratelimit(&migrate_rs)) { > - pr_warn("failed to isolate pfn %lx\n", pfn); > + pr_warn("failed to isolate pfn %lx\n", page_to_pfn(page)); > dump_page(page, "isolation failed"); > } > }