linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ray Bryant <raybry@engr.sgi.com>
To: Hirokazu Takahashi <taka@valinux.co.jp>
Cc: Dave Hansen <haveblue@us.ibm.com>,
	Marcello Tosatti <marcelo.tosatti@cyclades.com>,
	linux-mm <linux-mm@kvack.org>
Subject: patch to remove warning in 2.6.11 + Hirokazu's page migration patches
Date: Fri, 25 Mar 2005 12:05:38 -0600	[thread overview]
Message-ID: <424452F2.7080206@engr.sgi.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hirokazu,

The attached patch fixes a minor problem with your 2.6.11 page migration
patches.

-- 
Best Regards,
Ray
-----------------------------------------------
                   Ray Bryant
512-453-9679 (work)         512-507-7807 (cell)
raybry@sgi.com             raybry@austin.rr.com
The box said: "Requires Windows 98 or better",
            so I installed Linux.
-----------------------------------------------

[-- Attachment #2: fix-warning-about-clear_user_pages-in-memory.c.patch --]
[-- Type: text/plain, Size: 1310 bytes --]

This patch fixes a warning in the compilation of mm/memory.c when
Hirokazu's 2.6.11 memory-migration patches are applied.  The warning is
due to the fact that clear_user_pages() below needs to pass a
void * in as its first argument, since, (at least on ia64),
clear_user_pages() is a macro that calls clear_page(first arg to
clear_user_pages()), and clear_page() wants a void * argument.

The change below was suggested by Christoph Lameter and both
avoids this problem and makes the code simpler.

Signed-off-by: Ray Bryant <raybry@sgi.com>

Index: linux-2.6.11-page-migration/mm/memory.c
===================================================================
--- linux-2.6.11-page-migration.orig/mm/memory.c	2005-03-24 11:24:09.000000000 -0800
+++ linux-2.6.11-page-migration/mm/memory.c	2005-03-24 15:01:23.000000000 -0800
@@ -1323,11 +1323,9 @@ static int do_wp_page(struct mm_struct *
 		goto no_new_page;
 
 	if (old_page == ZERO_PAGE(address)) {
-		if (VM_Immovable(vma)) {
-			new_page = alloc_page_vma(GFP_USER, vma, address);
-			if (new_page)
-				clear_user_page(address, address, new_page);
-		} else
+		if (VM_Immovable(vma))
+			new_page = alloc_page_vma(GFP_USER | __GFP_ZERO, vma, address);
+		else
 			new_page = alloc_zeroed_user_highpage(vma, address);
 		if (!new_page)
 			goto no_new_page;

             reply	other threads:[~2005-03-25 18:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-25 18:05 Ray Bryant [this message]
2005-03-25 18:03 ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424452F2.7080206@engr.sgi.com \
    --to=raybry@engr.sgi.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-mm@kvack.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=taka@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox