From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98469CFA779 for ; Fri, 4 Oct 2024 13:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E59996B0406; Fri, 4 Oct 2024 09:14:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E09A76B0407; Fri, 4 Oct 2024 09:14:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAA2D6B0408; Fri, 4 Oct 2024 09:14:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AD9176B0406 for ; Fri, 4 Oct 2024 09:14:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5B87D16177D for ; Fri, 4 Oct 2024 13:14:25 +0000 (UTC) X-FDA: 82635963690.12.6C2C857 Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by imf05.hostedemail.com (Postfix) with ESMTP id 47B1E100010 for ; Fri, 4 Oct 2024 13:14:22 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=EUhO0cpy; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="Q TuyBj9"; spf=pass (imf05.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.151 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728047596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8kN5t+2aLHatwDnBUDj7f35725qTXfQc5j12nPWEaMY=; b=RXyHSZAeIFjmXF3wGv3KNPYeOdR3Ol2bZ25sWWw9FUdoAb9K0rw39Ri51EvlBsq2VfFkkA R0kuZpyDw2TaKXWDeudjr5B81mQ4jKiD8quKcEvNWdrirdxPBTwukpwWX2Daa/vEvKsj/0 ZvQcpYlHwi3BgmCu3b0qI0TtXffIpyI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=EUhO0cpy; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="Q TuyBj9"; spf=pass (imf05.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.151 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728047596; a=rsa-sha256; cv=none; b=0JLLX1hBEsDfl+w8Ej4LcuSLe05GKojiDkKMdI1iimxs3ubSIwFNkVXvdhVHz3LgGuui3t ihpBcgEO6QwJ8syA1Me0smjNL5TG1tgkVd4U7S+s7zO09pTHqKFrkR/6wXEDhXzTiM4eL5 4hEg3iGWhDgJMECBuogqWIA6gbUowV8= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 8FF181380279; Fri, 4 Oct 2024 09:14:21 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 04 Oct 2024 09:14:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1728047661; x=1728134061; bh=8kN5t+2aLHatwDnBUDj7f35725qTXfQc5j12nPWEaMY=; b= EUhO0cpybdFHco6SGBW+rSmWu6t89tMszlMlq/s3hzW+0gjHOu6imMWa5yVwGUZj EeH94i90VO5TTp7LnGyB3Y6WfyUeIj3wDColtuoEUhY55NvnjJR+JrPZzxVPnhmg iIytcouawzXA/P/st9PEbFPD30PdEAeUmVUx9XUQE0dk6hL4kL4SPnI+yYLBDpCL tUG7gO6TIvyKi2auAYMlO06wQujZWZuoyLzLK1S6DWcNNHCsoiry9hDpwHch0v/a 9g0vGAN2QX7GafF+MtjehXcVL1osfWwQTxT/BwUp8LPHIjqYGF9PEvoGDBkvwYF5 Z6MfW6DFaAhFTf0unXrnNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728047661; x= 1728134061; bh=8kN5t+2aLHatwDnBUDj7f35725qTXfQc5j12nPWEaMY=; b=Q TuyBj9iVpeIWVEGMfZ9vFXUOQXFqZ4PFgsekgS+xf0ZOT2QWw7vG7dIG7bRc5KrA A+J8TNN/PdBYp0zfv+uXRMIPaTnSoDD3EPS2pAju0VsXzXGriJrTJxfLbvBQ2wd2 Xg/qIXEa2M5VMWNs49AFgaa3yRsizOLCbekhflf3Npv9kt2bBgApfzUfwklwSjwn 0kwHvzkor1mOS1IGCgfoAPg02FAlO6yNHowyiVjnGwovQbLMAlQ5vCEY863Iu/5t PwTlEEmosLl9wN+k2mwWO6+EYjFfkMVz2zkdqIs8qZogPFBfqJJLBMw5EIws4T9j Cvz7YwMS2f1qEDAvxhk6w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvfedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvddt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprh gtphhtthhopehvihhntggvnhiiohdrfhhrrghstghinhhosegrrhhmrdgtohhmpdhrtghp thhtoheptghhrhhishhtohhphhgvrdhlvghrohihsegtshhgrhhouhhprdgvuhdprhgtph htthhopehmrghthhhivghurdguvghsnhhohigvrhhssegvfhhfihgtihhoshdrtghomhdp rhgtphhtthhopehmphgvsegvlhhlvghrmhgrnhdrihgurdgruhdprhgtphhtthhopehnph highhgihhnsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprhhoshhtvgguthesghhoohgu mhhishdrohhrghdprhgtphhtthhopehluhhtoheskhgvrhhnvghlrdhorhhgpdhrtghpth htohepmhhhihhrrghmrghtsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 6A18C2220071; Fri, 4 Oct 2024 09:14:19 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 04 Oct 2024 13:13:46 +0000 From: "Arnd Bergmann" To: "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Christophe Leroy" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: <423e571b-3ef6-4e80-ba81-bf42589a4ba8@app.fastmail.com> In-Reply-To: <20241003152910.3287259-3-vincenzo.frascino@arm.com> References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 47B1E100010 X-Stat-Signature: 3hniqjng4re1pgen76ee6gzpro37y94a X-HE-Tag: 1728047662-649336 X-HE-Meta: U2FsdGVkX182MkS8kEOE+RkpyCUGT0vQv7xB48iO/KwGnBmiPZDZJIyHMGhBdchy86gyUK181yYYmFbl0p9ePkGwXns1zRoLjk28GMhIuDipyTI0/6lPdx0sMIumMbIYWkfi3Kqw+yjVWsLRe0rLgbfD64LjpP9yTsjY4bA/hJXWB+zlIrcyfwKsdx9lHtoY3CHh0mPtYRE0ZTErZwoYy3OLq/DVjUbaMpu8C96/76r5aTaWESxQtzmCKCF2PT0SANbiaXfb++U7dLIT9oLdYynC23/XBP6tJVBFvBb5CLdMkwnaXKyJNdUtaoBm5v1wu2UdhkjJDIVdxqixFzUQWP7dkFvyGYJ8XIMO4JTcxG5jsjyeLKRZLGRzrqcTEa5OfcMWg/HZ6kSPg9R0nxdH7j5OFf6R/e+YRTogaUNCr0jCArD6FXkj4DXsah5FKlMq84GUBrxSpsCvG2VDMSyqb2zTmzpobYISATuUR0j2SLiL+JqNb/LwnhtlLhPXOIHZI2iLc2mrD4ek7jlv9c8m4/Zy8DFG5SRL4g1NFCaOeGUv5v5T1jKNJjw5iRVAdNUyDGfgG/+0H1gYAaYezDyqiAEonu2ly0UUIYtW7VUAfbFRU11DY7wHga/yMZiPT5/aqJXCtGxphCiTl48aJgZCOv/GkRnv3czs3uawc7vGVyW8mdj7JeDuq6F5e+rI2hmY1uDAbbmz8lX1PKn56oFrWu5BFGNvwkM7/Fv/qkVVlPyxM+Wgt4P7uJsw3+aQxUJtIxFH3muP+rZJEeCN4Oq1fch0zdp2Tz1koIc/Wq2bctHLzD5dtRnJSd8CJVTCPhYETdivQMJaNfbiz5g0fyyKlAQVq1wESSs11xge8ttdV85gbXKYHzwjelsfGuY7gfL2nM1CCj5k3mUKb1dcAyKNo0Q6Qs3OB0BQaVInzlXE4nzb11NydV74yEWPkwu3AMzYN+i4ar8Zaa+QPTP9kv3 XkschNsl vH6IAyGPpQp8qSnLe4DnIc0qsw/j0SxHlvtkcg9iqt9Oz45Vgh12iY3RzPQQch0/zdZrYsV3nUUBSHoUf8mwdtrNmSD5lvgTtaYMaNGRUtT7N6ZyTi3xEkW352lMV7YKKPYGistEd0alMh2rT1/IK746R8alCD4TpA8czPzKaj2Pnz03StvJaTRmCLCtiC7Y6TpCd3bEU8QY31UKGVkpSZo8H+N3hcH7YFg8iwFwnOyPRtJK2O4l6lZXM7SeHrmVHTtkfOTZ3wY4JwJKe9040TTCGn5gPpRdrxxBdMF8Wcj+ivPjBK1PIgBV2rAOEBo9Ze1SGJ2NxRwTE3hg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 3, 2024, at 15:29, Vincenzo Frascino wrote: > The VDSO implementation includes headers from outside of the > vdso/ namespace. > > Introduce vdso/page.h to make sure that the generic library > uses only the allowed namespace. > > Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when > it supports 64-bit phys_addr_t we might end up in situation in which the > top 32 bit are cleared. To prevent this issue this patch provides > separate macros for PAGE_MASK. > > Cc: Arnd Bergmann > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Cc: Jason A. Donenfeld > Signed-off-by: Vincenzo Frascino Looks good to me. I would apply this to the asm-generic tree for 6.13, but there is one small detail I'm unsure about: > +#if defined(CONFIG_PHYS_ADDR_T_64BIT) > +#define PAGE_MASK (~((1 << CONFIG_PAGE_SHIFT) - 1)) > +#else > +#define PAGE_MASK (~(PAGE_SIZE-1)) > +#endif We only want the #if branch for 32-bit architectures, right? On 64-bit ones, CONFIG_PHYS_ADDR_T_64BIT is always set, so I think that is unnecessary change from the existing version, even though it should be harmless. Arnd