linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Paul Mackerras <paulus@samba.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, akpm@osdl.org, davem@davemloft.net,
	wli@holomorphy.com, riel@redhat.com, kurt@garloff.de,
	Keir.Fraser@cl.cam.ac.uk, Ian.Pratt@cl.cam.ac.uk,
	Christian.Limpach@cl.cam.ac.uk
Subject: Re: [PATCH 1/4] io_remap_pfn_range: add for all arch-es
Date: Fri, 18 Mar 2005 15:19:52 -0800	[thread overview]
Message-ID: <423B6218.6010602@osdl.org> (raw)
In-Reply-To: <16955.23669.792362.539790@cargo.ozlabs.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Paul Mackerras wrote:
> 
> Just by inspection, this looks like pfn should be changed to
> paddr64 >> PAGE_SHIFT in that last line.
> 
> Paul.

Agreed, thank you.  Patch is attached.

-- 
~Randy

[-- Attachment #2: ioremap_ppc_shift.patch --]
[-- Type: text/x-patch, Size: 792 bytes --]


Fix asm-ppc argument, spotted by Paul Mackerras.

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
 include/asm-ppc/pgtable.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Naurp ./include/asm-ppc/pgtable.h~ioremap_ppc_shift ./include/asm-ppc/pgtable.h
--- ./include/asm-ppc/pgtable.h~ioremap_ppc_shift	2005-03-18 10:20:47.000000000 -0800
+++ ./include/asm-ppc/pgtable.h	2005-03-18 15:15:56.000000000 -0800
@@ -743,7 +743,7 @@ static inline int io_remap_pfn_range(str
 					pgprot_t prot)
 {
 	phys_addr_t paddr64 = fixup_bigphys_addr(pfn << PAGE_SHIFT, size);
-	return remap_pfn_range(vma, vaddr, pfn, size, prot);
+	return remap_pfn_range(vma, vaddr, paddr64 >> PAGE_SHIFT, size, prot);
 }
 #else
 #define io_remap_page_range(vma, vaddr, paddr, size, prot)		\

  reply	other threads:[~2005-03-18 23:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-18 19:25 [PATCH 0/4] io_remap_pfn_range: intro Randy.Dunlap
2005-03-18 19:32 ` [PATCH 3/4] io_remap_pfn_range: fix some callers for XEN Randy.Dunlap
2005-03-18 19:33 ` [PATCH 1/4] io_remap_pfn_range: add for all arch-es Randy.Dunlap
2005-03-18 22:55   ` Paul Mackerras
2005-03-18 23:19     ` Randy.Dunlap [this message]
2005-03-18 19:34 ` [PATCH 2/4] io_remap_pfn_range: convert sparc callers Randy.Dunlap
2005-03-18 19:35 ` [PATCH 4/4] io_remap_pfn_range: convert last callers Randy.Dunlap
2005-03-18 20:56 ` [PATCH 0/4] io_remap_pfn_range: intro David S. Miller
2005-04-20  1:38   ` William Lee Irwin III
2005-04-20  1:37 ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423B6218.6010602@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=Christian.Limpach@cl.cam.ac.uk \
    --cc=Ian.Pratt@cl.cam.ac.uk \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=kurt@garloff.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paulus@samba.org \
    --cc=riel@redhat.com \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox