From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EC7C3DA4B for ; Wed, 17 Jul 2024 12:25:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8FB56B009B; Wed, 17 Jul 2024 08:25:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C489D6B009C; Wed, 17 Jul 2024 08:25:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2D546B009D; Wed, 17 Jul 2024 08:25:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 949B96B009B for ; Wed, 17 Jul 2024 08:25:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 50290A24AD for ; Wed, 17 Jul 2024 12:25:07 +0000 (UTC) X-FDA: 82349164254.03.7B6DD55 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 926B91A001C for ; Wed, 17 Jul 2024 12:25:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721219067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qm8vE7bptpeF1QqWeUrB2Vw0GI5t4l/X5LQyHKn7dLI=; b=uGtDaITCnoKcVfZAiHFx9CVxkhXqBN4GtJp/Ftt9AIVl6+8KifNqfyBsvOiefemxLeZ1Ix 82IILdnvNDv8/hOhTOvzPpKgiMKeApQJiAXEZVeIQ31v9xPSXQBwY819kJMrYQzf0dLD89 1sS/iUcGKdeoc3r9ide1wO7S4PcSezU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721219067; a=rsa-sha256; cv=none; b=IT1Nm+IaSx9QO4zKUs8+aV1k08k3FieDubsJl9gws/fSsB96ZcYj3XNKXdW8pjmmePMT95 u8yX99bfzXjDNkc1FLaonXddOxDRsMdqPTvXa+RMU3Qmo2Ow9tUAEROE6a2By9uKAffBiv WAddtPTFwy6+r6PkgLcTzVSDckk+ccE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21AE11063; Wed, 17 Jul 2024 05:25:30 -0700 (PDT) Received: from [10.57.77.222] (unknown [10.57.77.222]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A3263F766; Wed, 17 Jul 2024 05:25:03 -0700 (PDT) Message-ID: <423341da-57ae-4e44-a7f6-74f8ebfd3962@arm.com> Date: Wed, 17 Jul 2024 13:25:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Skip test for non-LPA2 and non-LVA systems Content-Language: en-GB To: Dev Jain , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Anshuman.Khandual@arm.com, broonie@kernel.org References: <20240717111011.316037-1-dev.jain@arm.com> <3782befb-c317-4bb0-a279-c90adb2ec47b@arm.com> From: Ryan Roberts In-Reply-To: <3782befb-c317-4bb0-a279-c90adb2ec47b@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 926B91A001C X-Stat-Signature: t8oye17dt6ncpzxw89j71us9m1qdwfiq X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721219105-243382 X-HE-Meta: U2FsdGVkX18cOpvjTMZ/mOTpiemWL/jppuPOK7q0bUq3W7dVQcwJ+jHSEZT83ZQ0Guhc3KdGjUdS7r42VuTASbWgJbe2tqC1TT6kxd2p2zcOiQOyuW829f3MlUcvGickAXtvGk3omSEud9S7wnphD27HbaiD/qb1Bc1gdA7b2FGZcseGnKUpwHHlKLQ7jbYCO+Y+DQe/Q0pJBtEem5im/+6GmKHR0+8xQTLvd3yQSQYTifwmV8RfkukPsQIvOgG0Ub1v2nBR95flpkmQ25kNygUHTqzOIlaVlp/BWpDeJDJc+Yf3AY5p3rl8TXQo9Xwrj4ekDGbDvGCszDhoUyWTnUsNuuClup8Q4yhfSs92vXgBz6AXA1ywCwcDVyQ0rppr7JhDBcgDoGC4S8QGu705PDaPOifPREO8UFZYT3/gjysfjbAeG2bXNa0W9W4Nf4xNm1aqr8jvPyFMQQbDjI7tH5SXlFPNGoi8pUz6avtPaTiA2U0UdsNcui0kmcifGNcwtDojxvWrR/rW4vUGt0dkiftZ2qAN7Z4TPBLzsGeHxTDHpZzn/HrngQ8tY3tOFlvSBGWuTn+qFWYy3gvMAaLool8I/SulaJs+kqaxjWYZPUSv933bwpKEscus1WWXVWISdRz37uctwnXi2fdkB8GLTQGYSoT7EpAKk8C+chHwn/JnP7dWHZ/3gEJXQEt5DC2GTY0rZZF8wtzrdALMYL8R4oYDYaJM3LmTt1Jh0Q/cD00+gdce2Ip7YWZMaS18j6U3uZhk1Rs7M8mZxActTo1mZdM0dwaehEWps9pm8NG28893oVDljptphZNM5Nd2LxqqWYPkmxcDD6GyQwgukZU5H49CQ/l9Q5tRNakpYs/OLClGEkyA+BUHg+95/L3EtpbMvBc7AHDU8uAU8qC2OBSPR4cxhqP3/7sC4ak3jks1urLN7T/MrNIDBWS97UKNKyky4vwlIjMtnBKdWzZ16p2 GglVOJB4 2WBQXSjZQel9i30XwcbQyZ5mGUTemHAnsSWicJHpywsrebG9pwUrb/6nnPbISgVV678gCo3I9a9w/zwb7yw5M2DUy8waFMQiQ9mdtV0px8AB2NGyxFwG88+qTkxQ82VfBHnNf05erUewyQy3ZW85xf/Nmrtp5BH5YpfHnb8NzDNu6CtD6F3jXoJh+EerKXsBNGtBv/JQowsstdpRh+mtqXSWD/2YicZGEXscqzUbZLFs1J5XxIHqeTwFsQNEOKbga4ep4pJo5//JCooH/gnDkID3K/D1R8KBxXo7T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/07/2024 13:11, Dev Jain wrote: > > On 7/17/24 17:27, Ryan Roberts wrote: >> On 17/07/2024 12:10, Dev Jain wrote: >>> Post my improvement of the test: >>> https://lore.kernel.org/all/20240522070435.773918-3-dev.jain@arm.com/ >>> The test begins to fail on 4k and 16k pages, on non-LPA2 systems. To >>> reduce noise in the CI systems, let us skip the test when higher address >>> space is not implemented. >>> >>> Signed-off-by: Dev Jain >>> --- >>> The patch applies on linux-next. >>> >>>   tools/testing/selftests/mm/va_high_addr_switch.c | 14 +++++++++++++- >>>   1 file changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.c >>> b/tools/testing/selftests/mm/va_high_addr_switch.c >>> index fa7eabfaf841..c6040e1d6e53 100644 >>> --- a/tools/testing/selftests/mm/va_high_addr_switch.c >>> +++ b/tools/testing/selftests/mm/va_high_addr_switch.c >>> @@ -293,6 +293,18 @@ static int run_test(struct testcase *test, int count) >>>       return ret; >>>   } >>>   +/* Check if userspace VA > 48 bits */ >>> +static int high_address_present(void) >>> +{ >>> +    void *ptr = mmap((void *)(1UL << 50), 1, PROT_READ | PROT_WRITE, >>> +             MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0); >> I think there is (very unlikely) possibility that something is already mapped at >> this address so it will be replaced due to MAP_FIXED. That could break the test. >> But the only way something could be already mapped is if ARM64_FORCE_52BIT is >> set and in that case, the test will fail anyway, right? So I think this is fine. > > The testcases already assume that high addresses must be empty. Yes, FORCE_52BIT > is the only way something could already be mapped at high addresses, but in that > case the test fails trivially. agreed. > >> >>> +    if (ptr == MAP_FAILED) >>> +        return 0; >>> + >>> +    munmap(ptr, 1); >>> +    return 1; >>> +} >> I'm guessing this will cause a function-not-used warning on arches other than >> arm64? Perhaps wrap it in `#ifdef __aarch64__`? > > Ah yes, I just checked and that is true. I shall post v2 in some time, shall > wait if any more comments are there. With this fixup: Reviewed-by: Ryan Roberts > >> >> Thanks, >> Ryan >> >>> + >>>   static int supported_arch(void) >>>   { >>>   #if defined(__powerpc64__) >>> @@ -300,7 +312,7 @@ static int supported_arch(void) >>>   #elif defined(__x86_64__) >>>       return 1; >>>   #elif defined(__aarch64__) >>> -    return 1; >>> +    return high_address_present(); >>>   #else >>>       return 0; >>>   #endif