From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25EC6C32772 for ; Tue, 23 Aug 2022 14:09:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A30CB8D0002; Tue, 23 Aug 2022 10:09:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DF958D0001; Tue, 23 Aug 2022 10:09:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8808B8D0002; Tue, 23 Aug 2022 10:09:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 762C48D0001 for ; Tue, 23 Aug 2022 10:09:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 27490A1624 for ; Tue, 23 Aug 2022 14:09:00 +0000 (UTC) X-FDA: 79831038840.30.6DCF674 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf28.hostedemail.com (Postfix) with ESMTP id A76E3C0074 for ; Tue, 23 Aug 2022 14:08:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5DC9E1F8FF; Tue, 23 Aug 2022 14:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661263738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qqt+sqPfQ5YZMyDpqRmx3/6lQYTEzFiEGh9Y/BPZ7oo=; b=tSjKqvrTKocvq6Ylkq3q678K3+RuzZy1LqQ+Tzu7rWhrbJIZ3lUEYbE+TaqPz+UnptO6fe gITrAy1pOEdpca1l/xVR8Cwz6DODiRJ6FuFTVRvdOhsig4WpOuSbSj9xMUD8FMQQo+MWP4 174oM7DibqY0+fa0HXhaCt7pzyKtsxw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661263738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qqt+sqPfQ5YZMyDpqRmx3/6lQYTEzFiEGh9Y/BPZ7oo=; b=CvyHJyKm8vmChdO4dt4xvi7pyckLkFDrGvCgONpTO312QxH6+nlaZ1KVWtV+z84D3FlxBM pA4vQy39x/rbRACg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0479A13AB7; Tue, 23 Aug 2022 14:08:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jed6OnnfBGO5dwAAMHmgww (envelope-from ); Tue, 23 Aug 2022 14:08:57 +0000 Message-ID: <42323fe6-3ac1-4dff-cf49-6e97525df837@suse.cz> Date: Tue, 23 Aug 2022 16:08:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH linux-next v2] mm/slub: Remove the unneeded result variable Content-Language: en-US To: cgel.zte@gmail.com, 42.hyeyoo@gmail.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot References: <20220822013830.199836-1-ye.xingchen@zte.com.cn> From: Vlastimil Babka In-Reply-To: <20220822013830.199836-1-ye.xingchen@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661263739; a=rsa-sha256; cv=none; b=8GGrJvxBA8tCqAiMUoCIWfiBm16Gdgs9x4Vgz8KaJ2kwKuyVXd5BmYE63YteiYAiAGnXLM jqojqSCur8+R/PRnCwaHfN07NJqui4GaxUeqPt5jm5R6tG0QYZM1HsMJo4rMs4BzhI4QP5 NaR2jZsi6uQf0DiyLgi5CgVh8Oskxjc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tSjKqvrT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CvyHJyKm; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661263739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qqt+sqPfQ5YZMyDpqRmx3/6lQYTEzFiEGh9Y/BPZ7oo=; b=u05ZSiegVvLyvHInocD7NwHIAz4x2hwmVUi381NG3kLYpyBp3BxgTlqRr2eUx3zWxx8/h/ JPsA7wJuoGKcQ+kkY5bqpUPWXws/tMMQilpvxfIRDmmr1XvZ8mp2Eamvo5BAGcs0Ap71xb AVHDitBre2Odyuywnw6QBVbWerhZJpw= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A76E3C0074 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tSjKqvrT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CvyHJyKm; dmarc=none; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Stat-Signature: q9d7scmyctkhiowqjhufo3jyespr8r3m X-HE-Tag: 1661263739-349534 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/22/22 03:38, cgel.zte@gmail.com wrote: > From: ye xingchen > > Return the value from attribute->store(s, buf, len) and > attribute->show(s, buf) directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Signed-off-by: ye xingchen Thanks, added to slab.git for-6.1/trivial > --- > v1 -> v2 > Add the whitespace between subsystem and summary in subject line. > mm/slub.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 6953c3367bc2..7bea010a20ff 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -5852,7 +5852,6 @@ static ssize_t slab_attr_show(struct kobject *kobj, > { > struct slab_attribute *attribute; > struct kmem_cache *s; > - int err; > > attribute = to_slab_attr(attr); > s = to_slab(kobj); > @@ -5860,9 +5859,7 @@ static ssize_t slab_attr_show(struct kobject *kobj, > if (!attribute->show) > return -EIO; > > - err = attribute->show(s, buf); > - > - return err; > + return attribute->show(s, buf); > } > > static ssize_t slab_attr_store(struct kobject *kobj, > @@ -5871,7 +5868,6 @@ static ssize_t slab_attr_store(struct kobject *kobj, > { > struct slab_attribute *attribute; > struct kmem_cache *s; > - int err; > > attribute = to_slab_attr(attr); > s = to_slab(kobj); > @@ -5879,8 +5875,7 @@ static ssize_t slab_attr_store(struct kobject *kobj, > if (!attribute->store) > return -EIO; > > - err = attribute->store(s, buf, len); > - return err; > + return attribute->store(s, buf, len); > } > > static void kmem_cache_release(struct kobject *k)