From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE4CBC001E0 for ; Mon, 10 Jul 2023 14:42:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2E206B0072; Mon, 10 Jul 2023 10:42:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDD3B6B0074; Mon, 10 Jul 2023 10:42:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA5596B0075; Mon, 10 Jul 2023 10:42:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C9C6F6B0072 for ; Mon, 10 Jul 2023 10:42:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 97F81A0121 for ; Mon, 10 Jul 2023 14:42:46 +0000 (UTC) X-FDA: 80995968732.22.D35E63B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id BC9AB1C0021 for ; Mon, 10 Jul 2023 14:42:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WyO5Yjjy; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689000163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MIODQnbo/NgeDrzfi2tDK7epimHDG1N7qvwlqDMT7Hw=; b=H2yMy9nEkhq6k+/Duv2E/xLJuB5WSEg25zPiru6tsRWb4GC+nr3CPyIC2rLd+OoHTj9z1b jx8qIh/AJn5d7IACNUzMUe2vcnksff1p6WQ74WN75LOhhLmCNB0krkyYltQk9fIG6i6p7j cN2MeEROjKk65ATDJn6O1lDNDJ50Z9Y= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WyO5Yjjy; spf=pass (imf21.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689000163; a=rsa-sha256; cv=none; b=mVFGFReiRvVf6hoFaTJA5H+voRA+IdTGjKSXZHFyxAIyyvEsEf/4fpGOJtaivBMDE4jVGm /Bh5Xki54JzlwxhLUGszQMs7JvM1Ys7NAAjzF9F5nYLEy0ycXlzs9MP7pOB/4hBqac6Hx0 5afAore9u5TTwqzRWR580ZpA1Q0gcfw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 82F006102E; Mon, 10 Jul 2023 14:42:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89EA2C433C7; Mon, 10 Jul 2023 14:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689000161; bh=Wu+duyOH7hgJOuFokRvIdbi+c935axibdDhN7x79hL8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WyO5YjjyoFiKVOWDebCbwAk1wJw1SqM+YKCVmI4cUNbYxYZ6AN18AhiIUEiRVsLL3 5IqymXfvWU/K2isVwk04dCZX2e85p6z+QJyTZgbT22l0rrtKlC304r869z8EMpubQt 6yWCQRZmAxQa52mKkI7gzbndc9Ks1SoXLgCn5QgB6vBrzSPPuY7rm5xJWBV0QbWn3p tVHp6xcTk48loiqTRd9v1blPRQ5HCUSUMK3E9S/NVam/wW16g0Sebjl1ssThU+/QV2 hbQDF3qXhmAnWo/lNIqpEjRcD/a28MT/ufvhmdg+g+myUfDN5UWE/RFrSY2fIzZpa8 GRowH0sVmkQQw== Date: Mon, 10 Jul 2023 15:42:31 +0100 From: Mark Brown To: Hugh Dickins Cc: Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@leemhuis.info, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Message-ID: <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> References: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6EsuOK1fDi4bcNLc" Content-Disposition: inline In-Reply-To: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> X-Cookie: You have taken yourself too seriously. X-Rspamd-Queue-Id: BC9AB1C0021 X-Rspam-User: X-Stat-Signature: udnt1yo3jpf587knqzub4t1i9apsyz1c X-Rspamd-Server: rspam01 X-HE-Tag: 1689000163-447864 X-HE-Meta: U2FsdGVkX1+XF1yrgzcUDYyfKxN7KP7wFA0jfY2DLUz3YBkuVEEfmbfgIM3SRAV92wQ6pStImEndAgDTKAlVTTL1z6WjVRqCBp+Y1cbAc1wcE5Wux3p15b3nJL/S0n4N34YMygypbXRgh44cQj+MJADfQXkTFQW15V7IuyTBuv72kbiSkQA/Z+/w+beVkUt3tdl9ONnHJ211gaiQwNkgXuvYBqqQ0QghHgexZBCzl27/raJnl5TWSF1V6ELam4vZfBiofHFVgpsKvdszokabaNpXYSsAtyQ+73UyyMErxtanCml5/cf/bYmtOLsy8VHqXMean+avALnmCkHYN2ASHmBaERrgg1cg7BcilchBc7vciExY+6boWCUmHmxQf8aNDelM46I0OvqQ25NzUU0g7JEL4hQy0EypMtEsRdLjmjvnGTWG8oc/aORtrkEPO0EwOd42f07iih0EIoI2EpZFW0i35iSf2uauCTkUvyFDg1x5p0Kpqn2q8f1qv1HCEFPybxsQL2wHbRQyP0UZxDggxbhQ9igeMa3Y0ZDtJ4vWMOYmrq31O2aiw5duHc5J4E1mcSffUYlI/IJtqFBxqP2DhsblFgbZh7jqOv5UtFNoXiCWnkr5S1kwx4J4VxDYlJ2s0eX8P5U5TFnrDu+k1lyCTk6tUUvpkuNjCpI8cHpuflENAQHZXGmNRFgR4qY5IKLsw/00RokevvIcKGNk5AzkXDNYBIYNaDoSvEkNg4QLtRZiDB6GDSwNy+c+VOPuB+du3AR9sDwZlIi/r4MJeR37RpuSL+YHC10+PGjP3CtLle6Ndwl3HRZ8BTKHIaqM3DfEHYFi/1qJrT9sPrvXP7kwECsjUh20/neRCtF5wQPuge3JzwJiT/9W3fEmPIiWAtzbykPcQ1o2nafiwzXtLnL+hzrIusZHo4gZqueGtXP1dbh+mjzooOw8d60OS9whubM3REKndE/FJ5T0n7pwu50 jMFkeNK6 KYn++0SBSqtmfBxbgjJYZrG93Cz4atOicFaomeuUaaqwxNjQt1viCVa66FPDWK0GLGQlWZPKs9kPF2EbsfI0Aa5pcSV2swKQ+VnERIfluE7qiDPRKC4iV992QYeo5essvTIwuJgKucl6SWo1I9hrjfYbpU8tG9w/mxiKUZtjdIDr2VG+0MBB9WF+DF8DxgO9Ob8unWPrxxeFjCp9L+3yE4L7RAn36l+12PLWkuF92OQntr6v2S2eY5qdIOKaG4HMSyMbanB66QxiG0Z9HSoaImgzelSKXbb3k1lR85RTvdyCyZ2STx8vRmGGBW5XS3gV80s0I1FzTy9qEyXq2QsfShkCNWqgqZ0NxSjWYlqg8t53zQynKfrVvGRq6ITaGfT0PhbzZ5Cv+s0W9T/5X4l8S9QruZHwLr4O+wQXrBvBEFR0EXSm4d2f/fYgOdoMK/jfgGngqmHsTueh6j1GGgUmKon+882rmd/ezbukUwiyXAZ2oq4ZdoEzDQXSSAtzqCOY1CzeFe8B9BztijvcxJetD2zo+lLQ9zKbdVrUxjFJoclB8Bv+jKx37EA9Yxz8okg1ANSNUi595BBlZxwd4uhUIzj7W0NLZ7oiBauGgXd++Del1cZJSTEZOkE3oiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --6EsuOK1fDi4bcNLc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 08, 2023 at 06:21:41PM -0700, Hugh Dickins wrote: > vmalloc_to_page() was using pte_offset_map() (followed by pte_unmap()), > but it's intended for userspace page tables: prefer pte_offset_kernel(). >=20 > Signed-off-by: Hugh Dickins > Reviewed-by: Lorenzo Stoakes Currently Linus' tree is reliably failing to boot on pine64plus, an arm64 SBC. Most other boards seem fine, though I am seeing some additional instability on Tritium which is another Allwinner platform, I've not dug into that yet and Tritium is generally less stable. We end up seeing NULL or otherwise bad pointer dereferences, the specific error does vary a bit though it mostly appears to be in the pinctrl code. A bisect (full log below) identified this patch as introducing the failure, nothing is jumping out at me about the patch and it's not affecting everything so I'd not be surprised if it's just unconvering some bug in the platform support but I'm not super familiar with the code. Sample backtrace: [ 1.919725] Unable to handle kernel NULL pointer dereference at virtual = address 0000000000000000 [ 1.928551] Mem abort info: [ 1.931359] ESR =3D 0x0000000096000044 =2E.. [ 1.968870] [0000000000000000] user address but active_mm is swapper =2E.. [ 2.093969] Call trace: [ 2.096414] dt_remember_or_free_map+0xc8/0x120 [ 2.100949] pinctrl_dt_to_map+0x23c/0x364 [ 2.105050] create_pinctrl+0x68/0x3ec [ 2.108803] pinctrl_get+0xb0/0x124 [ 2.112294] devm_pinctrl_get+0x48/0x90 [ 2.116133] pinctrl_bind_pins+0x58/0x158 [ 2.120148] really_probe+0x54/0x2b0 [ 2.123724] __driver_probe_device+0x78/0x12c Another common theme is the same but with an address like 0x4c and: [ 2.098328] __kmem_cache_alloc_node+0x1bc/0x2dc [ 2.102947] kmalloc_trace+0x20/0x2c [ 2.106524] pinctrl_register_mappings+0x98/0x178 Full boot log from a failure: https://lava.sirena.org.uk/scheduler/job/712456 git bisect start # bad: [06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5] Linux 6.5-rc1 git bisect bad 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 # good: [6995e2de6891c724bfeb2db33d7b87775f913ad1] Linux 6.4 git bisect good 6995e2de6891c724bfeb2db33d7b87775f913ad1 # bad: [1b722407a13b7f8658d2e26917791f32805980a2] Merge tag 'drm-next-2023-= 06-29' of git://anongit.freedesktop.org/drm/drm git bisect bad 1b722407a13b7f8658d2e26917791f32805980a2 # bad: [3a8a670eeeaa40d87bd38a587438952741980c18] Merge tag 'net-next-6.5' = of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next git bisect bad 3a8a670eeeaa40d87bd38a587438952741980c18 # bad: [6e17c6de3ddf3073741d9c91a796ee696914d8a0] Merge tag 'mm-stable-2023= -06-24-19-15' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm git bisect bad 6e17c6de3ddf3073741d9c91a796ee696914d8a0 # good: [2605e80d3438c77190f55b821c6575048c68268e] Merge tag 'arm64-upstrea= m' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux git bisect good 2605e80d3438c77190f55b821c6575048c68268e # good: [72dc6db7e3b692f46f3386b8dd5101d3f431adef] Merge tag 'wq-for-6.5-cl= eanup-ordered' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq git bisect good 72dc6db7e3b692f46f3386b8dd5101d3f431adef # bad: [179d3e4f3bfa5947821c1b1bc6aa49a4797b7f21] mm/madvise: clean up forc= e_shm_swapin_readahead() git bisect bad 179d3e4f3bfa5947821c1b1bc6aa49a4797b7f21 # good: [523716770e63e229dbb6307d663f03d990dfefc5] maple_tree: rework mtree= _alloc_{range,rrange}() git bisect good 523716770e63e229dbb6307d663f03d990dfefc5 # good: [b764253c18821da31c49a260f92f5d093cf1637e] selftests/mm: fix "warni= ng: expression which evaluates to zero..." in mlock2-tests.c git bisect good b764253c18821da31c49a260f92f5d093cf1637e # good: [5c7f3bf04a6cf266567fdea1ae4987875e92619f] s390: allow pte_offset_m= ap_lock() to fail git bisect good 5c7f3bf04a6cf266567fdea1ae4987875e92619f # good: [0d940a9b270b9220dcff74d8e9123c9788365751] mm/pgtable: allow pte_of= fset_map[_lock]() to fail git bisect good 0d940a9b270b9220dcff74d8e9123c9788365751 # bad: [0d1c81edc61e553ed7a5db18fb8074c8b78e1538] mm/vmalloc: vmalloc_to_pa= ge() use pte_offset_kernel() git bisect bad 0d1c81edc61e553ed7a5db18fb8074c8b78e1538 # good: [2798bbe75b9c2752b46d292e5c2a49f49da36418] mm/page_vma_mapped: pte_= offset_map_nolock() not pte_lockptr() git bisect good 2798bbe75b9c2752b46d292e5c2a49f49da36418 # good: [be872f83bf571f4f9a0ac25e2c9c36e905a36619] mm/pagewalk: walk_pte_ra= nge() allow for pte_offset_map() git bisect good be872f83bf571f4f9a0ac25e2c9c36e905a36619 # good: [e5ad581c7f1c32d309ae4e895eea0cd1a3d9f363] mm/vmwgfx: simplify pmd = & pud mapping dirty helpers git bisect good e5ad581c7f1c32d309ae4e895eea0cd1a3d9f363 # first bad commit: [0d1c81edc61e553ed7a5db18fb8074c8b78e1538] mm/vmalloc: = vmalloc_to_page() use pte_offset_kernel() --6EsuOK1fDi4bcNLc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSsGNYACgkQJNaLcl1U h9A3dwf9HcI/brPRam8JmuslRrwSUKfGz416vFe73WUvxrAmgk+wclCndU4Ntgl1 xZsSpEVcJkI9LpnPudX/letTj9LdMxBcIDGw1OIXYjGFysv+4Rnwqnt9aKM06nQG m4B3XlTNG0L0q6p125iuz4lGJRU2Jum/VRGdtM1hgg+jBa96wxFdP1T+JZgPRRq5 7b66rlzClMJmzPiXx6mNaol0jhu7ex1ltrn0Rfsq47zpgobIrG6Q0pKOlcIT5yT6 1IP+GoOVaR1DkATN7G35PF4vHSl56xd4lCyG0+KZJvWtQOWQNJYIAdgWwu4/GQfJ /5y10aucaSA7vu2WeTafTU9wYj+YxA== =cEJt -----END PGP SIGNATURE----- --6EsuOK1fDi4bcNLc--