From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F763D1039A for ; Mon, 28 Oct 2024 13:15:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE16E6B0083; Mon, 28 Oct 2024 09:15:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6B396B0085; Mon, 28 Oct 2024 09:15:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD2B6B0088; Mon, 28 Oct 2024 09:15:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9DF166B0083 for ; Mon, 28 Oct 2024 09:15:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1C9381402B6 for ; Mon, 28 Oct 2024 13:15:01 +0000 (UTC) X-FDA: 82723056150.29.16EDA86 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9EAFB140018 for ; Mon, 28 Oct 2024 13:14:43 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MT7opIAN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730121125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pkD6WUzWY9R99N6ZCpJZMN8fi24XluaCrxUNYCAf5fU=; b=5uep2qyM2qhsIrMu4QJ3bDKbaK7s/jmN5dM/6jOOFV6KoVN2yPIX2X3xTuYUnRam4N6cZY ytgZeCdFdPmWhM0JD6QpNH6ufXxSRIJAaBgLJ+BQH6t8KEprqHlsH7kbCehDB6UwZlKP7Z NeFTsH2iKohfsuJavp7KTYmwcLJKvlQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730121125; a=rsa-sha256; cv=none; b=3SaQ4IAzXKGq3QCEKJjYfcnA2kab7EhTw3j9H3U58BpfibA1q1Hzrlpw6ZdP7wNT2qedyX PUW9JJcdxEZjmzIsl6TTppZexF7fo/EZwHz0lBVPwaPXvSQ8MbaYHvDwm3Rm20ZZg3OKGL G9y6ebC2YJN7cYPboEg3RXsyCVLj2tQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MT7opIAN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730121298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pkD6WUzWY9R99N6ZCpJZMN8fi24XluaCrxUNYCAf5fU=; b=MT7opIANa04a2Vbgq3MbgznwIidGAJ6zhLPntlVnx0vBV/T/v22XIieZy5bAYFGCniftR6 6xbYIt64l2VhKawbrHodrnPm04SCEHzAJPLn0Qyw0au6jyuCjDhdYnnorSmmL9CWmiAAmN 8QhP+qI5F4WCLoV1lS/ncBmopihrj2U= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-U3LlG5gENpCS4wNmMjT2_A-1; Mon, 28 Oct 2024 09:14:56 -0400 X-MC-Unique: U3LlG5gENpCS4wNmMjT2_A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-53b1eef7359so3411472e87.3 for ; Mon, 28 Oct 2024 06:14:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730121295; x=1730726095; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pkD6WUzWY9R99N6ZCpJZMN8fi24XluaCrxUNYCAf5fU=; b=wazA0+gknYQJPeczE6b3sjQcb8kHCEaLFfW3cjMSYELp0cCZlPwOjimXJHDwRukB38 DPjKP5an2O49jQE6KFOclB1lrP/LXKrHvP2Bkh5ZAyynU8XPtDZ0w0iZtx2zFoZKfJSW o4Vc3s1iMMObRfJR76IUblUGzj64eQCH3DQ7X2MK1O1gNNRw3UJdd3P+EeqMhw56Ht1C fYscENr8sxFeWes/CprupkGVBeoy3Xc1AdJe5HvRUR1kChmcmGXDwrbIldJqEmZpe5Vp Y8RIO94TL98ZSQ+ViuVT5FGgadksqpLkBM81FtR597eoU/Qzyne26U1Orj/HO5V7gcSR qNkQ== X-Forwarded-Encrypted: i=1; AJvYcCUDXXf5tHgEb6MlC//QlkrxZxReTybIbp2NL8fEVEooljJXgmYXAqr1QhSyigP7C8D1E7C1xtP87A==@kvack.org X-Gm-Message-State: AOJu0YzeZU7nDDSijNcctsCS/PDhe3pXmUypzaqmwMNe7v0TIyVIvRnl t/qYmKyTYld8XAXk/Xw9ap2a9Hrid+sUX4rXgsKLeSbKokHpdJPJLQPoeutedES2QFvBsJTLRTp BSTp0L3q5NX4YE220bKiVQmG1n9nYhTxsCFBtDL65b23oqsja X-Received: by 2002:a05:6512:3d26:b0:539:f4a6:ef4b with SMTP id 2adb3069b0e04-53b34c8db59mr3513454e87.55.1730121295289; Mon, 28 Oct 2024 06:14:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTL30tDAIjWKbyYmjzjRc/Ob4NFfRII1EZztcexTu5/pRW0oR0/GME5i2SMu0e2xY/0UoM9A== X-Received: by 2002:a05:6512:3d26:b0:539:f4a6:ef4b with SMTP id 2adb3069b0e04-53b34c8db59mr3513430e87.55.1730121294820; Mon, 28 Oct 2024 06:14:54 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431935f744esm109769795e9.34.2024.10.28.06.14.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 06:14:54 -0700 (PDT) Message-ID: <4219a788-52ad-4d80-82e6-35a64c980d50@redhat.com> Date: Mon, 28 Oct 2024 14:14:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() To: Kefeng Wang , Andrew Morton Cc: Matthew Wilcox , Muchun Song , "Huang, Ying" , linux-mm@kvack.org References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> <54f5f3ee-8442-4c49-ab4e-c46e8db73576@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <54f5f3ee-8442-4c49-ab4e-c46e8db73576@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9EAFB140018 X-Stat-Signature: 7ggjj71gxrqrzyqwf67ie1aqcc41stj4 X-Rspam-User: X-HE-Tag: 1730121283-563705 X-HE-Meta: U2FsdGVkX18KQM8MFfUO77silxPDAxptbSDFYClQcs+LG5ITX15uA3iSEvAbBWH+JQUFfxOnP69mBQzhI4dJjq5UboHu8M0KISUgFLbSBEjjJcGT1wICwskgXHTTE69SRtTJtTlvgshBYwKYXnRJraH1LMJONrOkj1GNobv9O5vtGu6gyUM+L3QdVNCZfJWU/wlAjnilWfcxIwHIEXQaDCwS44ZghkvdtGSgCG6pJ+LDrxtsBowxpcbwUf7cEPNBBlc6pvX6iJMeEg2RehkElYpCMzmdL3QQxodQuTy71YMckzPj0Mw/y333SSJtEbTfWkanX8DyZbghZZTIQX5QsBlV/igen3+ZEcduEX/BkebTHEAD4jUvVKxIaQMka5xzPmU9RxlvQdO7qbRD/I+u2CWCFWGsCIumOFMYN4nSA2BIJkZeuT+UkJPmchxySV6aoqZOB1UzxAU4yHhFv4/rmDcLLa6bYF6r4EE2Yi3P805pHOBqgOezKez/z1ExyKqfS3MAa003sTAvJO95/3lmV9B41qlnKb/Q9Hn73VChEwOtVk8/bcKebwfuckEjsgJV0uZ8bTX6GkFMlNH1PndrVg9rFtyqLnvu7uOeEDKDNNA90GleRK6bbXIGTBarlkO1OFwRu1GcxweO9SVAj+6pH3asA3gSO89keVTM9kk3n6BIgPShKLIMR6OWzmqND36zZY4Z8D6ZfRhvjTkH2x3WIaQH5iXZFnst4qvqhPmMge/vlew3a6uTr/AZbOxzWJV2LWjOW4HL0MOMLn+Ek+ac5IrXkVFXZA+Zb9Dsauy/yDaNAjPPe54dRuRof5CJK0kg/Wb6Z/ZtnvJt/SzzlUFsDMamvDXhrwvWTA2HSv/vETR1Afdnu2jYtyuiRFXAZ0yMCTcnCpzI4gpBPnhyY7kJR99vKKIjyd4/kBaOpg2c63TqvVMS2PT2VzTkGUW5k9spTD+xOwq9X2dYjf/jCRz m5DtUzbj nVy3JfEocakKfHrqOS+Ls308vNBuBLEOrOmHuyrcSSHg+cMAA8l9z/cgSu0Jz84XH4hcCtnCmS7EbEV9MyiRbFDJDXIJDM/PobzwbxdAXTcYpw1DGwMLTpWOb5WyWfblw8PFH20g2l+wkdzVbaBD+D/NTcWJkoFhL04P7R8CL/dhJnLutPjvwzLCMn8QF1WghsVJbUXEkFkQFp7DPqsiP6MdD/SRbjskUEyGnA1yfz1IhtXntAK2pcwpkY8/CmH+mVfwVho354gVgYC8q3G1FGD/JgwCSkwaPYK18tIv3aQ4EHfcyn+aW6lwSpaPyt7VvawvS4Chfgjo1qo+KLBrfVJ0aLQRrelxL6nctm9edg3dgsQwtTCWTbg2ob5uU84uXbCWHvu3+n+o1LUzZVD1Cam+4vuyC5XfPb/DfQ40RtdUI3Qy2dxEMcLNADzqzeC459GyfM17e1KXZKfLEz/PImeSrDSJcFzbLrnz6NCg0A9zCsUmevpj/4AC1uTpaPwRZLxniRpvMO3/n0q/oa7dc/PQXY/SPfdWG8Npzp1QcFDbQzic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.10.24 13:52, Kefeng Wang wrote: > > > On 2024/10/28 18:00, David Hildenbrand wrote: >> On 26.10.24 07:43, Kefeng Wang wrote: >>> When clearing gigantic page, it zeros page from the first page to the >>> last page, if directly passing addr_hint which maybe not the address >>> of the first page of folio, then some archs could flush the wrong cache >>> if it does use the addr_hint as a hint. For non-gigantic page, it >>> calculates the base address inside, even passed the wrong addr_hint, it >>> only has performance impact as the process_huge_page() wants to process >>> target page last to keep its cache lines hot), no functional impact. >>> >>> Let's pass the real accessed address to folio_zero_user() and use the >>> aligned address in clear_gigantic_page() to fix it. >>> >>> Fixes: 78fefd04c123 ("mm: memory: convert clear_huge_page() to >>> folio_zero_user()") >>> Signed-off-by: Kefeng Wang >>> --- >>> v2: >>> - update changelog to clarify the impact, per Andrew >>> >>>   fs/hugetlbfs/inode.c | 2 +- >>>   mm/memory.c          | 1 + >>>   2 files changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >>> index a4441fb77f7c..a5ea006f403e 100644 >>> --- a/fs/hugetlbfs/inode.c >>> +++ b/fs/hugetlbfs/inode.c >>> @@ -825,7 +825,7 @@ static long hugetlbfs_fallocate(struct file *file, >>> int mode, loff_t offset, >>>               error = PTR_ERR(folio); >>>               goto out; >>>           } >>> -        folio_zero_user(folio, ALIGN_DOWN(addr, hpage_size)); >>> +        folio_zero_user(folio, addr); >>>           __folio_mark_uptodate(folio); >>>           error = hugetlb_add_to_page_cache(folio, mapping, index); >>>           if (unlikely(error)) { >>> diff --git a/mm/memory.c b/mm/memory.c >>> index 75c2dfd04f72..ef47b7ea5ddd 100644 >>> --- a/mm/memory.c >>> +++ b/mm/memory.c >>> @@ -6821,6 +6821,7 @@ static void clear_gigantic_page(struct folio >>> *folio, unsigned long addr, >>>       int i; >>>       might_sleep(); >>> +    addr = ALIGN_DOWN(addr, folio_size(folio)); >> >> Right, that's what's effectively done in a very bad way in >> process_huge_page() >> >> unsigned long addr = addr_hint & >>              ~(((unsigned long)nr_pages << PAGE_SHIFT) - 1); >> >> >> That should all be cleaned up ... process_huge_page() likely shouldn't > > Yes, let's fix the bug firstly, > >> be even consuming "nr_pages". > > No sure about this part, it uses nr_pages as the end and calculate the > 'base'. It should be using folio_nr_pages(). -- Cheers, David / dhildenb