From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 648F1C7115B for ; Mon, 23 Jun 2025 19:45:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 842226B00C3; Mon, 23 Jun 2025 15:45:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F16F6B00C5; Mon, 23 Jun 2025 15:45:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BA2E6B00C6; Mon, 23 Jun 2025 15:45:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 556586B00C3 for ; Mon, 23 Jun 2025 15:45:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B66ED104157 for ; Mon, 23 Jun 2025 19:45:41 +0000 (UTC) X-FDA: 83587695282.17.5338698 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 50BC22000B for ; Mon, 23 Jun 2025 19:45:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L4EicfJt; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750707939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KfAsWxspOqODSDmpvWTvJK7exlbhCAdt9xq1Z3xeH4k=; b=1IUPSsXRksRI6/JiNg3l1CZF2RXP7AxQdWPbxYzT4Dd1qQB1Vvn4JiDogRgGnrl4lM2WCz /ZkNVXgRF0aJmy8qfyJ2ZMgRi2dqUFMFFcIY78ddS06YYdmG+VSOZQPwY/y1LhoxhXhYJ7 zyo++obyuSNnOcwaiBur7FMGIAy57dQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L4EicfJt; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750707939; a=rsa-sha256; cv=none; b=VWXZTtPX16pFauG/wD9RrhHHy8qk/VgVUUBN/xvG8O9QqHmWcjUCEDWpglFPGRIeBg6Pgc Ae5uc9MImzTbvD4Eqmq1XUuxs2D79MEinkBTm/6QbHkXkMZzLBvn6ueVWUEd284SalyQaX rApH3Lu5OvdZaq6OiPqSYjmXeqJXotY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750707938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KfAsWxspOqODSDmpvWTvJK7exlbhCAdt9xq1Z3xeH4k=; b=L4EicfJtOkXa5Tx4LS07ynjN6Xj3c4wmATfHYDZiyl5p8a1IRtIzPY5OlIKeyHXEvG7dBe 2ww5YxrWThTwtgNwF0n5rUVVB2JQS03hyPV/KZevDDhG6PzjgNsRxcYRbSlloIvfVV64L8 VOSaxes/s0aFpxWNaEtKO0dLBy9q8Lk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-6-oqvMe5Nja4_XQ7R51vgw-1; Mon, 23 Jun 2025 15:45:37 -0400 X-MC-Unique: 6-oqvMe5Nja4_XQ7R51vgw-1 X-Mimecast-MFC-AGG-ID: 6-oqvMe5Nja4_XQ7R51vgw_1750707936 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43e9b0fd00cso25246485e9.0 for ; Mon, 23 Jun 2025 12:45:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750707936; x=1751312736; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KfAsWxspOqODSDmpvWTvJK7exlbhCAdt9xq1Z3xeH4k=; b=gHIvtdwXSX7JogyWtooQbCZJ5umh53STZereGdMtf6D1K0+gPbSCGcrRwkKuMnup0b 5OFQakL/uQmVJvQemZzG/tb24nS6zbk+18/HefhPLqFy3UlmqgM4/19u65QfdbCNBheD TauGHW0Gtr1BBiiHI/cqbK2ecNabKZp28uovhceNbvEhI8eJvb6kWfKC52/cmH94R+SA wpxA2xEYEhMQ5B82naM+1TjGs4VA9tDMlZxPNFRiggrIoWLu9P8kB/xo3fBQt33QxHC0 xxNWPB+6/5YGB7eBIWt+O7EBJYKEkNIXqM09bK2xInoyDJhsFetu9j2k5Q2RziNQmrUY qqPQ== X-Forwarded-Encrypted: i=1; AJvYcCVaBaLBS0UUK/BqHhKMHlW8dkok2dkuXL9yGCAQJ8KlyT+xrztRILz48GG6quutoVd2ixoNUgjzdA==@kvack.org X-Gm-Message-State: AOJu0YzSwhNc6nIxgypVZEhrZdj9qvYeFDwguj36o0lJdeMyJNB/0fBQ DKDcPkh2VObTsKgOPHTZI4VATFq+XqB78UpgJba3uTOYdHXsdosS10CwGM29MOO07xk23TtYFaX Mpy8WsgTXPFyzJae91pRP5uov9HqQYpJF5U5XvGYd9DQLBZOiiIxr16HlBiz573Q= X-Gm-Gg: ASbGncujIc4w3Y6mLpqEDIRLvojZ+nMSH5fhO/0hsZC0mUNl3bmAJwGPJQHdPATZskJ JO9ngxXUds1/+kkm4oeaISP9TzBwBQ9ZPUlj13f9APv9i1J8HjMEHM26OJvIk+gfRbUYJ7ibWC+ m9MheFF0gDmlJ+TMiA4iqeK1fzrIgS0gNLsOpXtkOQccbitGTjd90b1/OsBS21w4oLXTrffCKki jc/cPhBNf1sZGfAytwZQT/qPkuWH1ZkNZ2GJzL3f//ilvWvd6oU3ivU1pwSd04erNilX1zQ5LOD +dsjIHI7dXpUKysUps0LteRPrpdaeCh/nSTSBB10p3jXGfGCH6tJdglAwOKPQjsfzNaSfs67rUb yswXX0CUu+g/is74T+HkgQ/2mooZmYvezKgMsZpl+g8kFL2KrXw== X-Received: by 2002:a05:600c:4706:b0:450:d79d:3b16 with SMTP id 5b1f17b1804b1-4537b79c3d0mr8421015e9.14.1750707936087; Mon, 23 Jun 2025 12:45:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGa279cniyU/ZXkqcvRtAk+4PjbOtzhupyr79W8J3nxetE/ZDNt5zv/yV18Bn2LF1GBHjcsFw== X-Received: by 2002:a05:600c:4706:b0:450:d79d:3b16 with SMTP id 5b1f17b1804b1-4537b79c3d0mr8420885e9.14.1750707935749; Mon, 23 Jun 2025 12:45:35 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535eac8e19sm153019115e9.21.2025.06.23.12.45.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 12:45:35 -0700 (PDT) Message-ID: <4214d6d6-f8d5-43b3-a413-f576fdaf215d@redhat.com> Date: Mon, 23 Jun 2025 21:45:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: move mask update out of the atomic context To: Dev Jain , Alexander Gordeev Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250623080440.3005693-1-agordeev@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: L-ItG5ixq7hzosiBoRA_t174Qi_o_j7U3KKMnbIC2-E_1750707936 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 50BC22000B X-Stat-Signature: i74c11s8qhopfryqdbrpct9u5qyr4jot X-Rspam-User: X-HE-Tag: 1750707939-96628 X-HE-Meta: U2FsdGVkX1/hk+ivaE1JDuy5luCoax2mZQRaoiECW/oOUL5zMiAs73lNRJy5owjoqRzsCkrgnazP+KXpkDsxSKlfrJOStEsa1yr55bmYmGXaAfycpLD+HaH3zkavbutY+b4o9ZDJ1NQWvbR4PlZvWn+Lx0peZ4Fb59ng38D64hlh6ixd7qgRmM82ScWVUAIoyfIPUsXnh5cwo/0KGaZqxZCBzHO90UlYw775BaKEewiBsrXOZnAFFa6QzeKKyLqhpsuOAJuziiidIsaMQcvU6odZ5T+l8XzxGnHJ1vPxUm9kemFWM9QeTg/U3tCv5qAB/RvDVVs7b/oTkCsOpBcSpgnC8hYA+Ut0pAusSc4VPq+ULW9UOL36LVdfd80t5kw1yINIyH/Oqpn8ZaO5SSVlqiRn1C8GrRFqmxYyBr/6gyk/D/vfanz/l573hNVUyeGzwsmCLQFnKKC3Ws3t0+LGHiC/PyemBsEojIJDftYFY/2jsJwWR3w/0YTfOvSL8EPyvip6xE5vdGAWYeVsGNmnfY1lyAUV1ICBYT0sLvkdEkND4j/oHwbJ7cBqpk+u5PO59VL+nNE7RE/NgdUWRIWdLnSKx6BeqzFqYIGlcJEoHV783WGLu55nmMPbcU6mj/6rSp+IeLH6ZA8dPQc3rAFAw5Ui5uAoqxwcitsICdtCjyFdxeIEEMwEsx7mdGrj630Te+SjNCMByC2AfaiV1b/A3IsPaTX+KgtIWBckObgrbUKlmKhQP5mnFRqhCe5zDniyCW9ga750Ks8yzSmtFDy2+ntPDHFyh1ydVVcQXJqsVrOMsn5gmz7ONQeV+XLMh08kfhUWYYbXcjlnYIHWmlnIeNxv/kGOV9AKgU3nJC2zkhDSbM8O24/6MwjKjj6AYysHe05J/LEj8FQGU2STq6Yz3R+prJi+1gRTTcFs1oUd+DlrVARpClIg5ulgKcv/gvRRHcB/DOly8NeFBxDM6ih F8OERAfD FKUZQQKONRDSK9q0TY1BoP+xTulpT9EOiu+c7OqeWBdrqzD3VB5OjYVYLhzYyzI2udhDHGZsd2O1ahW5QU8i8GecIkTBuw19kOtus2dTUh8Rky/oB57E/48mVr7gzs0PQYztX/l+dsQ3H02nfpad7tzIrsGtpAz8tOm+lu4b2X/dHupbcrFHsD2PIKAIG0bxRZbRw69D5ZaViBuzgQMeFqdlcO5Q7LOP7AXVm9TD8vi+ktIRS2W3lUUh4xlxmHQZjASJmDPhSlfccpJtuZPpjBwiGT/sYCVmzN0KGcvKrJKh8AOigtuCPN15TYv7onh8rQlLaXZvUB2YY+STvLhSamekpk9z0IZTqWxC+tUgjbSnPbI/GwN2IkYrAericGz2qiNWqbPWTIWu+N5OpsjgzUQv/hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.06.25 12:09, Dev Jain wrote: > > On 23/06/25 3:07 pm, Alexander Gordeev wrote: >> On Mon, Jun 23, 2025 at 02:26:29PM +0530, Dev Jain wrote: >>> On 23/06/25 1:34 pm, Alexander Gordeev wrote: >>>> There is not need to modify page table synchronization mask >>>> while apply_to_pte_range() holds user page tables spinlock. >>> I don't get you, what is the problem with the current code? >>> Are you just concerned about the duration of holding the >>> lock? >> Yes. > > Doesn't really matter but still a correct change: Let's ask the real questions: who checks PGTBL_PTE_MODIFIED? I see if (mask & ARCH_PAGE_TABLE_SYNC_MASK) arch_sync_kernel_mappings(start, start + size); And then arch/arm/include/asm/page.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED arch/x86/include/asm/pgtable-2level_types.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED arch/x86/include/asm/pgtable-3level_types.h:#define ARCH_PAGE_TABLE_SYNC_MASK PGTBL_PMD_MODIFIED Which makes me wonder why we need PGTBL_PTE_MODIFIED at all? Is there some other check I am missing? (same question regarding everything excepy PGTBL_PMD_MODIFIED, because that actually seems to be used) -- Cheers, David / dhildenb