From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADE9E7717F for ; Thu, 12 Dec 2024 08:51:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B962E6B0092; Thu, 12 Dec 2024 03:51:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B45F86B0093; Thu, 12 Dec 2024 03:51:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C0976B0095; Thu, 12 Dec 2024 03:51:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7BF596B0092 for ; Thu, 12 Dec 2024 03:51:04 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F1EF5440A3 for ; Thu, 12 Dec 2024 08:51:03 +0000 (UTC) X-FDA: 82885686996.29.85DCA4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 19BAE40002 for ; Thu, 12 Dec 2024 08:50:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gBe1o4UN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733993439; a=rsa-sha256; cv=none; b=3kZMqp21nQsdCfEGQGp9GxkIQmK5dHIVBpbxVW6odoB/729MSoDVcw+zHc7VerA2NJgG9j 6s2PqaPTLZofYGw2tk1RBpgnSoR8GfYPaZx7PkzfW8NeGfFd2Kw3T7SuGVPmwvl0aSMhWy d+UiG396EH6GwGOFkymAB0atjH6Ksjg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gBe1o4UN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733993439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=45krJy8uObwsQU9TCDvjj/UpRIlgKYFPEUKTfB/ZnWA=; b=Qf0vX58/RoZMKhQohGsOFbbOb9/GYlJsHUyQh96LKkgXdiQCOXraXljYKMKIP+N4Br4WaU 0lru+l1U/A5Ppgxxn6PjQjffB9iiCCmnWv02iSzXCU84jlH46NpvvyWOo9wy/ZR1SzI/+i KkiqQWGmCqkkZQ/DWxYO3w9FNgfaSjw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733993460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=45krJy8uObwsQU9TCDvjj/UpRIlgKYFPEUKTfB/ZnWA=; b=gBe1o4UNNthkF97qtAFLL7ur3cLcUz6K3qgOOqssF6uS/dhg0rGAtasSRJxTZEPAItn4Ew la69NlzTIDRCs3f5SRyCNydLqbm1sy3wlGUIYZuuIYqRf+11BgrPL4qbMu1X4iDZlwpyJ4 kgeXFWArMeZfkFFGqYx9hXVGU0qsLJ0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-f0n6QWQnP5a-xlF3qSIAxQ-1; Thu, 12 Dec 2024 03:50:57 -0500 X-MC-Unique: f0n6QWQnP5a-xlF3qSIAxQ-1 X-Mimecast-MFC-AGG-ID: f0n6QWQnP5a-xlF3qSIAxQ Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3862b364578so784876f8f.1 for ; Thu, 12 Dec 2024 00:50:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733993456; x=1734598256; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=45krJy8uObwsQU9TCDvjj/UpRIlgKYFPEUKTfB/ZnWA=; b=n9ohFKTftzcML93NVOTgSYIdUtwWSQjB5nRxcuTYjrL8WmNg1xvBsZ3pHskn/gm8ww OoL4TdLnglpSpKgKVCZLGdZg3ZDald+q8xgKKDXLchGL/KpYm+/MXkdw1LcJdzXzzBWQ icxFVRWsjuGokPeDitYJ/Ya5gOrdrub4AzdRi9s0l9pvsx5icxW7tSdh0w6gNtdoV4jJ hOqwnZeP3z5mDDLbHijWMJAM4mP2apzM87f7Gr1IASvBWJQpqwx2AvCvl97qWq1f6OLV QQU0C9yOhn3ULLBrQqX/K4TJaXMtYoPO1HBeNCWDyk9RlKPEXcxv85xaH0nz47Iu1IsA yo7w== X-Forwarded-Encrypted: i=1; AJvYcCUa7+KfEWCpmCpA6gSM46CFvFiH6P+kkc9d3cuKkiYINxqMNde7FpFP5uKTGocH7ts8H6ilbLFsiw==@kvack.org X-Gm-Message-State: AOJu0YyIVqVNhnJl+lLbj4i4iDzScGY1XmjsBButhr5EyrhbCya5Rm1P HsKcsFbLhorZ90JtCS5kMyWygLBhvTMJbFaTQTy6NfOE0geZJZ9dHFMJqmMc+SrppcqfJZwqVAk Zn3DQgTgjtk3z0a1ArXpVk4NVaONNA6eXXzFya4X2PQrmA4BZ X-Gm-Gg: ASbGncu2X5fpLEKxsXOlxaVhiok5oXm8OPnEJC1uq90PEfpks9mwTcG38mfjCYCzxCy ZXT3BmRQfrXlsG4nhxUmmLtobuUA9gkiOrFgZRhZFoGQKEm/8mHhbB9GsWIV24YUX4WjwrNTfy+ XueJaCPY6EESOQKJKNX63/Ql+n/bXOMBaEg15SBgbp4w6f+r4z4xJb4nMPWXZowGTMb6fDqA7rg 8lhMXrMasrRHtGAjCcndfHxrao2NEERDHExC5qnRDfh9Xxyyini9Yo5S/dfANKf22iRm6n6Mrij cOYMsUPA5vMxinONjApDbD0//BWEmSGFDs9aUHHNa7Q4tqY+QqstTMReHYYpVqP/jXQq8fosoiX uz/MX1A2v X-Received: by 2002:a5d:6d08:0:b0:386:3d33:a61a with SMTP id ffacd0b85a97d-38788869cfdmr1569679f8f.27.1733993456387; Thu, 12 Dec 2024 00:50:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaz7z4OQnBxkY6/Do2V3tt1M7XMUWvNpeRJYhgZOfZWg9K/PlMbYYgnYR7IMmvX8m4vF3l4w== X-Received: by 2002:a5d:6d08:0:b0:386:3d33:a61a with SMTP id ffacd0b85a97d-38788869cfdmr1569659f8f.27.1733993456055; Thu, 12 Dec 2024 00:50:56 -0800 (PST) Received: from ?IPV6:2003:cb:c716:2b00:720b:42a1:ba95:a3db? (p200300cbc7162b00720b42a1ba95a3db.dip0.t-ipconnect.de. [2003:cb:c716:2b00:720b:42a1:ba95:a3db]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38782514ea0sm3426702f8f.82.2024.12.12.00.50.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 00:50:55 -0800 (PST) Message-ID: <41e33113-1ac4-48fa-8eac-0f90ba5bc864@redhat.com> Date: Thu, 12 Dec 2024 09:50:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] mm: map zero-filled pages to zero_pfn while doing swap-in To: Barry Song <21cnbao@gmail.com>, Christoph Hellwig Cc: akpm@linux-foundation.org, linux-mm@kvack.org, axboe@kernel.dk, bala.seshasayee@linux.intel.com, chrisl@kernel.org, hannes@cmpxchg.org, kanchana.p.sridhar@intel.com, kasong@tencent.com, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, terrelln@fb.com, usamaarif642@gmail.com, v-songbaohua@oppo.com, wajdi.k.feghali@intel.com, willy@infradead.org, ying.huang@linux.alibaba.com, yosryahmed@google.com, baolin.wang@linux.alibaba.com References: <20241212073711.82300-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: st455DjIfoapY6u9nwlm5w0ro4qvKpOW_7l0KJ5kYQQ_1733993456 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: bpjn8n5dhihebp5qetpe6zmr6qts1xgf X-Rspam-User: X-Rspamd-Queue-Id: 19BAE40002 X-Rspamd-Server: rspam08 X-HE-Tag: 1733993433-273499 X-HE-Meta: U2FsdGVkX1/JrW/59iRPz+NAM9bv0z2CH3kXM3K74hLSSWa/vVW91++1BxcBp8LYlvD7aVBZe4jzAAevfEAbYu66+qi8dH3QWDfSaInjJhRXsrCUSW00C1umdVsJln+CuRR49mApqWVcyivYzLsz3SLltVSP9/XMBK3QfYzag/VqFUFi/Sn9Mi2jrcPCjwAw9iv0HUAcBZVzT6E1a/pQgDYp6sJAoV5sZHZ+8CpaySH/D8tV+csQseMtWGfYef/DfuE+FBHg4QAvDczXek8JI3MqMi6vyhONatJnpFHj3vvNY8FHEmejnh9P0KlzGLJfmyiSN3feHFCdw1ZybU6mbYGLlt/oacU1LFqq2MyzKjVCncWhC4B9bzTQeShaM2B+6ZwVG8edlO6Qn3MflSHw5X3hfetpxowbocx5PajAXb9lNYOZL98VW5nK6Psy8M7FCP3CWZvk13rgWVPPgvIFh0Au8I74JJeyU7UPng81B0QX+QpDiXemxIz1ARuERqOA3wIIkenXQA7qikRb2xqxp6YbZSVAkvkWP4249+G1AYIBaG4TU1vin6BNyRDKJxeQMXDwqRpplyj9JZTDjgAD0MTl6dRw4qhIvMPIaHUQIjq6AUOxXUXWc8qy9aB2tndb8XdMEUBPAyqYPI0SSwr+pEsn4zEcJyH84+uoyrlK3rxhyhZWYr1Wnih2UaCF5CoPO2dtayH84peUtTFoGkaftBFW+10GbiBZktGbjKyORO39hOlC2uT/K3SyVXk5W2dTw/4zKj5wbROl5pJh4TYcXxO+L1Svym0Q8ZPlKcCBHbKDmcjHOL4GhZ+609RD5tt/dbzpBtyHq0QrSKkfLgECttJRvQeYYRdCKEOV1HGSbW5U0DtI4hLE+O+2CLctj1S8FSetTKwDRdN2aUvZILY2hFWiRqmaSIgktkLsES7dyzKYn3mn4tPdRAqk81RZcdsyjz8mwZAcBq++DC+pXiJ T6/VlxPc JJy+kY7RCSrAfa3V7jVjPwbzMJo3gZcc8LVKZBBjvHCHIg6rB/Sk2NM5POCboTy6cSp+JNmfwg0A5n6yiUL4ESQQKXcs0OnE0H5f5Ib1gcJBPwt+4ISJYgoFul1z14HcceLaWwA0N5KePGR2ariyO4JFFsumrQyKpKYd3/qp+4ANp6X1yONpw1q1JXnVsE/PJnmaRWOUQAsDobtMuEYursDv08CqA/M0zqsf10QXrOE5vX9RxxqwDCjDV/W/XL5GDnn3UVJ4M5LN0xkEbYq/lH10uxjLW9qjf6TWOcppI/Qa9cZceKcq71H6mb5f6phgxGD75smS6tLZfk/K5QOP4siGFm+RZmkJehYo1xrhNjy0vXk+hm8F2sn4JaCPLLkwn0zwYDj+Vy0F1+vAHGJ+nswesVdLjLcWY7k7V46SFeMLzW6J2DMVIfwGp1mr13UfAvS7TFYrey5IyAFTHkBVJaR0j7anPmIwLqDnmQP38bguC9p0+25ycl+2Dk3Ax5sQrTC3JgNQMXesIy4M3QnapTmztI1zXGk7rfK68KYg9xnYTSRQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.12.24 09:46, Barry Song wrote: > On Thu, Dec 12, 2024 at 9:29 PM Christoph Hellwig wrote: >> >> On Thu, Dec 12, 2024 at 08:37:11PM +1300, Barry Song wrote: >>> From: Barry Song >>> >>> While developing the zeromap series, Usama observed that certain >>> workloads may contain over 10% zero-filled pages. This may present >>> an opportunity to save memory by mapping zero-filled pages to zero_pfn >>> in do_swap_page(). If a write occurs later, do_wp_page() can >>> allocate a new page using the Copy-on-Write mechanism. >> >> Shouldn't this be done during, or rather instead of swap out instead? >> Swapping all zero pages out just to optimize the in-memory >> representation on seems rather backwards. > > I’m having trouble understanding your point—it seems like you might > not have fully read the code. :-) > > The situation is as follows: for a zero-filled page, we are currently > allocating a new > page unconditionally. By mapping this zero-filled page to zero_pfn, we could > save the memory used by this page. > > We don't need to allocate the memory until the page is written(which may never > happen). I think what Christoph means is that you would determine that at PTE unmap time, and directly place the zero page in there. So there would be no need to have the page fault at all. I suspect at PTE unmap time might be problematic, because we might still have other (i.e., GUP) references modifying that page, and we can only rely on the page content being stable after we flushed the TLB as well. (I recall some deferred flushing optimizations) -- Cheers, David / dhildenb