From: Dev Jain <dev.jain@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com,
lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de,
vbabka@suse.cz, jannh@google.com, pulehui@huawei.com,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
aishwarya.tcv@arm.com, ryan.roberts@arm.com
Subject: Re: [PATCH] selftests/mm: Add CONFIG_FTRACE to config
Date: Wed, 11 Jun 2025 18:20:13 +0530 [thread overview]
Message-ID: <41daafbe-50c0-4707-8004-55826dd3003f@arm.com> (raw)
In-Reply-To: <8e0925e3-70ae-4b00-9f70-3a0325fd1fae@sirena.org.uk>
On 11/06/25 6:09 pm, Mark Brown wrote:
> On Wed, Jun 11, 2025 at 05:40:11PM +0530, Dev Jain wrote:
>
>> If CONFIG_UPROBES is not set, a merge subtest fails:
> ...
>
>> CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by
>> CONFIG_FTRACE. Therefore add this config to selftests/mm/config so that
>> CI systems can include this config in the kernel build.
>> +++ b/tools/testing/selftests/mm/config
>> @@ -8,3 +8,4 @@ CONFIG_GUP_TEST=y
>> CONFIG_TRANSPARENT_HUGEPAGE=y
>> CONFIG_MEM_SOFT_DIRTY=y
>> CONFIG_ANON_VMA_NAME=y
>> +CONFIG_FTRACE=y
> If we need UPROBES we should enable UPROBES explicitly, otherwise it
> looks like we're just randomly enabling FTRACE even though it's not
> used itself. If it's a dependency for UPROBES and we also enable
> UPROBES that's a bit more obvious.
Fair point actually; I'll send a v2 if no other objections are there.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2025-06-11 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 12:10 Dev Jain
2025-06-11 12:26 ` Aishwarya
2025-06-11 12:30 ` Pedro Falcato
2025-06-12 6:28 ` Dev Jain
2025-06-12 10:04 ` Pedro Falcato
2025-06-11 12:35 ` Lorenzo Stoakes
2025-06-11 12:51 ` Dev Jain
2025-06-11 12:39 ` Mark Brown
2025-06-11 12:50 ` Dev Jain [this message]
2025-06-11 14:01 ` Donet Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41daafbe-50c0-4707-8004-55826dd3003f@arm.com \
--to=dev.jain@arm.com \
--cc=Liam.Howlett@oracle.com \
--cc=aishwarya.tcv@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=jannh@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pfalcato@suse.de \
--cc=pulehui@huawei.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox