From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD8EC10F1A for ; Tue, 7 May 2024 10:39:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CF0B6B0093; Tue, 7 May 2024 06:39:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956F16B0095; Tue, 7 May 2024 06:39:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 782AE6B0096; Tue, 7 May 2024 06:39:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 559B96B0093 for ; Tue, 7 May 2024 06:39:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA61016073B for ; Tue, 7 May 2024 10:39:28 +0000 (UTC) X-FDA: 82091253216.16.8BADCC2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 8586D14000C for ; Tue, 7 May 2024 10:39:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NIeTu3sE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715078366; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Yc/uGxE+uImxLF2V4o/qVkq/gVCojPxtujzHG2Vph0=; b=po8Ou0glZ/ruHCEQZymFgA1SLgU1ZNHUarH/ujjsmCtcbcX/nubZ7chzZ+kgYUMncr4G2p YyxobLtQ/KIizj1veMmjkdaiSHg/RP7RuDw3ca/yujDGgzTDiK5LrVa09zQhFos+izimxJ O1V38gZSmeE3Fog1EnH0rifjv4wrdWo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715078366; a=rsa-sha256; cv=none; b=w6yS2Swox/VuXlw1iOaPS+YxcIckzMuTAYwlpF1RBFYbfR2yju8FLIib+UTx+4aKR2/p3r Q4xltAn0laWgI3PZsjlUMFestI0veOYriZZQEz1DBIYlJFa67MvapmzcMpqeC/qczLcMQB DRja/+fRlVMQexm3gYU//rShGXguLYs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NIeTu3sE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715078365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1Yc/uGxE+uImxLF2V4o/qVkq/gVCojPxtujzHG2Vph0=; b=NIeTu3sESmbaSJODXZ7Wpj2hS4j+Z3oeervZ/o0kAecG0rkPBo9sW14X8YI9AdZD6E6sZk xRQk1OAwj7nKM7aU7QrkOuMqNNupVkxmZPnQB5JsfPBhJaNuASwj7O9L8MxDmIT9dtPeLG zF975MYZoUuWP277NrBiFtAP4cH3Jg0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-7QwX_Eu0MgOcWgn_2nlVjg-1; Tue, 07 May 2024 06:39:24 -0400 X-MC-Unique: 7QwX_Eu0MgOcWgn_2nlVjg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-34f7618a1f2so573943f8f.1 for ; Tue, 07 May 2024 03:39:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715078363; x=1715683163; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1Yc/uGxE+uImxLF2V4o/qVkq/gVCojPxtujzHG2Vph0=; b=S3pEFNYFbV1nvc1Mz8l7kjaLgHKN1Fop3wOhMOZo4skr2IRjt+hAa3SiyBCDQSm2H3 NoMwXk1X9zAeKZzl75tSR/7TgGKusL5HuHMRDkW9lvsj9c5fSo/7kCU9tr7Hd9qYS2ty mG4YboYbX+rZYBKJqTJMgZdYXLtHSi3qM3J9aAa8qbKXOBDa+dvHb0RrTcXsW8jm2DGh c/mXjHu3pPUDjib8sOHsOkrGTYTsz/rMcjhmNagWJ0uBRYUJPf6lHc5kohFJIxDXipBj cU/ei6xNRZ26gpYSWjjnegORYvAgooaQhkrAScY0VfSciL8lVClNRpyVBHxDe42KfEge QSkA== X-Forwarded-Encrypted: i=1; AJvYcCXH6VYaLDigUzw4lVcaMd7JHBq0YuH/vTzQziZDquiu2L5WAQPrlRcEye+KhEDrxWLDA4HCsr4uMgmckFAfIloJz44= X-Gm-Message-State: AOJu0YwoAatbfbD1+lAuSX4xKDsipsfsd8RdqoC+IdouNiZcHtNA28Cr ljR2WYdllMfj7JB64ESi3lGSxJwIzDmw9xJ+ie6hW1+cwDd5mZt3rJew3PNi7YdOlhdXP3T0p9J vggUiO0L9QtDXQ9Nuay0FGUtZkyoFo13QvRwUqr8O16XMPjRM X-Received: by 2002:adf:fc11:0:b0:34c:f87b:f9fb with SMTP id ffacd0b85a97d-34f81d4a133mr2025082f8f.25.1715078362804; Tue, 07 May 2024 03:39:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiRUk/XcvGMfa+jn8kUUanFP+rZ/PEvRCL88y0POGlYEH9ijy0n2iUhTnv1FyAcTnt8DWY9A== X-Received: by 2002:adf:fc11:0:b0:34c:f87b:f9fb with SMTP id ffacd0b85a97d-34f81d4a133mr2025047f8f.25.1715078362288; Tue, 07 May 2024 03:39:22 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id h12-20020a05600c314c00b0041be9cb540esm19101350wmo.18.2024.05.07.03.39.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 03:39:21 -0700 (PDT) Message-ID: <41c1bd1f-b1d7-4faf-a422-1eff7425b35c@redhat.com> Date: Tue, 7 May 2024 12:39:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/6] mm: swap: entirely map large folios found in swapcache To: Barry Song <21cnbao@gmail.com> Cc: Ryan Roberts , akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com References: <20240503005023.174597-1-21cnbao@gmail.com> <20240503005023.174597-7-21cnbao@gmail.com> <0b4d4d4b-91d8-4fd5-af4e-aebe9ee08b89@arm.com> <5b770715-7516-42a8-9ea0-3f61572d92af@redhat.com> <7dc2084e-d8b1-42f7-b854-38981839f82e@redhat.com> <099a2c9e-f85e-4fe7-99dd-81b61115935c@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8586D14000C X-Stat-Signature: wcacxpfdniwy6qctjuw9ee3p8mitibf1 X-Rspam-User: X-HE-Tag: 1715078366-775833 X-HE-Meta: U2FsdGVkX19shwkA9fr6DvQm/iSzhRg+yNpOWY0t/7J85Cm0h9BXKclbvZFcjfUQ4n6PHIMLvm796BUPZmLe6qWQOC0T73HcRrCBSJve2CH5hFdkTZIe/17Ag1xQTcq81k6XKO4kzYeUPWUhQsjttRykzlRy9mOCU6PdX5D5hL3crCeMMisnlA5tExa3LduGGfTTTt1uu5TM0hH0J6ihug+q5zJCdH1pNbfDY3QiP85IS9j3qZhwwnXcn5Q/uW7Ri5gJvXYS7AnrvFHGdi3bn2U0mieb6QjOUXQY239QeTg3aAuulYB4Nf96xZwiC2wETtxPrsdjobX38UOwKpLPeWiar7LWWcH9S9NIziLyyOG0BxfRld5YdeD5Lj2UV+uQE9NqwPVeJck7j8omLrSi1sCwGV7J9PchUuth/7l3LVjZlwQ6Ade0eajibpbf4ojzBLpEDIBb7YFobkdo/+4HdGYkHPjn7i46XNHfbJoZVMlObKhwrIB6Y7vIv+pSjlxDeswzyODVmkq2MS3zlp4z1aSzwoOOaT5/2AaOl4d2z/MIb9Ry5balzl0DRZcgxqsJaArdsSB9AGjbw332inK/bOJ1T+Ts9s2kMv7wemj46iPiUc4I0+FuW4zEg82KloaP/7E6srQvxW6E3YLET1E67Ekx1yUgnpBx1TFa7Nowo7CRg9SuLiFhmqtUZ9FCCPH/ArrioOAbgm0rE3eFGijmoj4xJZRqhViAZ3EbWmPQ9O3djG37HuMiP94Qy/dgdgXlq2E34BVfuFr90cAhKd9shOl0A3X5RRplwLwGX9dF7JauWXJLkOPX44r/bClEU51bhwGHG8FCT3+xxkxxe4xzdwA3yb/0m/RCMKvZ8qZFcKCiBUQ6UrV18eCf9ZR4b6ZxDhQWWbj/nvhh7WsOmov4S1zLo8WTvOeYNjKybREjTTdINC767vtpODqpHWKKSz/zmGBSI23V/q6yHWk1uvH oqk4lOAb 8YOJ3r7umQrt+QHXp+SHCrnX4Xhg6UnHPMyI1zldq03DeNxgfWA+Tm1xrgmyXzZsT81qHLEud+Wu3rqC9LJsRJJPMUhEpicYOdQ0+NwiC1R9CMW4V1Yqb/GALCBIwcCkq5pfaiCLAB2FR/Ji/2guVp0qn6WgmyBG5B7pK9EizIFTRPRZ1PLj3gVvyJzwTti71so0l05/+vQ0c/++b+h9UkbVmUWgqh6ceueLTiXmOk4+skDYm7a1KfV2IoByFzf3OeHxnC3FemBOY3/C8VYukvJe2YUcr4bp/aQcwCYM4QaR6CNqHT8fVr3oY1LCfTKuQmJqqNAPQBmF3ikKEiZWSxr0FYCFwAf899rNU9flbtsMouQKcN7O4FmkkSI0YMYpY6BJkw3rzjoQq2ZYGeEN6IU1ySu74Pf+ABFIRM9kj2+fyQisrIQa8aFhN3lEjRQfMC2xd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.24 11:24, Barry Song wrote: > On Tue, May 7, 2024 at 8:59 PM David Hildenbrand wrote: >> >>>> Let's assume a single subpage of a large folio is no longer mapped. >>>> Then, we'd have: >>>> >>>> nr_pages == folio_nr_pages(folio) - 1. >>>> >>>> You could simply map+reuse most of the folio without COWing. >>> >>> yes. This is good but the pte which is no longer mapped could be >>> anyone within the nr_pages PTEs. so it could be quite tricky for >>> set_ptes. >> >> The swap batching logic should take care of that, otherwise it would be >> buggy. > > When you mention "it would be buggy," are you also referring to the current > fallback approach? or only refer to the future patch which might be able > to map/reuse "nr_pages - 1" pages? swap_pte_batch() should not skip any holes. So consequently, set_ptes() should do the right thing. (regarding your comment "could be quite ricky for set_ptes") So I think that should be working as expected. > > The current patch falls back to setting nr_pages = 1 without mapping or > reusing nr_pages - 1. I feel your concern doesn't refer to this fallback? > >> >>> >>>> >>>> Once we support COW reuse of PTE-mapped THP we'd do the same. Here, it's >>>> just easy to detect that the folio is exclusive (folio_ref_count(folio) >>>> == 1 before mapping anything). >>>> >>>> If you really want to mimic what do_wp_page() currently does, you should >>>> have: >>>> >>>> exclusive || (folio_ref_count(folio) == 1 && !folio_test_large(folio)) >>> >>> I actually dislike the part that do_wp_page() handles the reuse of a large >>> folio which is entirely mapped. For example, A forks B, B exit, we write >>> A's large folio, we get nr_pages CoW of small folios. Ideally, we can >>> reuse the whole folios for writing. >> >> Yes, see the link I shared to what I am working on. There isn't really a >> question if what we do right now needs to be improved and all these >> scenarios are pretty obvious clear. > > Great! I plan to dedicate more time to reviewing your work. Nice! And there will be a lot of follow-up optimization work I won't tackle immediately regarding COW (COW-reuse around, maybe sometimes we want to COW bigger chunks). I still have making PageAnonExclusive a per-folio flag on my TODO list, that will help the COW-reuse around case a lot. > >> >>> >>>> >>>> Personally, I think we should keep it simple here and use: >>>> >>>> exclusive || folio_ref_count(folio) == 1 >>> >>> I feel this is still better than >>> exclusive || (folio_ref_count(folio) == 1 && !folio_test_large(folio)) >>> as we reuse the whole large folio. the do_wp_page() behaviour >>> doesn't have this. >> >> Yes, but there is the comment "Same logic as in do_wp_page();". We >> already ran into issues having different COW reuse logic all over the >> place. For this case here, I don't care if we leave it as >> >> "exclusive || folio_ref_count(folio) == 1" > > I'm perfectly fine with using the code for this patchset and maybe > looking for other > opportunities for potential optimization as an incremental patchset, > for example, > reusing the remaining PTEs as suggested by you - "simply map+reuse most of > the folio without COWing." > >> >> But let's not try inventing new stuff here. > > It seems you ignored and snipped my "16 + 14" pages and "15" pages > example though. but once we support "simply map+reuse most of the > folio without COWing", the "16+14" problem can be resolved, instead, > we consume 16 pages. Oh, sorry for skipping that, for me it was rather clear: the partially mapped folios will be on the deferred split list and the excess memory can (and will be) reclaimed when there is need. So this temporary memory consumption is usually not a problem in practice. But yes, something to optimize (just like COW reuse in general). -- Cheers, David / dhildenb