From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64744C5AD49 for ; Fri, 30 May 2025 19:52:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 032256B01A7; Fri, 30 May 2025 15:52:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00A056B01A8; Fri, 30 May 2025 15:52:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3CC36B01A9; Fri, 30 May 2025 15:52:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C526F6B01A7 for ; Fri, 30 May 2025 15:52:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7AE3416145F for ; Fri, 30 May 2025 19:52:54 +0000 (UTC) X-FDA: 83500622268.04.61DFECF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 17D6116000D for ; Fri, 30 May 2025 19:52:51 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BYaoe/DD"; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748634772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=96jjxFEHZGPlrOW+4VgbtcPkDz4sPKCIYqYJQxu3cyg=; b=lRKBWT8P54l+RzPyYHI1RLeryME6yYk7fxYQeoNWBefnTOxMA4DUeR6GqpVUPKFuVx6wcs YY97HCFzH+lAToOjRrScX6BO9t34a8G637WCGshJWq3KNstyJIccouDVr9uXCcmeUkVLpW NC/arSmKxOkWIHUP5Q0TDygrRAm3db8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BYaoe/DD"; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748634772; a=rsa-sha256; cv=none; b=xbbudfcSUmavIKxbYF4KMpWOCif40flvIk99mEbviDmxA8rMs0DA4KQAalSlhDp+KjFBpT O7JgH02mmD97QXbUwUSpcyj1wUWNK0RKUYCf9aQUekc+KESB7b9ccs07Qze53HwR99Lx2I LKVmfuVBuLfKJB2ustTson/SIsJT21A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748634771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=96jjxFEHZGPlrOW+4VgbtcPkDz4sPKCIYqYJQxu3cyg=; b=BYaoe/DDC2lwgP7Uwkd5KmkB75A1F5emHXP++z7mkqvhcQft1261/h30T2N6pJ7ryeypwl iDyyIRFc3iVzZ4hZun5KNG7phTkQpDvCikDDMfIeyEp3wdSETPUDroEVP10mh+QCW1lz8o iPR9144pWEfDZQJso837PGCIW/sJRWQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-dM3WmkkFPcag1s-v574zqg-1; Fri, 30 May 2025 15:52:50 -0400 X-MC-Unique: dM3WmkkFPcag1s-v574zqg-1 X-Mimecast-MFC-AGG-ID: dM3WmkkFPcag1s-v574zqg_1748634769 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d734da1a3so13807065e9.0 for ; Fri, 30 May 2025 12:52:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748634769; x=1749239569; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=96jjxFEHZGPlrOW+4VgbtcPkDz4sPKCIYqYJQxu3cyg=; b=KreLeeftNxGW34R099PlHCj3l6+UkiJDRiuGcXJ1cJ+PTddwDF8BXhvz2sQB5zBhe7 NLlBhC2kEY2H+mH1j2zYWYkmdpm3Z8R4RDn6mX0YCs2v6YpTCi+hhVL/mJcEXRX+62Qz N/62lmKANeHRaW50Ew3kYofSDIsrcSwfuOJOnSQkmhiNDI4yi5a1i6LWT/TegLZssgqa FZVL+sn+y9wIGtAXkn6qELAvLEY4DcduleIvcV4LNilQ4PoJ0rANoMHjtHNrMYY+YxmB s5FKywb4uAsGDUai6GkN3R+cgZryZY4eJOhL4y+7cO/78NtWuk13Lkx6U/M+dvWSJrSY gXxw== X-Forwarded-Encrypted: i=1; AJvYcCWNegrZHv20ohfogwEY5OInaj/6ferzIiEByG9jD+R/ltJW0dn2JTWs60xQGE6xbqwYRfHVTDYPEg==@kvack.org X-Gm-Message-State: AOJu0Ywn6Ew9yb7pG3Whk9+GK8Lkua9Nzta9FEuHGvK7gh18Cxrl2PAt 2i8CJa9Fi6kkC6j1Sau74CWAhDcBV7q4agslnQZ1wXdcyQNARYD1XhR4YPs491hI988wUJ0D9qS Ylvqfx9hrEIDtKYWx4NfdPM98XR7XDIAZRDrUnIeqgnHoUA53mBfo X-Gm-Gg: ASbGncvmaor2JuGJ7cG5LzX65dUvROzUqeZM1bdh+EizFMLP5g6LMlcYUU0L4TW839B RkZFaUIo3xFK8AgVEd00zEVrVuEslkaN24PJZgB7TdG6caX3QHJsU/PaTjnCdo8QKcy6gA2dxLv Y0TIf49BK0dchyCPqSO+MIFmvBVzaosf66THsaotzP/HYnt0r3koJNaa3bjr2B0IhbbtIgb33Ax jwgyt3RPEhKcS+hllIYePf6kdz5jBI8RQP4TcARc0hKo0RP6aBzoFVk2ZX8VqzXGoN7WebcrV6A jWzNTRHIvOVwknSlGc7HtXIcQJQ+JvcRDwC0PpRhKY0S4+pCNcMUykw2cBmroAMKTCI60JJTfbR Eec48pR06a9oKJ6X5PrXUL10kd3h6FtjSCTdjU4s= X-Received: by 2002:a05:600c:4e44:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-450d882b3c3mr35763115e9.2.1748634768676; Fri, 30 May 2025 12:52:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbqT2fQtlryiIiwgLZjsVbyHznyCR0OAafR1TehdhYnrQM/DYdVj9cYIRI3Hrzz8b/JkSF0w== X-Received: by 2002:a05:600c:4e44:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-450d882b3c3mr35762935e9.2.1748634768290; Fri, 30 May 2025 12:52:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d620c544sm22252995e9.2.2025.05.30.12.52.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 12:52:47 -0700 (PDT) Message-ID: <41b9f35e-6ce9-4d2d-a2d5-f1021648ac37@redhat.com> Date: Fri, 30 May 2025 21:52:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/6] mm/page_isolation: remove migratetype from move_freepages_block_isolate() To: Zi Yan , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org Cc: Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250530162227.715551-1-ziy@nvidia.com> <20250530162227.715551-5-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250530162227.715551-5-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hoROcOLjLgJuXkzjUYqpZ-ZwAdtC4lkkMKZSXH1v9bE_1748634769 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 17D6116000D X-Stat-Signature: tsb81hhw5qzxb3h5fhkw3w4ftsadcard X-Rspam-User: X-HE-Tag: 1748634771-569122 X-HE-Meta: U2FsdGVkX1/lxWWUrtTo18Iplr+w/UB7sEOeiEMiPdPTLtCjuWJnMO2gq8R/V9UWzoybo+SwQwS/cC/eTJ8krJlxqOqS6OJ6Fma8gqjo124r3nncQbiMndHR+zzcRsKaPjid86q+oUZeta7kurvH3ioHJXLiKph3LTBE3xQUr29JnTkgof2OdBBoh20uG4jSsdYGizUNU0E8xfOJ0F6YJ1f+NOUvzzfq1SmcOgWDej0hEtWAk/+b4n5ky06yHWRdUxP+IHYxIxQsfP/Gg3e/mQibuZjWBrv1MY8lQ/RyQdeSCcWroiRTE/VQpWKQ1m5EJlMi3NzUNf5qDmm/huCFdLTeS5j8sIntQIUIuAMi6m26t7jEVgX/6z45Y+FG9Bsl3sJh0IooVoz2jH9SGJfIQq756/daHWJqfBkwNG4W4OM1ZvxZYswntbA1OW1rz4Hy50gLg2t9E5/WiH7fv/WyNMtDx4S2vHpDYrxJAR4/HrE7LQ07C9HS7S/SqahT8NCQm4GJjx5cADbDfBLP9m2B96pnE2VzSkfiqLPfFhua4t89luZ7886Oooo3yF/ua9bKL5ORbFM5twPLbpo60hMiw6QPcz1blrNL6F3X5xyLo3HFTej7yXpRfoaEVsVQPMLmrEbN7VvwzxUrGm+LZUNW1F5MoU06zSgA3ztPDokKabK9m89xg3XDhOI2l4c/Q7C/ROrjT4AyZUcAUce1LCc/QOzfdwhhbdxGmLc0tnYOWB2eMSE3r86vnOWmx14vtCbYrlO3oNJB4nZ4cC6eiHHwhqcNL9AiO5HooKS9I+xI3TDtNjyMbGloQ6KNPLGcWPbMaBn6rKV4pqWn5wVIzWa4MWOpUhgnU1+YhVEmUhkWhvLG7l+IHVVNayErjlitokVWfWugpfXs8JBmXV//yRRPPsCjRrdHD2Qwq8kfyhotLL3zc1drK1sGX9E6+mcEHOn3r8woSqfkY+w4NvE2DKF 5Qs/D5PU 1ufOrPBUf7jxUHiaHelw0geUebwt0VsP2ZTmHd5Sk/JUp9bEgsG7NfiCN4n7+Cm8zfM+YhxDOunCp7nHF38NG45fWYIlEVX+vs1U7gen8vy5hmPUX+X9YGUv3AN80qFjFktEWiGPnrOL/FNuB8SaqHBfDlztzIYv3jgiAykmsa5TStJo+tO7OVM+hni53UEw5dswhwdUuFOvlD8ZiLWrDI76r2tcENOHQRNpIVqSGwDiWfRL6p/ElloLWg2H3j6DAp+U1U7Ha+3kr0/EteaarPa7E8ujfV1+h2pmyNKTeuHzDycskdfb/GdqJvxJ1+TbhzIiUKUO5P6fcY5RATUhb6n+uIZdZKUntZ3JRvTd2y2P91vwS85Hl8K6pvwY9jyQq/kXUkhcuqKoon5Ur3AazYvQUD+zuPiPNUUI8++Fotze2DzXdjafVnE4HaTeSYdn8t/xZSF0JCbBhDGRaaVSG+J6xZrpRCTuOLTTbGfnYMF4PNyUSD1eSlgxQWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 18:22, Zi Yan wrote: > Since migratetype is no longer overwritten during pageblock isolation, > moving a pageblock out of MIGRATE_ISOLATE no longer needs a new > migratetype. > > Add pageblock_isolate_and_move_free_pages() and > pageblock_unisolate_and_move_free_pages() to be explicit about the page > isolation operations. Both share the common code in > __move_freepages_block_isolate(), which is renamed from > move_freepages_block_isolate(). > > Add toggle_pageblock_isolate() to flip pageblock isolation bit in > __move_freepages_block_isolate(). > > Make set_pageblock_migratetype() only accept non MIGRATE_ISOLATE types, > so that one should use set_pageblock_isolate() to isolate pageblocks. > As a result, move pageblock migratetype code out of > __move_freepages_block(). > > Signed-off-by: Zi Yan > --- [...] > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index b2fc5266e3d2..08f627a5032f 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -188,7 +188,7 @@ static int set_migratetype_isolate(struct page *page, int migratetype, int isol_ > unmovable = has_unmovable_pages(check_unmovable_start, check_unmovable_end, > migratetype, isol_flags); > if (!unmovable) { > - if (!move_freepages_block_isolate(zone, page, MIGRATE_ISOLATE)) { > + if (!pageblock_isolate_and_move_free_pages(zone, page)) { > spin_unlock_irqrestore(&zone->lock, flags); > return -EBUSY; > } > @@ -209,7 +209,7 @@ static int set_migratetype_isolate(struct page *page, int migratetype, int isol_ > return -EBUSY; > } > > -static void unset_migratetype_isolate(struct page *page, int migratetype) > +static void unset_migratetype_isolate(struct page *page) The function name is a bit misleading. It's more like "unisolate pageblock", right? Maybe something to clean up later. Acked-by: David Hildenbrand -- Cheers, David / dhildenb