Andi Kleen wrote: >>got it, except that there is no "new2 = NULL;" in 2.6.10-mm2! >> >>Looks like it was misplaced, because I do see it now in 2.6.10. >> >> > >I double checked 2.6.10 and the code also looks correct me, >working as described by Hugh. > >Optimistic locking can be ugly :) > > yeah, 2.6.10 makes sense to me too. But I'm working in -mm2, and the new2 = NULL line is missing, hence my initial confusion. Trivial patch to -mm2 attached. Just want to make sure it has been, or will be, put back in. Steve