From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <41E43E26.2060303@mvista.com> Date: Tue, 11 Jan 2005 12:59:18 -0800 From: Steve Longerbeam MIME-Version: 1.0 Subject: Re: page migration patchset References: <41DB35B8.1090803@sgi.com> <41DB5CE9.6090505@sgi.com> <41DC34EF.7010507@mvista.com> <41E3F2DA.5030900@sgi.com> <41E42268.5090404@mvista.com> <41E4295F.1010909@sgi.com> In-Reply-To: <41E4295F.1010909@sgi.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Ray Bryant Cc: Andi Kleen , Kernel Mailing List , linux-mm List-ID: Ray Bryant wrote: > Steve Longerbeam wrote: > > >> >> isn't this already taken care of? read_swap_cache_async() is given >> a vma, and passes it to alloc_page_vma(). So if you have earlier >> changed the policy for that vma, the new policy will be used >> when allocating the page during the swap in. >> >> Steve >> > > What if the policy associated with a vma is the default policy? then read_swap_cache_async() would probably allocate pages for the swap readin from the wrong nodes, but then migrate_process_pages would move those to the correct nodes later. But if migrate_process_pages is called *before* swap readin, the policies will be changed and read_swap_cache_async() would allocate from the correct nodes. Maybe I'm missing something, but let me rephrase my argument. If read_swap_cache_async() is called *before* the vma policies are changed, they will most likely be allocated from the wrong nodes but will then be migrated to the correct nodes during the policy-change-and-page-migrate syscall, and if the swap readin happens *after* the syscall, the page allocations will use the new policies. Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org