From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: arjan@infradead.org, linux-mm@kvack.org
Subject: Re: follow_page()
Date: Thu, 11 Nov 2004 23:20:15 +1100 [thread overview]
Message-ID: <419358FF.2070009@yahoo.com.au> (raw)
In-Reply-To: <20041111041111.185c29e5.akpm@osdl.org>
Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>>Kill it..?
>
>
> Think so. We'd need to review all callers to make sure that they really
> are marking pages dirty after modifying them. Right now someone may just
> be feeling lucky.
>
> (looks at access_process_vm, wonders why it isn't doing flush_dcache_page).
>
Is it because copy_{to,from}_user_page already does flushing?
Looks like it... sorry, I'm not quite up to speed on this so
I'll stop talking crap for now :)
I think you're definitely right about your original concern
though, and the callers should be all checked.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-11 12:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 10:40 follow_page() Andrew Morton
2004-11-11 10:56 ` follow_page() Arjan van de Ven
2004-11-11 11:06 ` follow_page() Andrew Morton
2004-11-11 11:10 ` follow_page() Arjan van de Ven
2004-11-11 11:58 ` follow_page() Nick Piggin
2004-11-11 12:11 ` follow_page() Andrew Morton
2004-11-11 12:20 ` Nick Piggin [this message]
2004-11-11 12:16 ` follow_page() Arjan van de Ven
2004-11-11 12:27 ` follow_page() Nick Piggin
2004-11-11 12:46 ` follow_page() Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419358FF.2070009@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox