From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B1AEC3DA61 for ; Wed, 24 Jul 2024 13:31:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E598E6B0082; Wed, 24 Jul 2024 09:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E08426B0085; Wed, 24 Jul 2024 09:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF6F76B0088; Wed, 24 Jul 2024 09:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B0E7A6B0082 for ; Wed, 24 Jul 2024 09:31:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 35605160974 for ; Wed, 24 Jul 2024 13:31:06 +0000 (UTC) X-FDA: 82374732132.18.74A804F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf01.hostedemail.com (Postfix) with ESMTP id 00C0F4002F for ; Wed, 24 Jul 2024 13:31:03 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of yangerkun@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=yangerkun@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721827840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DcJB4xwatgK7J2g/1lRhPqaYWkhJyOyPc6fcwV4D1TY=; b=6uECGQ0aCqAC1KsQQl7d+JfHAoYuKxG7tPV8ixGDVd7UOkGc2WMlRo+5UPDox5vUBziA3U zNy1Q0+vTsEicQCDbvSagNlN1S6zf9Ds5y/aHU3wFiaSSLlgTuRRY0GmX056Iov7pp3jzY 0mJAXuqb1H4kxwFlykk30OvDAc17B9Q= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of yangerkun@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=yangerkun@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721827840; a=rsa-sha256; cv=none; b=8UfjE1aXs495iaOQPmi0uDafl5hyKOq26uK6cdz9O4GxtKgRkVvGRchysm2Gqf4Eo/A+1w TfMFAhySGSx99YN7O01Bk+tYoMe3v+NlJ6WYwcWGYPCXV3gz1j5bRxhJiyOsfmmg5el/AP 2of7apC4A5td7u5IMkxcf1Nb9e37ysc= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WTZXc4xk4zyN5G; Wed, 24 Jul 2024 21:26:08 +0800 (CST) Received: from kwepemf100006.china.huawei.com (unknown [7.202.181.220]) by mail.maildlp.com (Postfix) with ESMTPS id 629FA180087; Wed, 24 Jul 2024 21:30:59 +0800 (CST) Received: from [10.174.177.210] (10.174.177.210) by kwepemf100006.china.huawei.com (7.202.181.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 24 Jul 2024 21:30:58 +0800 Message-ID: <4188b7b5-3576-9e5f-6297-794558d7a01e@huawei.com> Date: Wed, 24 Jul 2024 21:30:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] generic/736: don't run it on tmpfs To: Filipe Manana , Christoph Hellwig , CC: , , , , , linux-btrfs References: <20240720083538.2999155-1-yangerkun@huawei.com> From: yangerkun In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.210] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemf100006.china.huawei.com (7.202.181.220) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 00C0F4002F X-Stat-Signature: pap4s4rt9r79zijci7c9334gignq7cc3 X-Rspam-User: X-HE-Tag: 1721827863-136223 X-HE-Meta: U2FsdGVkX1+SPodvSmlMUM2IEIQWOc1HNKTlsrpNhtSHLSnpRQJizj57AjLNBUACp+hSzodKWCYxcOoB5/dFvKmGIW7JAHjoHOzQ3YP+gMcj9xm4UudsHVg+SgwYcBsjmGgK7ygHiX0q857ZDupRa6Vs2tzTmeCkS5xM0L8yH7csziv0O6mhkuR9cUduBAe5Krf4njzb7lZqNTnvK3WyX9uKKg1Zj4au8DqNWFEUBbJzokJKkt7I53XlYTg5N07KlgcD04+x+WO2ACS5iqWkcQjX5EoQsiLa6T6WLFxYSgjq6ujhOCBJ0ibnpQ/3H4ObY7XtHKoLPSCCBjwT8nXWRy0Gs042R2eCuOVsbxSFo+oeaLQD2RRPDi54db+x3uVYaZYlf+NXs8dhZDatMJfdwTrtCn3SfldAm+V0omQZISqfbWlQfTjxrJTKj/po6HTf4/G/iN+QpDHAgqhVOH9RA5YHpUlsB2QovmIrjYRBfm8tL7Q+wk0+796rj1WHxx8A30fZc5ChGphXxxsjsx7Wh+Psdgw22ci9ZgcuALul4tOXWAYctc7dymbFo7x8hzjxDy5b02wg12NCuANnIptMcveNr8mpLHJsVdcYVGRS7hmQluDaQB23YyQBpq0L9gHJ4YFtcwbml+h0i8liZEi6QEQI8qBV6MNMbRDUIM1PVSS49Tc6ofaPALcgeH5+TJxn6bQk+6pKTuNfMbENN2vPBDUic6nsngjRShZ+H/2wGuA94/twT4IGppoUDMyLYnxbRVPn0k7bnT9tTJ0Wc2/yw9g3LxvCCNizSurpOjZeVU5MQcBpieAq+Xu1acO2ojzXD9SSbEKNF1RJ0gxcYgY2FJibHuqcQ7T5wFSHwbOoJUQBu2Yx/dV7cN6z9KK4q37v5j8G7b/KY/3oYLZ/qNz8YoEoRzfZeH8HKzdH+8lBXumOpRHmDwxG3uuKLlFnGlj59LiyqBV2KaeXn2R210w /LG+jIXM epejGCv/8U2naWnLPHP4i73sIgaoBIlAiQ7JBZ7FEVwdr/77t73tA35Uwhe/PsMnalQxszSUZe9Hj7VQnwDuIwJ2IkEOXg5FwgBHyASy32jKCG/7yHDj39xiGjUbA85QbipHMPMqFcVS0tSXNjvv9l2QZWgGWEMiU8VpTaKTaPa/un+t+1LfeA+NzAgdoOAHFe5Wpc3sG/kONhIr0tLILdN7fhIg+/ygxO61EETUc38QUgDkuTvCae/96JnPnjTkDhB8fNm/3S8JoeIz9GBd8bQTpngHIsUn5s0epw0xig+R0lS8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, All, Sorry for the delay relay(something happened, and cannot use pc before...). 在 2024/7/21 1:26, Filipe Manana 写道: > On Sat, Jul 20, 2024 at 9:38 AM Yang Erkun wrote: >> >> We use offset_readdir for tmpfs, and every we call rename, the offset >> for the parent dir will increase by 1. So for tmpfs we will always >> fail since the infinite readdir. > > Having an infinite readdir sounds like a bug, or at least an > inconvenience and surprising for users. > We had that problem in btrfs which affected users/applications, see: > > https://lore.kernel.org/linux-btrfs/2c8c55ec-04c6-e0dc-9c5c-8c7924778c35@landley.net/ > > which was surprising for them since every other filesystem they > used/tested didn't have that problem. > Why not fix tmpfs? Thanks for all your advise, I will give a detail analysis first(maybe until last week I can do it), and after we give a conclusion about does this behavior a bug or something expected to occur, I will choose the next step! Thanks again for all your advise! > > Thanks. > >> >> Signed-off-by: Yang Erkun >> --- >> tests/generic/736 | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/generic/736 b/tests/generic/736 >> index d2432a82..9fafa8df 100755 >> --- a/tests/generic/736 >> +++ b/tests/generic/736 >> @@ -18,7 +18,7 @@ _cleanup() >> rm -fr $target_dir >> } >> >> -_supported_fs generic >> +_supported_fs generic ^tmpfs >> _require_test >> _require_test_program readdir-while-renames >> >> -- >> 2.39.2 >> >>