Re: [PATCH] generic/736: don't run it on tmpfs

[yangerkun <yangerkun@huawei.com>]

Hi, All,

Sorry for the delay relay(something happened, and cannot use pc
before...).

在 2024/7/21 1:26, Filipe Manana 写道:
> On Sat, Jul 20, 2024 at 9:38 AM Yang Erkun <yangerkun@huawei.com> wrote:
>>
>> We use offset_readdir for tmpfs, and every we call rename, the offset
>> for the parent dir will increase by 1. So for tmpfs we will always
>> fail since the infinite readdir.
> 
> Having an infinite readdir sounds like a bug, or at least an
> inconvenience and surprising for users.
> We had that problem in btrfs which affected users/applications, see:
> 
> https://lore.kernel.org/linux-btrfs/2c8c55ec-04c6-e0dc-9c5c-8c7924778c35@landley.net/
> 
> which was surprising for them since every other filesystem they
> used/tested didn't have that problem.
> Why not fix tmpfs?

Thanks for all your advise, I will give a detail analysis first(maybe
until last week I can do it), and after we give a conclusion about does
this behavior a bug or something expected to occur, I will choose the
next step!

Thanks again for all your advise!


> 
> Thanks.
> 
>>
>> Signed-off-by: Yang Erkun <yangerkun@huawei.com>
>> ---
>>   tests/generic/736 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/generic/736 b/tests/generic/736
>> index d2432a82..9fafa8df 100755
>> --- a/tests/generic/736
>> +++ b/tests/generic/736
>> @@ -18,7 +18,7 @@ _cleanup()
>>          rm -fr $target_dir
>>   }
>>
>> -_supported_fs generic
>> +_supported_fs generic ^tmpfs
>>   _require_test
>>   _require_test_program readdir-while-renames
>>
>> --
>> 2.39.2
>>
>>