From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D07C433F5 for ; Wed, 1 Jun 2022 06:53:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C21D6B0074; Wed, 1 Jun 2022 02:53:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 074D16B0075; Wed, 1 Jun 2022 02:53:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA03A6B0078; Wed, 1 Jun 2022 02:53:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D71CE6B0074 for ; Wed, 1 Jun 2022 02:53:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9DB4F20902 for ; Wed, 1 Jun 2022 06:53:42 +0000 (UTC) X-FDA: 79528751484.03.6489135 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf31.hostedemail.com (Postfix) with ESMTP id 03FE020071 for ; Wed, 1 Jun 2022 06:53:00 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LCfvg34fFzgYMq; Wed, 1 Jun 2022 14:51:59 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 1 Jun 2022 14:53:39 +0800 Subject: Re: [PATCH 1/6] mm/page_alloc: Remove zone parameter from free_one_page() To: "Matthew Wilcox (Oracle)" , References: <20220531150611.1303156-1-willy@infradead.org> <20220531150611.1303156-2-willy@infradead.org> From: Miaohe Lin Message-ID: <418569c6-fddd-6d72-022a-211743f3f9ed@huawei.com> Date: Wed, 1 Jun 2022 14:53:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220531150611.1303156-2-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: m1jyjjt88jtgbjfx3wo5tsqs7ycjd3de X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=none; spf=pass (imf31.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 03FE020071 X-HE-Tag: 1654066380-23246 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/5/31 23:06, Matthew Wilcox (Oracle) wrote: > Both callers pass in page_zone(page), so move that into free_one_page(). > Shrinks page_alloc.o by 196 bytes with allmodconfig. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Miaohe Lin Thanks! > --- > mm/page_alloc.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 29d775b60cf9..68bb77900f67 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1529,11 +1529,10 @@ static void free_pcppages_bulk(struct zone *zone, int count, > spin_unlock(&zone->lock); > } > > -static void free_one_page(struct zone *zone, > - struct page *page, unsigned long pfn, > - unsigned int order, > - int migratetype, fpi_t fpi_flags) > +static void free_one_page(struct page *page, unsigned long pfn, > + unsigned int order, int migratetype, fpi_t fpi_flags) > { > + struct zone *zone = page_zone(page); > unsigned long flags; > > spin_lock_irqsave(&zone->lock, flags); > @@ -3448,7 +3447,7 @@ void free_unref_page(struct page *page, unsigned int order) > migratetype = get_pcppage_migratetype(page); > if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { > if (unlikely(is_migrate_isolate(migratetype))) { > - free_one_page(page_zone(page), page, pfn, order, migratetype, FPI_NONE); > + free_one_page(page, pfn, order, migratetype, FPI_NONE); > return; > } > migratetype = MIGRATE_MOVABLE; > @@ -3484,7 +3483,7 @@ void free_unref_page_list(struct list_head *list) > migratetype = get_pcppage_migratetype(page); > if (unlikely(is_migrate_isolate(migratetype))) { > list_del(&page->lru); > - free_one_page(page_zone(page), page, pfn, 0, migratetype, FPI_NONE); > + free_one_page(page, pfn, 0, migratetype, FPI_NONE); > continue; > } > } >