From: Andy Whitcroft <apw@shadowen.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: lhms-devel@lists.sourceforge.net, linux-mm@kvack.org
Subject: Re: [Lhms-devel] [2/7] 060 refactor setup_memory i386
Date: Thu, 28 Oct 2004 16:55:55 +0100 [thread overview]
Message-ID: <4181168B.3060209@shadowen.org> (raw)
In-Reply-To: <41811566.2070200@us.ibm.com>
Dave Hansen wrote:
> Andy Whitcroft wrote:
>
>> +#ifndef CONFIG_DISCONTIGMEM
>> +void __init setup_bootmem_allocator(void);
>> static unsigned long __init setup_memory(void)
>> {
>
> ...
>
>> +#endif /* !CONFIG_DISCONTIGMEM */
>> +
>> +void __init setup_bootmem_allocator(void)
>> +{
>
>
> Won't this double define setup_bootmem_allocator() when
> CONFIG_DISCONTIGMEM is disabled?
That is a pre-declaration. There is only one copy of
setup_bootmem_allocator() which is either used 'here' in the flatmem
case, or from discontig.c in the DISCONTIGMEM case. The order is
backwards to minimise the overall diff; so I needed to declare it.
-apw
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-28 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 14:26 Andy Whitcroft
2004-10-28 15:51 ` [Lhms-devel] " Dave Hansen
2004-10-28 15:55 ` Andy Whitcroft [this message]
2004-10-28 16:48 ` Dave Hansen
2004-10-28 17:57 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4181168B.3060209@shadowen.org \
--to=apw@shadowen.org \
--cc=haveblue@us.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox