From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94607C3DA59 for ; Mon, 22 Jul 2024 08:08:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25B186B0089; Mon, 22 Jul 2024 04:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 209726B008A; Mon, 22 Jul 2024 04:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D0FE6B008C; Mon, 22 Jul 2024 04:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E0F306B0089 for ; Mon, 22 Jul 2024 04:08:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3BEBE1C2112 for ; Mon, 22 Jul 2024 08:08:48 +0000 (UTC) X-FDA: 82366662336.01.8805E9A Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf24.hostedemail.com (Postfix) with ESMTP id 25A3F180003 for ; Mon, 22 Jul 2024 08:08:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="CUkce5/t"; spf=pass (imf24.hostedemail.com: domain of wqu@suse.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=wqu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721635680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Wd6Cxr9N48/+xuD2e19M+YM6ch6z0+BUK831e99L6k=; b=iLoGT41sptVHo2+DTC6vt4Z8NzWRaTBAZU8p5XOWZlmLeTprOnwB4eZoewyw+KnMu+a79y xRfq6jp+pMp5pLZjYqSOkqodVky6JXbvCKOcir/ylQm+aoAGZy6b2RXmQphFiyQyu1rfPZ iQpCVPl9QR/HymDeL5491bpttJLBsI0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721635680; a=rsa-sha256; cv=none; b=XQbs5Ao13i1yktV3Z9wfJojm1Kbz3qjn1uIaeT0fkQwu0WXzhR3dulGhS5nDgeGfY2tdTP 0e3Gku4MuqgfYLOa1v9XRdkxHqHwlwx24KSlh33wpi+xJ32vozYazrCg+yR0s27uSavO/q wsr1vsuNwHQmhCyK/jG2NmJkPlbEpus= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="CUkce5/t"; spf=pass (imf24.hostedemail.com: domain of wqu@suse.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=wqu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a79f9a72a99so894590566b.0 for ; Mon, 22 Jul 2024 01:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721635723; x=1722240523; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=3Wd6Cxr9N48/+xuD2e19M+YM6ch6z0+BUK831e99L6k=; b=CUkce5/tt5ocqEB7WY9sSVhe0rl9ishr0MuMc7ugQpoQOGmoQzeQdKB+/EhH9G7Inq gWQ+CiZbPLJElxjIl9zLZnyl1G01qZMn46AfQ13bjZyU255QAb1us4DgTBSIwLJoT/Hb /4CZ6fAYOw44t6NiclG4cwuH9voIUbwXNRVy7uFCmt7mNno+0Ximcqof61svTCccg0NB VPy5MbVNlzvg2Ub5cdufQ6eTf6zifnKDZb0DlxKys0bfhdhpSFU1ZsIHK0OuHayidLLQ eevTqv1CYTMqv7W/HiQA3n/Bd/tQYz0jWwSN2yrkzaUTi8JdfaqxqhNfXtCeNttznqxs qD1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721635723; x=1722240523; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3Wd6Cxr9N48/+xuD2e19M+YM6ch6z0+BUK831e99L6k=; b=KD6bYXjshUujAt1/lwXZWJdJvZErv6UL+lZSQCAaxUw35Wg2JUcm+Sxqz9J25G0OlR iJDL6qyngZoX0uNvL+dV3z43Pf8R4jUSHm+yiB4obdKvFyb5JQ2N0j7W7NgajcFjGDB4 ydrAo01uuLeWcnidirrykhfB32B5cS4EJGXThlhAklYitocAvqs8X5TtQUh+XPFPNsjO 9w6J7I3bd6mrtMdxJc4EBAW0wVwD7aGg6YgYL2SfiI4fnf5aqMUuWwFle1higgBwyvvb ElY4ZzfrAhdLnKf+GDiqw/D0cqrdB9U583sy6uB5yMLyX/r/dp8NXWGH06E6mWDIxoVJ EdZQ== X-Forwarded-Encrypted: i=1; AJvYcCVL3v42CFcEpJkyzfVzfzcCPWYvdROel3MWbEsTK9/FHNv3x6HJ3LmQRiKG0WG0b8cAw60DndBYv1j06Ha47al1NQc= X-Gm-Message-State: AOJu0YyQeopMctMTYxV38L9QbRNkB+hn5EA9kvTPeQ5PQDYWLKd6oCIk MgC4oNceMgMBwvbGCuWXdYGx4HhdMEy9nmsHzb/ATnZi2/vXqCU+37MeCFStS+k= X-Google-Smtp-Source: AGHT+IGCRBjXz9y6hDA2TppmI58v6fD0LApEdpobjR38zRDMKp97lr+peWsJDLRYuCXEsVuIZv+GXg== X-Received: by 2002:a17:907:b9cf:b0:a75:162c:3fd5 with SMTP id a640c23a62f3a-a7a0f79cf20mr1340481166b.28.1721635723161; Mon, 22 Jul 2024 01:08:43 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d318e67e8sm525312b3a.206.2024.07.22.01.08.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jul 2024 01:08:42 -0700 (PDT) Message-ID: <417a3dfc-152c-42b4-8883-06b3c6381ea2@suse.com> Date: Mon, 22 Jul 2024 17:38:36 +0930 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/3] btrfs: always uses root memcgroup for filemap_add_folio() To: Michal Hocko , Qu Wenruo Cc: Johannes Weiner , linux-btrfs@vger.kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka References: <6a9ba2c8e70c7b5c4316404612f281a031f847da.1721384771.git.wqu@suse.com> <20240719170206.GA3242034@cmpxchg.org> <9202429f-e933-4212-a513-e065ba02517a@gmx.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJVBQkNOgemAAoJEMI9kfOh Jf6oapEH/3r/xcalNXMvyRODoprkDraOPbCnULLPNwwp4wLP0/nKXvAlhvRbDpyx1+Ht/3gW p+Klw+S9zBQemxu+6v5nX8zny8l7Q6nAM5InkLaD7U5OLRgJ0O1MNr/UTODIEVx3uzD2X6MR ECMigQxu9c3XKSELXVjTJYgRrEo8o2qb7xoInk4mlleji2rRrqBh1rS0pEexImWphJi+Xgp3 dxRGHsNGEbJ5+9yK9Nc5r67EYG4bwm+06yVT8aQS58ZI22C/UeJpPwcsYrdABcisd7dddj4Q RhWiO4Iy5MTGUD7PdfIkQ40iRcQzVEL1BeidP8v8C4LVGmk4vD1wF6xTjQRKfXHOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJjTSJuBQkNOge/AAoJEMI9kfOhJf6o rq8H/3LJmWxL6KO2y/BgOMYDZaFWE3TtdrlIEG8YIDJzIYbNIyQ4lw61RR+0P4APKstsu5VJ 9E3WR7vfxSiOmHCRIWPi32xwbkD5TwaA5m2uVg6xjb5wbdHm+OhdSBcw/fsg19aHQpsmh1/Q bjzGi56yfTxxt9R2WmFIxe6MIDzLlNw3JG42/ark2LOXywqFRnOHgFqxygoMKEG7OcGy5wJM AavA+Abj+6XoedYTwOKkwq+RX2hvXElLZbhYlE+npB1WsFYn1wJ22lHoZsuJCLba5lehI+// ShSsZT5Tlfgi92e9P7y+I/OzMvnBezAll+p/Ly2YczznKM5tV0gboCWeusM= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 25A3F180003 X-Stat-Signature: fce8jori8a3xipje5qw148iuwgdypdwu X-HE-Tag: 1721635724-557651 X-HE-Meta: U2FsdGVkX1+a002euDvAgTy9hUvEi5p3dDio6NW3U1nQwVzvSdCjDvej8SJE7xQdOOIboP1Txt9AtSsbB7axmkaw6aGwkZCgZxbf6xjqHuLCu7zWFr3c6jzFv2W6Cen2oIwhMpBgUzQXy++4JR3yudICOB8U/+i/gCiq5m8djejjlw+qZ3biq5UD7SmOEIr1MQqp/FkWvbQ8w9fqkGIYBA4BE4kJrde+afnqg3Y+t612BlMrcrSykexmNH0WFVQ+t6+v+L4+H3Y/F3Li2NNLGdcSHkN28GJNEZpZkulrU09fxIhBjk/EImgjdsQp3+0JR/CxxjICRq7kmUvhcpKt9jZFI1PaGSVmzxkOvKj8Y4hIfIqpclLgOcUmkLQqZv8L1CGCRSjT287m8h5AW2auw8Oa+CRpyn/FttKbv0PKkvC/jYYBAkWNCM86O/MVy1G5WOlZUP1Sk5m9X5+RD6X7d4QI1wWrYrxnGK9iViLQ6vT6cbXbvyu7QujYWcQUek2ymvTRwyr+/iDqd4xAq1zJOU/0AI+vn1Ln0gqa/ZaWXJKVx6d/165mRFH2VMP1SW07y28r89y0KXSjFPforkAFu3sOdOFGstJn7LuT0WmKAiz/UH0EjpSJZ89UAauT/M4TZ7ntKOtevYRsZfTTLdoT4egdGa4reYTfnHwYtj0ezp+pMKwP4MnIXf6aE53PoGNfytC/IypXPNTdm3bs9Aue1MkPa7DlZJ2nVD3dsQIdKku1KV9R8YYzQP5hTJcK2u5YZOcYNXdxPXdaTpV5HqDaopEVz9sQjgH1xeiP3p4B8LoXs+eRYCMzKrSkYKjtxOtMi9wq4DF6IsksoI9NQ7889fIXV1IPhtZzNBcO1WZbrkSa4KAUT5LDgPzCsgCDE4JrXpsGCzDitkosoNxy83rt1ERRJulL8kKn++lLmKDo812qmdVxtuS9JgTrFmiXnJ+ePhADo6+d09tcJCl4nmb UYvYx0PO iX0hY6F9bnnnMYg5E52azVtI0kEnT4PrtA2EYbfG2UE0LKuGCPf0VjXDT1D5vmZTeX53Vs7gMvhHqMbwQrQU7leFlz3MSxXizZEvHhb57atHL6Lp2/froj28QzKue307W+OCsLy8NPB/wYcPR6Bt8WNmQbwhpmn5D1DQ6F0nuZuDpFr4cqz5srl4mntktZFvRKFngWM9T3K842V1CM9GfZrzuQUS1NUBJlieHslMwxCFPntABFa39/9UVcM5yCRJzHH5kYT90ZVwLuaJgbbigyyyAIZtlRNKieENt0GOkWS1hHu6OOuMX11/FpkJxMghZyX++W0UUZPboE6D9gyZ3XwUYz+XSqAglIebw3IdR22nFqFtxdj/8Ga/4iiBuVhEFFZuC7jbzyksJK4Uc4w1iHhQMtfWeDyhLK8DQkgsFrCvq2zp8cqYBumzljy61O84kyC5x5SK0KqFdQl48MZ+ExL5HGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000716, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/7/22 17:04, Michal Hocko 写道: > On Sat 20-07-24 07:41:19, Qu Wenruo wrote: > [...] >> So according to the trend, I'm pretty sure VFS people will reject such >> new interface just to skip accounting. > > I would just give it a try with your usecase described. If this is a > nogo then the root cgroup workaround is still available. I have submitted a patchset doing exactly that, and thankfully that's the series where I got all the helpful feedbacks: https://lore.kernel.org/linux-btrfs/92dea37a395781ee4d5cf8b16307801ccd8a5700.1720572937.git.wqu@suse.com/ Unfortunately I haven't get any feedback from the VFS guys. > >> Thus the GFP_NO_ACCOUNT solution looks more feasible. > > So we have GFP_ACCOUNT to opt in for accounting and now we should be > adding GFP_NO_ACCOUNT to override it? This doesn't sound like a good use > of gfp flags (which we do not have infinitely) and it is also quite > confusing TBH. The problem is, for filemap_add_folio(), we didn't specify GFP_ACCOUNT (nor any other caller) but it is still doing the charge, due to the mostly-correct assumption that all filemap page caches are accessible to user space programs. So one can argue that, cgroup is still charged even if no GFP_ACCOUNT is specified. But I get your point, indeed it's not that a good idea to introduce GFP_NO_ACCOUNT. Thanks, Qu