From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 170F1C83F1A for ; Mon, 14 Jul 2025 14:20:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EC2C6B00A6; Mon, 14 Jul 2025 10:20:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99CD76B00A7; Mon, 14 Jul 2025 10:20:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 864846B00A8; Mon, 14 Jul 2025 10:20:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 706DB6B00A6 for ; Mon, 14 Jul 2025 10:20:05 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB8291401BC for ; Mon, 14 Jul 2025 14:20:04 +0000 (UTC) X-FDA: 83663079528.03.697CF2E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 8239D2000D for ; Mon, 14 Jul 2025 14:20:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PC8uu/De"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752502802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4K3RqJrf7KmhwL+3KLLMGGlHCpdHoFdEYm5ankYXqM8=; b=pt7p/rK6XjiB7Tvx37RH1dZiXqg/b68+WxiZzxSRT5ZUGyVcH9inOgkVKH/vyyQQFAQvHl wO6bErW+aMGJrCtohMBFKbez80FpjnwxvJ29H52AO0xCFqXt+tq/HzHt33zWha5i8ptSvF KDuk0Fs6KTVsGxc5W05bkrv9Z4MOsTg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="PC8uu/De"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752502802; a=rsa-sha256; cv=none; b=WCTr3Le5Nc0B41kNi2+sXY2URlbBDUTiADSJwNxz9otHeRp+At9tyTb52uhqhT04MRydj+ MrxvhBD+fWn+BYWT0GNrvrsNenERZ27AXhqUuzMbo7L53bb1iLS2RPoV8dximTFhXEG4oe CduhKizLKXUZfw5+dj2jgNi6gZnEBpo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752502801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4K3RqJrf7KmhwL+3KLLMGGlHCpdHoFdEYm5ankYXqM8=; b=PC8uu/DetH9z1zc4UxbfRTVK7hdtkHI9gpmdw7Fv9lU9AxdCJv/Q96vvoJmJA6bJCqFcmR yE61qjM4DsyEY6LLX8OLPgmvF0hSNuc5WIwkB0trQROWND7N2Ia92bFOwz02a2isG/zCK0 9BfGaqsKvGI7mKpjiZp6RELG9r/Qnv0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-7wDXydnDPwKhcz7uZXYpXw-1; Mon, 14 Jul 2025 10:20:00 -0400 X-MC-Unique: 7wDXydnDPwKhcz7uZXYpXw-1 X-Mimecast-MFC-AGG-ID: 7wDXydnDPwKhcz7uZXYpXw_1752502799 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4532ff43376so40544045e9.3 for ; Mon, 14 Jul 2025 07:20:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752502799; x=1753107599; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4K3RqJrf7KmhwL+3KLLMGGlHCpdHoFdEYm5ankYXqM8=; b=kEEy/psYF1CtdOxQ3uE2eEcgiCkMbFO1P389I6YzTNhr9SkTSan+Re5U+N6N1KIAkj B8tewImT8u20JmC45qSHVl1Mb3PtHCPssR9SuQjRe6v7qv5RvJcUkRrlP7/I1q6dYCyb 7jNmw+Ylgh7qk4GQChUOWBn9kl1fIVN93X5L+vpP48wLscuOs84SsZxLKKTy7UGC2uWr w86fJ6pIVKptfS+Yyvm24M2qvfPSLuPorZA2cd4Gdqyz/oxIOXLn2R+LVBIUoWl+MnqQ GA8XPmZCNtbVCYxW9dltVDPGHqeIOy0ES0ciDsX5LUn2eiU5yDNQLlzntjSREPNxbNGn ZWTQ== X-Forwarded-Encrypted: i=1; AJvYcCXwUapfSgIdOPlKLfnYs2A0/Ajgs4uW89R9VRRoh8rlHFZeWajR2OCKJvEOweoO6EwuiEItXbD8CA==@kvack.org X-Gm-Message-State: AOJu0YyQp+AGyNYlm9epPkPPaCxgCfY1SNfoB5hfc0xRsp+DdbbaNOwx 7Z1wdKrNYeX5nYUlsjNPeuYwocN5TuKj1OLHQibVY9YSXsd0+P1JWvwRRn+j/CLZCg2TswpJwZT UtzGmce5IDB5CX0rsC2HQyEJwvc8o8oXURuTc8e9FRFswc6MVBUf5 X-Gm-Gg: ASbGncteV2bNqOTfJDC1ErcpbwJjDDvPbXF/JJtCw/12RFojkGLEB5rl8UHwKuIv+/K 9YxJGLwb2+8C/EComYVUAqVGHqhHhdctf/G7gkFAVZHluC+gu6WZMcPl3lE7pRcsg08M0IGP4MQ hOs+wNU9sJvnN+5yfGZgfLAQmGLFCaFyBPKeLSflO0Njft/HgkszSAs7VABwYtIvIoNU8Iq5P2B vHM3R0g7KOkDpQ9Qs2/RbgQcU5HJvtGwHVoKZXteGvY+Ey0F8Kog8RRPQgHzqBCjXVElRQS5K88 Qqj9MP+zUqE/fQLZz4cZY2aPhdU9owxe51k6MrxcjVkf6iqGad+dTgHQsT3c6t2xBS62PWSGcjA f+RtHMnkUF/fFsmLrznu9aW/E7DDbKgbtE9z85uYF2pcfMECXAt+D4fzTfec5WqZY X-Received: by 2002:a05:600c:4fc7:b0:443:48:66d2 with SMTP id 5b1f17b1804b1-454f425864cmr140771115e9.16.1752502799177; Mon, 14 Jul 2025 07:19:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGJvO/ssnRl3cckVvvj9d7F3RJpr63ZpTi+x8KpiJ7FTSoA7deoCSAIV4bwXlXkSYtEJB8vw== X-Received: by 2002:a05:600c:4fc7:b0:443:48:66d2 with SMTP id 5b1f17b1804b1-454f425864cmr140770815e9.16.1752502798724; Mon, 14 Jul 2025 07:19:58 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc23cfsm12785293f8f.37.2025.07.14.07.19.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 07:19:58 -0700 (PDT) Message-ID: <417888bf-db7d-4334-a8df-678c14c0d442@redhat.com> Date: Mon, 14 Jul 2025 16:19:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 14/14] mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Vrabel References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-15-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zzmcyFphBahpUfLqT8eDNgCEvg2ty2VA-EJ-O9Dwu78_1752502799 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 8239D2000D X-Rspamd-Server: rspam06 X-Stat-Signature: 5yxughpz4aks3gt9nbxbddrcrpmzfwy8 X-HE-Tag: 1752502802-350651 X-HE-Meta: U2FsdGVkX1/mQSMQljBrj95q+DhaIfhioEYW9rNzOkowfDPicVhPzU8XOXqMkpCA5+bGrWtbar/Z+qvCI0+EiZvfaoOvbc7x4wfZdL8N6IJ7c/C16q8cfjbxJ44k2BzkHvRqMsiA4CvdEsIld+mcsPwT2QJ8ILbxM33j3mjFwsI781UgRvb3GQ/QBq+x/NFcQsUKmoPj1CO0caE//fHuRE961NUlyPp/rRC/a/ebAUc0N+yFiI6o/yrHbpqY64vz4WfxH+DkP1vUmFvt9iTgBEcg13awzyNs7rsB0fjoLHd9/3qf370Nnyo/AehkJ84NVNAD4Wa8bHkfbRaZON1Fm/Z57Ucrm2qAxwMnF8vNtrxitMFuRPHr+gfJgPST0R8b5bZBJcfXzSpNtm06rPWb22BZQxti8fxVSb5PWkhuIIQSY+mvIjZwHvA21Jpkf/eBlwIafzymzNp/drc7bsQJZvl1hacVjAwN/gvUyQLUaX+gHBO8FOeESj5J2gnqtO2orOrJ+Jy8GohHqoLWrEmh3rtt3s162U6wcZfqVuzg6IiXSc4i+RtGrdjy0Ak9igbi3ufatYJm9YsqVBpfQzdSM10ioecRk4lbXEPFx1t5OKbEi+UrsOMq4XSoRPA+KSZWAcSkjhPbJB5MOwXCqMs6mEk9RUhfLogWtoOr2ziM+RFGmYFjFYnh4xC4zNstVyK2vYTrf9O2Q3f6GvX2gIA+VE9ryhphnlkinMZ1w/R3FxfunbPN5WFw7nDLmEFdiMba7yKmaqi7GLtl2dQ2Ej6kl8YYSD+djbAqwjnKUyG8nOmZKDoJUCw0t3fWjfuHPIVyN/lj9n0dQE0EEhnQnL98eLO1NlQa9tTf2SmYHz6BOdFSz1Q4wrbqfFwYr6jhDIQF+d7uHfAm3O9aNDOR1S3Xq3AEUDqahPnF9NtiFrWP7Pc2AzuZw+RWLu9alB1Natzi4Ec+KKzDOs5V8MQb2R8 PzQRF636 7xmVbPpJGNvD3Fc0rJOH/xlqVtwo4ZFIVGaoTOngf0OCl4iZtlDFhYlSKX5AvNsLWS7VmXFKzQobALthUa9rXXQf6n9mB8WnNv0YLvVjhOY4qmzIee6YlNSOlkLLtLO7n4cGdP5p8dhUlILh4UEK5FJrP3kBu2b7SskoXJQkuAH53G3rjF7OSIQiyX3iFmQtypFgJz1pX2Q+dc3OcTi5M9zsdTCJeq0erjRdBOxsSOQW+mARjwciGokMo26saHwOwGBU+W9EYLmxRsLDWLqg0WCBhHwNMeB29AfD+N2vFXHEGc5Gl/XvSPmkrd6fA2MTK6e/roeRML5PdbtRLDG17iDFZl20VIxEAVRJ6ySWikPS94FZEXLTJdK7h/1JNVCJZbmC+Ky/Jj6sDrc9bNY95q/oyHhaqIfs1T+gq+oMK7l2ccWNR/trvpdrXnxMeO/lS/MgpHuwghzlnBHp/Bix6gxlnJ8D9QIFDa+K/OlYtcMznz2KYcvVjZaoQtdiNRikI5Ypd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.06.25 11:34, Oscar Salvador wrote: > On Tue, Jun 17, 2025 at 05:43:45PM +0200, David Hildenbrand wrote: >> ... and hide it behind a kconfig option. There is really no need for >> any !xen code to perform this check. >> >> The naming is a bit off: we want to find the "normal" page when a PTE >> was marked "special". So it's really not "finding a special" page. >> >> Improve the documentation, and add a comment in the code where XEN ends >> up performing the pte_mkspecial() through a hypercall. More details can >> be found in commit 923b2919e2c3 ("xen/gntdev: mark userspace PTEs as >> special on x86 PV guests"). > > Looks good to me. > Since this seems a "mistake" from the past we don't want to repeat, I wonder > whether we could seal FIND_NORMAL_PAGE somehow, and scream if someone > tries to enable it on !XEN environments. Hm, probably not that easy. I mean, as long as we cannot get rid of the XEN stuff, we don't particularly care about new users ... and it seems unlikely to get rid of that XEN stuff :( -- Cheers, David / dhildenb