From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA192C001DC for ; Wed, 26 Jul 2023 13:38:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38F6C8D0001; Wed, 26 Jul 2023 09:38:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3180B6B0072; Wed, 26 Jul 2023 09:38:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16C988D0001; Wed, 26 Jul 2023 09:38:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F3B016B0071 for ; Wed, 26 Jul 2023 09:38:22 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A4FA2C0FFB for ; Wed, 26 Jul 2023 13:38:22 +0000 (UTC) X-FDA: 81053867244.18.4DD841E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 3B85D16001C for ; Wed, 26 Jul 2023 13:38:19 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hSM653zQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690378699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n8Z700vzR7baDs8b/e0kEl1jWEWNlBZFJe5eJ9LWL2M=; b=LNP3b2clA+e0douOASdPHAL4kIZw550aaPbg9iYkX9POgn/gxJAiS3HmWV9a1IbXriKohC pluuFdzCUi73mFlGxm0kDlQpE2aXqVjNW25rCtIryKRqh+FZ8J75q5OYLDlN4pXBU9xd10 ivCGTkXXf6UtlORiGFWcj2bbFJM1u60= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hSM653zQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690378699; a=rsa-sha256; cv=none; b=1OBIrOl3DknSM0m5VCtbpugv/j733wnFLOh3KPaxW9dhsqevP51Xz3x9ONlq6IP1KJgESf JfSz8VFhyCKcl4sw05sQ8ofWf++2q7PJgaUzIoxIc1D0cDXViOUnu+VshTInVh8ZkCEvge Jo4MSYS0nFjBJX1rlcCzTSdX3MAuRvY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690378698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n8Z700vzR7baDs8b/e0kEl1jWEWNlBZFJe5eJ9LWL2M=; b=hSM653zQE4eZedw/EpjedhT8JV/30xcO52O/Fi3C4SDJLeLImnUD9Xv0ow2iAReUqe7rhL rmrMCJJ7yffeze3mAIgul52Dj3Qb/g+qRnV1MdvtCePlp50yuFyLsOHyd0sn7D1QQfIHv9 tPEoU2ri69PXe6E0zNerldWl87yWuDg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-NOT0FIiJNXW_QkITUrvgfQ-1; Wed, 26 Jul 2023 09:38:15 -0400 X-MC-Unique: NOT0FIiJNXW_QkITUrvgfQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3176549261aso1399040f8f.3 for ; Wed, 26 Jul 2023 06:38:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690378694; x=1690983494; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n8Z700vzR7baDs8b/e0kEl1jWEWNlBZFJe5eJ9LWL2M=; b=lnp8M7EXZL+9OOKvpt2t8LxUC1rUw2MQbIMCwl4glODQoZgX55HZVdm2vgQa7vbZyb 32UYcmFSO6kwt46p+wIN4piyvxbpAehi/uGzbrfrycSgBZn/ab6iZHyL597wRCe7EIhI 1wzqmZ0LInP4xw+lNed4JacJX3o9ELDWfBKPHuirQgnmg4l1Sb0qnb5WZ991r3Riv+V7 io0lBziJH8l+BaB7cZDipKhczjy7Ib4CWEqmoQQYalhcIsvTHlfT35rsLRiWptZjmBXD Tqqe9QZI7saGrsEPldWCJLljthkHT1tC41+d9ro/Gr1RQIWkHKgQABn1E9YnEvbHd56F PsSw== X-Gm-Message-State: ABy/qLZiu/6x6SFw4Lam9ba3/8b207lfwP1XPl4ORLbV0PqrNS6tqz+R 8gWupVIAQyKuNLMVwVM4Qx3vgzTK/ly1dOsQmDTMn6eTzGvTT4EJHtFsCDFLe43WSg2sKjquTLv bUpefOvCkJ0Y= X-Received: by 2002:a5d:468b:0:b0:317:59c8:17bc with SMTP id u11-20020a5d468b000000b0031759c817bcmr1262941wrq.15.1690378694085; Wed, 26 Jul 2023 06:38:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlFW6fWGnz4rPcAEd3A5rxFde+FjwCaa7dB2oKhB0S6J5Gte5BzfN0mtzCoUlg3SX0ZdBK9MJw== X-Received: by 2002:a5d:468b:0:b0:317:59c8:17bc with SMTP id u11-20020a5d468b000000b0031759c817bcmr1262918wrq.15.1690378693599; Wed, 26 Jul 2023 06:38:13 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6c57.dip0.t-ipconnect.de. [91.12.108.87]) by smtp.gmail.com with ESMTPSA id k11-20020adfd84b000000b0031773e3cf46sm2867991wrl.61.2023.07.26.06.38.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 06:38:13 -0700 (PDT) Message-ID: <416eca24-6baf-69d9-21a2-c434a9744596@redhat.com> Date: Wed, 26 Jul 2023 15:38:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] crypto, cifs: Fix error handling in extract_iter_to_sg() To: David Howells , Herbert Xu , Steve French Cc: akpm@linux-foundation.org, Sven Schnelle , "David S. Miller" , Jeff Layton , Shyam Prasad N , Rohith Surabattula , Jens Axboe , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthew Wilcox , linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-cachefs@redhat.com, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20571.1690369076@warthog.procyon.org.uk> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20571.1690369076@warthog.procyon.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3B85D16001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: b9gp1kcmmjw3434h9b88hkdj7npczjtk X-HE-Tag: 1690378699-813054 X-HE-Meta: U2FsdGVkX1+bXXy4VffqFe8Cdoau4y6t1hTz65T09bHMQpxcpcDcBYTnw4bmPtfre7KBZO9/h0TNJSs0x8lTeVhHgJsqaY+VWj4kxhRS443bkPIUPoVf5oOJUtlRT/nUukAoi0bienYJVAGOrZ/PY9YhWdKBzoYBesv4VcDtfL3XNSuEezW5buid8Mc6RO5pD8+S/0ZOsIttQLRe7zSrFpUDSwgJ7fc8a/YHfH48ofG7bClVaOA78+w2hvSQGAqoJ/40DSdO6TUfmsH6NPpVZNj5tNB3+Nu8XGuzcP7806QpZLtjuHhnIFYZ2M+14uyS093ECwLl5GngMLnRjYbsiwYFruc4q+Bq9qJnXC7Fh5u/aXvo4lrbS7VXtfzuwihWmm0TInIshKLE/kFXpzWc9nFNhjP1bbruTpO6SLoiBz3HYc2SNqFLujIs6BtrEYrYlZCBnM1EklStFYsjCCZ29MbW8mhXMD2ezCtacibMW9zrQrDl7082EcMPG0LFSs8HojrjN1XUipIVZy1NTMbqda86yp38VcS3He3YLQCedg3T0LUNIFIg++87KetWoyhSPXOeiJ6XFCvb4gM9YMCln8IdmuRSVyVjrGTY+e9zB1Gbz7MjiHzBum14V84SuwXWWGlupGXvTyMS0Ry1jAwTqIrP6CgaSBMVN8yVY/vB9wl1sO0rBzE/2G3b00fk5MCrV63PH6ZnDgDDyoQ0XY7GDiutM8KPpcAcl0U0LSJblsjpFtBp0UwDReBWsxry5niybgDr3sPghYSWl1xrWwH7f5U/ckTr9Ma0P0RzHZivaUOCaLzfkIrtA3YU7pagjVQ2Pnekbqjf3KQggtDy5wd0Lh99Ry+7SXvxcZB9NQXlwnIxduHrDDBMkZlCODmbEvZ2kC0I4lZc8i+MyknifrdKJfAzUqi0TCmTYqhWCa/rJfwsE5K05LJEIaxwImOzyId4/v0AOu2XH6UlOvTQmP+ U/9vsA1R L/IGQ1dceOGZljbYCYIkL2RugbNyCKKj87LEirCvnTk6tj41hCMFJ/t6wpVEeQ9ljXyyIBCEH15iRjD6by6A9YBkC8xsslUNyMXTBgCun6n1fwgHhGmeH/nLYIA3KTyb5m1BXbJzxOOGPMpCq77tJXzoaUuN8Oinv3Tj8Ze/LnMMGsubG5Bgq2vSfbJED5qZWHL0TB3zN9fCy+TdJw6gcInpe+fTTIpd1soy8Y+O8OvN7lXR2IhEAJrSkO/1oh5MEMs3oSNYmHjcdr6Amtyf5rxuztp97LCkp8t70THHe/2CI8PxPBAazIRtE/RedSNMiiZUmeFn5wZc31B1/VgdDvWXpUgug9655LWJXUwCtILZSSU4kyx9u9FhL89QvH+LA14BlzOvF6ikmu1YFS60kRnlR6xDr9ckkdZ0OK0JbaCJEY1qjEW3mKRD6B/ckPlnPaiVzS3/X2JtwibIeL9QzpC1LtHdg9IkJHRibX2ksJyfwpO9ACB+XugSZ2YwJ0+I9kYaqmvxhbfdwwUxUj7YoERPj2qFiZu6EmEVsQleSRcdtRM0crRXt0tuyw20dSrcXlGLsylb3UIflgr/96bkez7qUzCvZSzlzXGr7yiI4tYXPh6HbdbCrnD2NVc+BsDQX5du5QrgLYeVq3erjPDtpCa28vEApi0GdxyAjmuwBngO+HVm27bJX4QJ2JulqF364g3FZP/CVF3SaBU8DfWbMUQ+uS9NZCSxiY50H9l0aAKZCqDmEdCtjCgtjSXtE7lZZl49C+KyNjJGOyWaUUhyAB7G/jzQrOfnecElUAlyc2L8cVTmPQCT0hk+ZtPqhE7yEn0iwISbPV8p68yKEKlkvGAt/HTIdO0ELkDjJRaNPnlzDjEE6vkWhUCtc3YfjpgEHnWgK5fylSDj6XpZMxAMZQc7UhQWAnqGxMFc+3P+DKLTvfN/kOyE/jp1t+Un0zLh1AHzWIOqxLRM5D6COWIHVHFA2KZwp 1/d5qb4j o3QgA1MvJtg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.07.23 12:57, David Howells wrote: > > Fix error handling in extract_iter_to_sg(). Pages need to be unpinned, not > put in extract_user_to_sg() when handling IOVEC/UBUF sources. > > The bug may result in a warning like the following: > > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 __lse_atomic_add arch/arm64/include/asm/atomic_lse.h:27 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 arch_atomic_add arch/arm64/include/asm/atomic.h:28 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 raw_atomic_add include/linux/atomic/atomic-arch-fallback.h:537 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 atomic_add include/linux/atomic/atomic-instrumented.h:105 [inline] > WARNING: CPU: 1 PID: 20384 at mm/gup.c:229 try_grab_page+0x108/0x160 mm/gup.c:252 > ... > pc : try_grab_page+0x108/0x160 mm/gup.c:229 > lr : follow_page_pte+0x174/0x3e4 mm/gup.c:651 > ... > Call trace: > __lse_atomic_add arch/arm64/include/asm/atomic_lse.h:27 [inline] > arch_atomic_add arch/arm64/include/asm/atomic.h:28 [inline] > raw_atomic_add include/linux/atomic/atomic-arch-fallback.h:537 [inline] > atomic_add include/linux/atomic/atomic-instrumented.h:105 [inline] > try_grab_page+0x108/0x160 mm/gup.c:252 > follow_pmd_mask mm/gup.c:734 [inline] > follow_pud_mask mm/gup.c:765 [inline] > follow_p4d_mask mm/gup.c:782 [inline] > follow_page_mask+0x12c/0x2e4 mm/gup.c:839 > __get_user_pages+0x174/0x30c mm/gup.c:1217 > __get_user_pages_locked mm/gup.c:1448 [inline] > __gup_longterm_locked+0x94/0x8f4 mm/gup.c:2142 > internal_get_user_pages_fast+0x970/0xb60 mm/gup.c:3140 > pin_user_pages_fast+0x4c/0x60 mm/gup.c:3246 > iov_iter_extract_user_pages lib/iov_iter.c:1768 [inline] > iov_iter_extract_pages+0xc8/0x54c lib/iov_iter.c:1831 > extract_user_to_sg lib/scatterlist.c:1123 [inline] > extract_iter_to_sg lib/scatterlist.c:1349 [inline] > extract_iter_to_sg+0x26c/0x6fc lib/scatterlist.c:1339 > hash_sendmsg+0xc0/0x43c crypto/algif_hash.c:117 > sock_sendmsg_nosec net/socket.c:725 [inline] > sock_sendmsg+0x54/0x60 net/socket.c:748 > ____sys_sendmsg+0x270/0x2ac net/socket.c:2494 > ___sys_sendmsg+0x80/0xdc net/socket.c:2548 > __sys_sendmsg+0x68/0xc4 net/socket.c:2577 > __do_sys_sendmsg net/socket.c:2586 [inline] > __se_sys_sendmsg net/socket.c:2584 [inline] > __arm64_sys_sendmsg+0x24/0x30 net/socket.c:2584 > __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] > invoke_syscall+0x48/0x114 arch/arm64/kernel/syscall.c:52 > el0_svc_common.constprop.0+0x44/0xe4 arch/arm64/kernel/syscall.c:142 > do_el0_svc+0x38/0xa4 arch/arm64/kernel/syscall.c:191 > el0_svc+0x2c/0xb0 arch/arm64/kernel/entry-common.c:647 > el0t_64_sync_handler+0xc0/0xc4 arch/arm64/kernel/entry-common.c:665 > el0t_64_sync+0x19c/0x1a0 arch/arm64/kernel/entry.S:591 > > Fixes: 018584697533 ("netfs: Add a function to extract an iterator into a scatterlist") > Reported-by: syzbot+9b82859567f2e50c123e@syzkaller.appspotmail.com > Link: https://lore.kernel.org/linux-mm/000000000000273d0105ff97bf56@google.com/ > Signed-off-by: David Howells > cc: Sven Schnelle > cc: akpm@linux-foundation.org > cc: Herbert Xu > cc: "David S. Miller" > cc: Jeff Layton > cc: Steve French > cc: Shyam Prasad N > cc: Rohith Surabattula > cc: Jens Axboe > cc: Herbert Xu > cc: "David S. Miller" > cc: Eric Dumazet > cc: Jakub Kicinski > cc: Paolo Abeni > cc: Matthew Wilcox > cc: linux-mm@kvack.org > cc: linux-crypto@vger.kernel.org > cc: linux-cachefs@redhat.com > cc: linux-cifs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: netdev@vger.kernel.org > --- > lib/scatterlist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/scatterlist.c b/lib/scatterlist.c > index e86231a44c3d..c65566b4dc66 100644 > --- a/lib/scatterlist.c > +++ b/lib/scatterlist.c > @@ -1148,7 +1148,7 @@ static ssize_t extract_user_to_sg(struct iov_iter *iter, > > failed: > while (sgtable->nents > sgtable->orig_nents) > - put_page(sg_page(&sgtable->sgl[--sgtable->nents])); > + unpin_user_page(sg_page(&sgtable->sgl[--sgtable->nents])); > return res; > } > > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb