From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D9AC61D97 for ; Wed, 22 Nov 2023 10:42:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A8926B030E; Wed, 22 Nov 2023 05:42:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 731376B0319; Wed, 22 Nov 2023 05:42:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55CA46B031E; Wed, 22 Nov 2023 05:42:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 40D396B030E for ; Wed, 22 Nov 2023 05:42:53 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 06B16C06FB for ; Wed, 22 Nov 2023 10:42:53 +0000 (UTC) X-FDA: 81485252226.24.006C9E8 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf09.hostedemail.com (Postfix) with ESMTP id 09E2C140029 for ; Wed, 22 Nov 2023 10:42:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=NjKiNjDG; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf09.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700649770; a=rsa-sha256; cv=none; b=t9x39X7lXS1oZFfFyxpGMJetHKQ+WA98VYyiHHSaXca/CG+JcFVOer+9sg7vkAk83x07yt FQ6jbxHzf6LxOhEIDdQW3dYBgX8cwhKAe4OYvAvELY8MpYKiZeSDs59WZwI/i6loneTxvJ NfX4lbHIKE6jmBj4gLVaRzjyhvE0ZZE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=NjKiNjDG; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf09.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700649770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=rurRnFBbtA8r5xBB9XdMEov5qrYkrbGrKu11nLThWAg=; b=ZtpSAPhWmBesNyJtWnJNoyjleyCY7jSDUQ0fLjFfbj2KnoLNZjL+pvds7PBnJ/F/ruHfSF 65O7JDn4ehmAjbvi7IPiCh361kALSCjmxFnBf7ZuH2SSIJyaiLz9dzp/dAU5/C1BMS51Sa h3IfMdH5tD68rjCfSIHaMlNnG+VWAbs= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4083cd3917eso33459405e9.3 for ; Wed, 22 Nov 2023 02:42:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700649768; x=1701254568; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=rurRnFBbtA8r5xBB9XdMEov5qrYkrbGrKu11nLThWAg=; b=NjKiNjDGI53cY83hBFE0HCm84L2wen15CqgwoGjbQIxRDmEalKjkZPVcCbJQB18YwP b0MiACL4Pq39G+11O02ylcgfIMpvezVjz4TSi9K/te2Ss9Pc6xS7cGPsTglNpqaAJNw+ utMTEywfMufNW0ZlNACqFd31WiGs7MB7KUNVLfqC0jhws40KVfU3Qx6XR81EtfO9tR/f Uk848+YNJ9oYTHXs37STdNH9gD4lddvuotgPx2n5Za78gs7FRznp/wcsltXCl/j+X3Rl 6h1VuaBhF2Uom3c+7YGkPMKKozwicsnCfCqq9ePgD8d/89s8ZnGJvlxItPQFbd42RLYz HgzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700649768; x=1701254568; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rurRnFBbtA8r5xBB9XdMEov5qrYkrbGrKu11nLThWAg=; b=t1iUoD4iglEkL8MnSERLsHlQsxp2ixZIfFt9BDjlRryTijzvifKZXn6qzBac9ZE7al g41mktxt79slX8gAkUA/MGp694SIlNQoFMK72njc4xjIpJQ3QnH8IO9H1TQEZqkwJXZ1 f8nDAAntvfgvRrSeqbSlnXZnbIdNg6f35xX7Y0LZ6kiGo7d6P4IuY6ybwQFxWzzWIhcG sf8NSsamCFdVi+LuNu5OUexjqjmvjNB1YRw/OWmW7RONOGxuakZSiA9lAdvPXuvHdrd3 9jDBtrvntW/36rxzrQA9brXkorhk2w0rg6UhQEYzwQpMtg0GU5QnqWWkiCGu0A2a3f9l dfYw== X-Gm-Message-State: AOJu0YwwO5K6ZnuGgOi6aoeLhuqaaBSVUOBm5cuJIU6Dd4ko24+Z2XZu WcuSuJI9vREqTP2++3R3hD8TUg== X-Google-Smtp-Source: AGHT+IFZjLI1RN+qmEZ+XlbiqgLBb55GOp+qtgAUNp2iNwKVeATclqjSDDfovff2tf+Kv7dOVUhy+w== X-Received: by 2002:a05:600c:45d2:b0:40b:29f2:968f with SMTP id s18-20020a05600c45d200b0040b29f2968fmr1291689wmo.26.1700649768415; Wed, 22 Nov 2023 02:42:48 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id z5-20020adff745000000b0032d829e10c0sm16752245wrp.28.2023.11.22.02.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 02:42:47 -0800 (PST) From: Dan Carpenter X-Google-Original-From: Dan Carpenter Date: Wed, 22 Nov 2023 05:42:44 -0500 To: oe-kbuild@lists.linux.dev, shiju.jose@huawei.com, linux-cxl@vger.kernel.org, linux-mm@kvack.org, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com Subject: Re: [PATCH v2 06/10] memory: scrub: Add scrub driver supports configuring memory scrubbers in the system Message-ID: <416c6883-7eaf-469a-9f5f-1829f729b78e@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121101844.1161-7-shiju.jose@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 09E2C140029 X-Stat-Signature: w5tism47ami1zi15xd9ymcicdza1mzzy X-HE-Tag: 1700649769-882058 X-HE-Meta: U2FsdGVkX18pzpRZ1OgU0kXZG6HTB+Np1z2gIvmzLiIQk/ect7no/A41lyJpoUeaaq3bZNMQhbF/k8PRQbbYia0Z8DMn6avY8Qm736C7MImy9S9VPMBlOWpKimCwh4FlZZ4iQCM5WniubCVRG5nXUh8Y4/zE3kTNdvTFyajZYW+Y4qHuWHOv3jf5bRDbfRzTKjXUznPCt/ugi8oij86EVbVnqaH05/B06a9fPTNQc0uma1rhf6OTiErBXoBK3qr28CsQE+ScZ1vlNT3NjdFUuK8cYvnqZhYvjgeTYGC8MS4T49QGVBfUQRTD4yfayFX1UC/0SLHD5hALPfh4dfN2uD1898r696qnBtTufetCKjH/nVZdi/YteTlxsFVda437ATGVMGI9BYvNxS5nro+0rs8IMQtLecubLG14jFQ507KlVcblE+SAO8j+H2iGrsq2PO2N44L9mdspq2rB/Um0CgB5HuQn6BZIUv15ACRCqjMzK7JfCfds66ohNaFdWB2brgxCY40a2VUygWu9A0N24kX5rTDWnBmIu75oa2MyUEwu3Pb5Hc7eEqLiIDfTCMjMFHRsD/6aJ4S0inbCvc+2H0BXFQ9Laji9RyAjA0rLGD+4/swmU6m+dUUKtNguDm+Tm+enkgR5URpcBMoFP644YCchXP9NgdWj9ELjLytQkVrZZs2wQEuDB1WuLRCBPRJnPzifAH9LEaWeJkERq1gATwWa/64538vjqGjB7RstWqYx6QsMrsybYvtEHh73KeXnB7xhQQylVHvPeOGLCQjjlvONJrftgbwwr+VMMoBQ6oH3VQgxt7I0D6DAM94FCFp5JevUgqWwfhWDdtT681u3aeqcF0FQP4R2dG8pZaz0vE7aA1iWj1kVENfY5ETaOPSHyl2Ts/T1UZmDXCoVbKPFKwCJVMDNj2yZfFfErMrjHWwxHO1072VsGWXzPdnKSN2ugoRw+qGx5x9yi3tgjIA EQaUBhGi wIm0AjbHcxmFmfrJMjaC9Ug52EUWUQtNrH0b2KDZIcJPs9YLJZU8XesdhmntJztZeJPrStVEtUPtFZmW2o3qeO0o0GDZ8Fn8hqSscRMnZaCrBrhIdLgho7szeXaLieMtakBaiCjf0LSXK4N9hMGKUAS3intB6hJxzWI4dUS+0KJA6gcTI03V77fuojUSIqNiUTbjU6ZMXdrA6l5vnJbHLJXcLwl8e7p17bLvutzg8+Dw3aeZ+8Rozo3ERClgmjLhHf0ZQ1Fa0bZY/tjgdL3cvLNkdGKA6m7VQOn8PysI8RFZI/H+Rw60nwlH4/L59LoYH0Ny4YG23kxLV5atti8HQH+yPGNqpUIawuZiTv5rGUmOu0HJdTSG20EH8FDZaRhiDyn6jtM5JaZB79zx/3CRaXaHgfS8eXWd0C9Z7BhOhWPMwaoLoSEJ1rrBuljNe16+TfVz9cXZGvhdl837/pXa5VSp6I1t2sDSZJ+ndVqwgbujlLBQb7KzOrIIQ9GAkoEHT2jAIrKlOwHUOvwaBqFgedMDIPNitu/S75EIly97wlr2znDqOm5sJpze6afmnFxUFHlX+rKRIVYohvYY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/shiju-jose-huawei-com/cxl-mbox-Add-GET_SUPPORTED_FEATURES-mailbox-command/20231121-182247 base: linus/master patch link: https://lore.kernel.org/r/20231121101844.1161-7-shiju.jose%40huawei.com patch subject: [PATCH v2 06/10] memory: scrub: Add scrub driver supports configuring memory scrubbers in the system config: powerpc-randconfig-r071-20231122 (https://download.01.org/0day-ci/archive/20231122/202311221028.fsptP2bp-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231122/202311221028.fsptP2bp-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202311221028.fsptP2bp-lkp@intel.com/ smatch warnings: drivers/memory/scrub/memory-scrub.c:71 scrub_dev_attr_is_visible() warn: this array is probably non-NULL. 'scrub_dev->name' vim +71 drivers/memory/scrub/memory-scrub.c 248ee451a36346 Shiju Jose 2023-11-21 65 static umode_t scrub_dev_attr_is_visible(struct kobject *kobj, 248ee451a36346 Shiju Jose 2023-11-21 66 struct attribute *attr, int n) 248ee451a36346 Shiju Jose 2023-11-21 67 { 248ee451a36346 Shiju Jose 2023-11-21 68 struct device *dev = kobj_to_dev(kobj); 248ee451a36346 Shiju Jose 2023-11-21 69 struct scrub_device *scrub_dev = to_scrub_device(dev); 248ee451a36346 Shiju Jose 2023-11-21 70 248ee451a36346 Shiju Jose 2023-11-21 @71 if (attr == &dev_attr_name.attr && scrub_dev->name == NULL) I wrote this check 12 years ago and it's crap. scrub_dev->name is the first struct member so it's the same as same as "scrub_dev". However to_scrub_device() can't return NULL so this check is dead code. 248ee451a36346 Shiju Jose 2023-11-21 72 return 0; 248ee451a36346 Shiju Jose 2023-11-21 73 248ee451a36346 Shiju Jose 2023-11-21 74 return attr->mode; 248ee451a36346 Shiju Jose 2023-11-21 75 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki