From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B7FFC433F5 for ; Mon, 16 May 2022 10:09:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4D616B0071; Mon, 16 May 2022 06:09:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFCDE6B0072; Mon, 16 May 2022 06:09:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC4746B0073; Mon, 16 May 2022 06:09:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ACB2B6B0071 for ; Mon, 16 May 2022 06:09:26 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 78209811E0 for ; Mon, 16 May 2022 10:09:26 +0000 (UTC) X-FDA: 79471183932.30.5B451DC Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf21.hostedemail.com (Postfix) with ESMTP id 2F4D01C00C4 for ; Mon, 16 May 2022 10:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652695764; x=1684231764; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=0iuQqxuydIJZPFNzzRya7Q5thdN33xJWufGwf1DqOaI=; b=V80VLoil9W6O5elKM3NMX8vUbDLlPEeI83Stk6qv4tZuyZgU1F5zvU6o lLmQBRQpnJhonVRyS36Ny0CBhMH2ElNG9Pfwiyy+FQ4T8ufzM28gJnUZ5 ERbF4psdWti6ai1gWpSeC7tCA6KW2RtN6PFTcbgNA9vmGErea7JobHCvF u5JlW9c61ABRXYP0TfxfmKQZc/kzg7jYUe4nF189/evS2RNeFyqUOhaQ0 nD51M4Y7k13mTZcqUrfwVq/4r0EPWQCSrrzFZWMH8lno7bacT++wNJt5t NKdmnZPhPHQJk7EYNJHfBYu/TX/eMDFIKGdEYHwC5LW5NEL3DhnRp9FUG A==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="270487177" X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="270487177" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 03:09:20 -0700 X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="568253695" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.249.169.165]) ([10.249.169.165]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 03:09:18 -0700 Subject: Re: [kbuild-all] Re: [linux-next:master 9995/11651] fs/buffer.c:2254:5: warning: stack frame size (2144) exceeds limit (1024) in 'block_read_full_folio' To: Nathan Chancellor , Matthew Wilcox , Brian Cain Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , linux-hexagon@vger.kernel.org References: <202205150051.3RzuooAG-lkp@intel.com> From: "Chen, Rong A" Message-ID: <416aa517-6813-2227-ddce-34c8b63696e2@intel.com> Date: Mon, 16 May 2022 18:09:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2F4D01C00C4 X-Stat-Signature: kost7urr5t8r7yc7sym58tjopr9e1nst Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V80VLoil; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf21.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=rong.a.chen@intel.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652695754-304015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/15/2022 5:57 AM, Nathan Chancellor wrote: > On Sat, May 14, 2022 at 05:28:33PM +0100, Matthew Wilcox wrote: >> On Sun, May 15, 2022 at 12:23:46AM +0800, kernel test robot wrote: >>> commit: 2c69e2057962b6bd76d72446453862eb59325b49 [9995/11651] fs: Convert block_read_full_page() to block_read_full_folio() >>> config: hexagon-randconfig-r041-20220513 (https://download.01.org/0day-ci/archive/20220515/202205150051.3RzuooAG-lkp@intel.com/config) >>> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 38189438b69ca27b4c6ce707c52dbd217583d046) >> ... >>> All warnings (new ones prefixed by >>): >>> >>>>> fs/buffer.c:2254:5: warning: stack frame size (2144) exceeds limit (1024) in 'block_read_full_folio' [-Wframe-larger-than] >>> int block_read_full_folio(struct folio *folio, get_block_t *get_block) >>> ^ >>> 1 warning generated. >> >> Now show the warnings that were removed. This patch renames the >> function, and I bet there was a similar warning before this patch. >> >> But basically, I don't care about stack usage on hexagon with clang. >> AIUI, it's a known bug. > > For what it's worth, it seems like this is just 256K pages being 256K > pages... MAX_BUF_PER_PAGE is PAGE_SIZE / 512 so *arr is 2048 bytes big > in this configuration. You'd see a similar warning with PowerPC but that > configuration is non-standard: > > fs/buffer.c: In function ‘block_read_full_page’: > fs/buffer.c:2337:1: warning: the frame size of 2064 bytes is larger than 1024 bytes [-Wframe-larger-than=] > 2337 | } > | ^ > > It would be nice if the Intel folks could look at recognizing a function > rename so that you are not bothered by reports like this. Hi Nathan, Matthew, Sorry about this, we'll take a look. Best Regards, Rong Chen > > As a side note... Brian, is there any reason for 256K pages to exist for > Hexagon? This has been an option since Hexagon's introduction but is it > actually used? 4K pages is the default and the help text says "use with > caution". Perhaps the choice should be turned off altogether for > CONFIG_COMPILE_TEST so that we cannot select this configuration and > bother developers with these reports. > > Cheers, > Nathan > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org >