From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B4EC7EE23 for ; Tue, 30 May 2023 07:59:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 473B3900002; Tue, 30 May 2023 03:59:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 424EB6B0074; Tue, 30 May 2023 03:59:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EBED900002; Tue, 30 May 2023 03:59:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 197006B0072 for ; Tue, 30 May 2023 03:59:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D08B1ADA22 for ; Tue, 30 May 2023 07:59:18 +0000 (UTC) X-FDA: 80846171196.04.4FFB54F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id CC458C0015 for ; Tue, 30 May 2023 07:59:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IdefEP5V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=I4k39qnP; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685433557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aR5mnon4zhDf1c/NKhS1CdKNreGelh3NU7PyzV1RfKI=; b=OHTL5Jo+ot0x1gOtevhmVbPbtI1/uJJusFD81TlpgXeDyffLuU9z98sd3XxUykJJsgJ/kH 6Cm3371zVRDLo8RYghhpq4lkZLj5eY/nO6Pibm+2OAVXSRwq24Vh/U2euPbYJbuIhXAW/a DtI8LsU6PyDXhRqwH9hnNc1xHi0Hxpc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IdefEP5V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=I4k39qnP; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685433557; a=rsa-sha256; cv=none; b=yXjihE5h8uiW+kJpYSvFvCOjBX2PAAr82pmkTyr5ka7iyIkdIvlrqhya/zhNT7uTjqBQbi aWzOt6oNaPXZ6z1ZkwRM52iPmth89gLyLsWP4792mVVicERmKM3zJAmF3cO+LI2L/AfCks 1Z0p4Eiyj+MnkSF1zhOV0DzSxsUopIE= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4372F1F889; Tue, 30 May 2023 07:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685433555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aR5mnon4zhDf1c/NKhS1CdKNreGelh3NU7PyzV1RfKI=; b=IdefEP5Vs8tPnDdV939qTvhz0n/itBbSr7uiMbjaWXqpkL195D+dpTilo7cKs5sCRMyRQ7 Ovx49GhI8bh8QnDoq3y9Cu07TIczVegXm1iUtdpH1t0VDjdojy58DnySwNlkm9O21YVpMs w+23whnoI2l7jzruE8Gm8XIhMD6iAV8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685433555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aR5mnon4zhDf1c/NKhS1CdKNreGelh3NU7PyzV1RfKI=; b=I4k39qnPl7RKRD2hKCXntATiTlRtXQrFCBUUtSOakMGk7ZiB4xfZO2PNh/YeZJi82kkPMA 5WA0lRi+NhG5Z5CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 283B613478; Tue, 30 May 2023 07:59:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DyItCdOsdWQHJQAAMHmgww (envelope-from ); Tue, 30 May 2023 07:59:15 +0000 Message-ID: <415a2266-868c-b0d8-b45c-d92eaf02611c@suse.cz> Date: Tue, 30 May 2023 09:59:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 3/6] mm: compaction: skip more fully scanned pageblock Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CC458C0015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: shyhj56zanya519nhxjh8556prm1h9m8 X-HE-Tag: 1685433556-66788 X-HE-Meta: U2FsdGVkX1/1ghGukruzD79w2Wz7JrWsvB2E7cy0qcucnhdnd31t5L9ixHKXtkigFGR3M5S4WnM5RCE9ALN3r/x94J2k7byub1fNosYS7zrld4BeHph8les1FCEp/Qhq5Hd2RUVJObZodHMrbqyZnhqtxcN/joh5U7B9+jzLX8J0bjY4JdKQdZnpDTtyZBwQIfBfPwalaMm+ApAeePtHjTRg3nUKa9UKLRJHudPIIY6+GzfHptxWE8re37kimsbWTppY7x/4HEzhuN+BxCHIPnu+ly5TNjtF+/E4IN7Ts0ssMN2M9H3Pov9ySTjPsNgme+wo2Dxqd0nUJtEZRrGQ5SF8o29r7l4TVU0EkofdV3/V4GqeEzRrPDRurvsAkLYOmusvV9lhKm7HQ9uVL1XS7jo+7f1nGhHWM6xndUEs0YTTINVJaoyxOjKB3Su3iOo4DLDqQqf6BkrN0tr5o7H9iY5krr2ViLQo/NrUPKKtAcr6sHI63+sY6FcmeERivnhhpXZ654huwIHi4mJDFGNrdwKTHlz/xOR9ZLV6FUp9mbekCnsIYMEx0M7wUai6Oe8WzP8kndKMhPzXSkKlELLBPm3YEDt1piuZ8HNWVp11UPfOO+1qzJseqeJXRskfxRhUFVWcnyelvfRmFVCCF46o1lCPbh6nX+adG0dBby62qD7yRlly25DcPPSkAugJFwLQ4bK7y891HVUaBNAPWlcLCgTqk2lDZDXsbXwsMYIRxWPWk3HrnZOLd6jrgBhHRFR1OyXZ8anSu+8R9wKaH5RMIlqnKZeeWYcxCS9NUxycy+LODvCSDE+vLh+Av/YbKD87m7gcmhg4Sin3qYZY2jIDfHK/Xl4AntZh5eCFhDD13Olgpp7aV+DrRwAoN7y0BVlcDkcrQn+RbSJmcPP8PfqsNve1UipFY+IGtml8Pjj1nC5AnPP0XXOP1ZFzKJ9VbSQFkffSHiuyVrIyxuMlfUC EmNVEvM0 q7xq3/rJqeMa5s0pQc7zGO9EEn88PEAhuAeIzpPAT/WgTDXgenliZxOVYN5zNLNbQr1l1ZdDKYJs4+tdzqKBmVZeeZZOFxLQV84VhQWJbfbO2xw083Fcz261Km/oMIpYUAlOt3IewOtoiqreko0GL9HY/EqtbyNvD39Yr6nAQOQb5N+ofpsmbiwo1zip1ATuLulIOk+/xjjtN0SmzurfVA+HuSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/25/23 14:53, Baolin Wang wrote: > In fast_isolate_around(), it assumes the pageblock is fully scanned if > cc->nr_freepages < cc->nr_migratepages after trying to isolate some free > pages, and will set skip flag to avoid scanning in future. However this > can miss setting the skip flag for a fully scanned pageblock (returned > 'start_pfn' is equal to 'end_pfn') in the case where cc->nr_freepages > is larger than cc->nr_migratepages. > > So using the returned 'start_pfn' from isolate_freepages_block() and > 'end_pfn' to decide if a pageblock is fully scanned makes more sense. > It can also cover the case where cc->nr_freepages < cc->nr_migratepages, > which means the 'start_pfn' is usually equal to 'end_pfn' except some > uncommon fatal error occurs after non-strict mode isolation. > > Signed-off-by: Baolin Wang Acked-by: Vlastimil Babka > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 3737c6591bfb..1e5183f39ca9 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1411,7 +1411,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); > > /* Skip this pageblock in the future as it's full or nearly full */ > - if (cc->nr_freepages < cc->nr_migratepages) > + if (start_pfn == end_pfn) > set_pageblock_skip(page); > > return;