From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D588C25B6F for ; Thu, 26 Oct 2023 09:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E9F06B037F; Thu, 26 Oct 2023 05:18:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99B226B0380; Thu, 26 Oct 2023 05:18:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8632B6B0381; Thu, 26 Oct 2023 05:18:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 786546B037F for ; Thu, 26 Oct 2023 05:18:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4CE9CC0CDD for ; Thu, 26 Oct 2023 09:18:12 +0000 (UTC) X-FDA: 81387061224.12.84A399A Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf28.hostedemail.com (Postfix) with ESMTP id 4FC01C0007 for ; Thu, 26 Oct 2023 09:18:09 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AoJmaaCY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of javier.carrasco.cruz@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=javier.carrasco.cruz@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698311889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N6nuLOS7wDoKlnDkXtdydYb6hexMKNmC87DB8tE5krw=; b=jwkZlM4fHzSiNiyvRGyimEeN8CwQfCxFpvKONygJxuEiKO90oeOjBkbWva+N1Lk2TIclMr J0W5U44KCzXJd3HFa3pKIn1BqAgEAPiO9GeuDwUMKSgsS2fenqolmsVTvA7KGPctbV+GIJ TB1m0JaKiqISui+5olkZrvu65VFdQiA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AoJmaaCY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of javier.carrasco.cruz@gmail.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=javier.carrasco.cruz@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698311889; a=rsa-sha256; cv=none; b=Vqxn12PiIJGe47cqv3qRgtwOvpdYSZ7Uk94y8Xuki7avfEIg32B0AXYb5vWrhP3gjpsDY8 n/Xi9gbCvR80lh5Xzl8XSdWCt0O1G3zDv8ItLOJBsWynWW8U0Q9U7Dg1k2dnLY8zqNFIDG LXPalX9Qnutgrh1bXKllsumOARO2gw8= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-9be1ee3dc86so97248066b.1 for ; Thu, 26 Oct 2023 02:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698311888; x=1698916688; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N6nuLOS7wDoKlnDkXtdydYb6hexMKNmC87DB8tE5krw=; b=AoJmaaCYVyG8QRbTMOoJpJG7s95/8RFu7XKrh52S5jwNT9jFFWjjBX6cFpUQS0Bg8R zXMKUz3f31cjsx6t2vP9ooN+wo6hu0CLWRs1hrKrJVYrYEpf7Ezh1N4UYKC+pSkq70+V m0uwgaStqBkTmOU1WNtjg6lz7J7vf+0Id0eOnpDsXZehfgkza7vsEUVynGYatetH1LMt yL7qFJ2KLE68WwducdnjHDVCcsqQx0YMT8T5spiucgxm2nS8g0W8iw/OckiRM1pVFQ5F e2CpqwF9PEoHSiSePfIPYCimN6wvENk4C5EbjNY9S1kY4dp+3LSJdtTz8D5+ziXbcWpi AklQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698311888; x=1698916688; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N6nuLOS7wDoKlnDkXtdydYb6hexMKNmC87DB8tE5krw=; b=EMZ1uz0YpBLakfahC5CtrIrs70MZzHqH3EOxywAZ+zm2JkzA3lO5Y4Bz4V9gPVcgek hvX5vdgGzuQTbqeO1H4sHRIbknmj1QpAinQSy2fx29LiWMBw8eyLdr8B5Y2k/Co0UzC5 x6aZwQp4F9jJGzAD6HOsw5Vh6IHdgrvrTV6nrHi80h42EaQwkI0IG4ntcyAZYMt4Qc4n j1uLqscnnBrtbEXn5key+etZRWaUHnSFVcf5RG9Y1WTD4aOstYUFOHSbxcS1LwRGplvr 3+9yq151On6Q2pDh7VphbH7kfJ+gUtN2m0tS7nTySKlQEFApqs0QlnE+Ao6xQaMlICBC Qasw== X-Gm-Message-State: AOJu0YyJ345ccgMmiuW1k1NYNnXW9JUG+b8iEvnuUkmlzUSe+tINGt1V klU8cwRd44mKBStybOmZD+A= X-Google-Smtp-Source: AGHT+IFUj0ZwzMqvzblTku38GxJhnhNqeKFJ4qBJ7vzPyENk5CFk+IZqAkM1Ev1wM4iYn12dUVkyGg== X-Received: by 2002:a17:906:dc89:b0:9bf:ad86:ece8 with SMTP id cs9-20020a170906dc8900b009bfad86ece8mr15166381ejc.25.1698311887468; Thu, 26 Oct 2023 02:18:07 -0700 (PDT) Received: from ?IPV6:2a02:8389:41cf:e200:aa18:f9fe:f627:2a46? (2a02-8389-41cf-e200-aa18-f9fe-f627-2a46.cable.dynamic.v6.surfer.at. [2a02:8389:41cf:e200:aa18:f9fe:f627:2a46]) by smtp.gmail.com with ESMTPSA id kf14-20020a17090776ce00b0099bd7b26639sm11333238ejc.6.2023.10.26.02.18.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 02:18:06 -0700 (PDT) Message-ID: <415694cb-5041-41d7-9ff3-eb93a7730622@gmail.com> Date: Thu, 26 Oct 2023 11:18:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [selftests] 5b45a75377: kernel-selftests.uevent.uevent_filtering.fail To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Shuah Khan , linux-kselftest@vger.kernel.org References: <202310261454.46082aaa-oliver.sang@intel.com> Content-Language: en-US From: Javier Carrasco In-Reply-To: <202310261454.46082aaa-oliver.sang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: chdrgiu44gra4fsa1149pii6kpw1ngh9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4FC01C0007 X-HE-Tag: 1698311889-225276 X-HE-Meta: U2FsdGVkX1/jae/MoEfX6m1Zq6MvmwEj8doQQowpIHTd73WAYUrrURkoAl5ne9O8ig82E7LpI3lO6LhzPt18ztTU7z/RPrYOgXsGqsPNBiQR8+wxq4akoQU9cWyfd/ALsBatA3hJNx6ggxq0JSy/Ua6HSQ2BSNyO4nzvrbUWR3961Jgx/434xm0GdDDhnbUjIRzzXDhgM/j0byfWG0fZD+aHg2nG+qia466jTzBYNGAMaj1sc7lhbozc2qgJzBBcs/vLbze9gW6W5PIaKCIZeaFbVqQjMpfefTcVKu4XVgmOW3nFuAEPDDFXqmm2gY4FGnQFbQqGWtFmjWrvAJwn/goXPaNpKvnyqgh1nBu9ilvW5QIule0XxDmIf1xuaPj3OaL5iKbi+/G15yhy9p+yiEMFLBbd16LhnI1hxQEMNa294h8Yb3/F8dY8VXitNQ2Ty/GP6xyzzXyLxmOY/yNscAa7xZElZOuwZV+6pZxrgrQeJGwhyQa4Qol7zD39ZfcQUwt5necQbDjmMjBzKHWyEgrlyQj/soWxW7BgFH5UAl2Ql8AYJ0tg0kZUZ/vcSTQgPkb8Hz/aQlZVoGYK6X2IW8mz1eLIfDeXZ76HX7nPJj/2aUuSFL3O3409toykjYTOCJrhVDC0tAifK9uGu9lDnVV3r3oI3gbeNK5G0udOO7zlc/zGxYhL9aTHZPD2Q9dwbURWlGFyhDeR44jWqT4XD8qsoEaH6HekYo5MBtzRLuyPIvJk8M59XC0IMFKEh33W+5/nUu7hOhVxZd4yqDjHHAysALWutMSerH7UDYtyfqdcTyZ4K6vcpd8dhOQrub2sW/0f1kMuH22zsz5qmcC+obmmE7Z7WSb3tEt65TO5I8LyEDtYVl7mJDc76JecrQ73GqLOqGgsrxJsLArTnrI8j6s5fKDXkvZ+TaX6yCNcIM21FTElZCemgRGtzvTm5J01Vm7Wo7pTaf0cvthPgX+ HLpTGVVL bo6qFKIcE2irB4wxtCanwwuRwj2CyHLKh02hc6gznYaTt5WHo0QXs9Rk8g0bOop45jjSIlW+ZDnFxHFOLqXeMzxm3moABBSoAIDr9xeIR8m2muHdHjgG6L3CuUuvG5pDyjQ8A+mcOKY/j/hoIlYdMj3B0yGjJdlNIEJaXzXLfNfuOSOa0Y2UeNUBF1QtcmtMmOKw05driiVfzbXJIw00UoiUSNG039EbHT0ZSQclrTRB0vpzlvYhb8aujy9vIqw9+LRjI/5bkvP+XhLX+R18H1T5XvPcH10/AvXylb12nQX0VzrXBJisof0VvYIbMBlQjeCBWbxuCNcEpN9top7pZIzukLQ8T+fDFm4xqdZPk5TCoxuKhiShDUKArGVcSCYuFTWD8bLlncq7gZWaqaWOcHI9gNdEjGpnCFdCpLzh+Ye7Xk7h+yyRQ6OBEZefpnnJNANMRL9fAOFaBobPH6IqmjC7BImeYvYMmUevIrj/ktbGmtF2bj9Nc9mcbbEt6AZsE108T3FlPHOaX2Dob6gQRsTyrhDIKYC1xW9yXSP2/SqEBgArcLvYihRYD4sGMkQiik5usSRtm9ZGT5oQx6Iw2+SxE/75FVpLex0eVBvVyCIEwuGEJxKMBKIReOoR5tele9FXO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 26.10.23 09:11, kernel test robot wrote: > > > Hello, > > kernel test robot noticed "kernel-selftests.uevent.uevent_filtering.fail" on: > > commit: 5b45a753776be5d21cf395ec97e81c9187fbeaca ("selftests: uevent filtering: fix return on error in uevent_listener") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > [test failed on linux-next/master 2030579113a1b1b5bfd7ff24c0852847836d8fd1] > > in testcase: kernel-selftests > version: kernel-selftests-x86_64-60acb023-1_20230329 > with following parameters: > > group: group-03 > > > > compiler: gcc-12 > test machine: 36 threads 1 sockets Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (Cascade Lake) with 32G memory > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > we also noticed this issue does not always happen. as below, we saw 15 failures > out of 50 runs. however, parent keeps passing. > > > 37013b557b7f39e6 5b45a753776be5d21cf395ec97e > ---------------- --------------------------- > fail:runs %reproduction fail:runs > | | | > :50 30% 15:50 kernel-selftests.uevent.uevent_filtering.fail > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202310261454.46082aaa-oliver.sang@intel.com > > > > TAP version 13 > 1..1 > # timeout set to 300 > # selftests: uevent: uevent_filtering > # TAP version 13 > # 1..1 > # # Starting 1 tests from 1 test cases. > # # RUN global.uevent_filtering ... > # add@/devices/virtual/mem/fullACTION=addDEVPATH=/devices/virtual/mem/fullSUBSYSTEM=memSYNTH_UUID=0MAJOR=1MINOR=7DEVNAME=fullDEVMODE=0666SEQNUM=3532 > # add@/devices/virtual/mem/fullACTION=addDEVPATH=/devices/virtual/mem/fullSUBSYSTEM=memSYNTH_UUID=0MAJOR=1MINOR=7DEVNAME=fullDEVMODE=0666SEQNUM=3546 > # add@/devices/virtual/mem/fullACTION=addDEVPATH=/devices/virtual/mem/fullSUBSYSTEM=memSYNTH_UUID=0MAJOR=1MINOR=7DEVNAME=fullDEVMODE=0666SEQNUM=3556 > # add@/devices/virtual/mem/fullACTION=addDEVPATH=/devices/virtual/mem/fullSUBSYSTEM=memSYNTH_UUID=0MAJOR=1MINOR=7DEVNAME=fullDEVMODE=0666SEQNUM=3585 > # add@/devices/virtual/mem/fullACTION=addDEVPATH=/devices/virtual/mem/fullSUBSYSTEM=memSYNTH_UUID=0MAJOR=1MINOR=7DEVNAME=fullDEVMODE=0666SEQNUM=3595 > # No buffer space available - Failed to receive uevent > # # uevent_filtering.c:479:uevent_filtering:Expected 0 (0) == ret (-1) > # # uevent_filtering: Test failed at step #10 > # # FAIL global.uevent_filtering > # not ok 1 global.uevent_filtering > # # FAILED: 0 / 1 tests passed. > # # Totals: pass:0 fail:1 xfail:0 xpass:0 skip:0 error:0 > not ok 1 selftests: uevent: uevent_filtering # exit=1 > > > > The kernel config and materials to reproduce are available at: > https://download.01.org/0day-ci/archive/20231026/202310261454.46082aaa-oliver.sang@intel.com > > > What is apparently happening here is that the test returns now a proper error value in the uevent_listener function. In this case recvmsg() is returning ENOBUFS - No buffer space available. This occurs because buf[_UEVENT_BUFFER_SIZE] is not big enough, being _UEVENT_BUFFER_SIZE = (2048 *2). Therefore the error is not in the fix commit as such because the error was happening and it was not returned properly (previously ret was assigned to -1 but it was not returned). The obvious fix would be a larger buffer, but when I see de definition of UEVENT_BUFFER_SIZE in kobject.h, its value is just 2048. Then I wonder why 2048 *2 was used in the first place, why that is not enough and what size is then meaningful. After a quick search I found a discussion on Bugzilla about the UEVENT_BUFFER_SIZE being resized to 4096: https://bugzilla.kernel.org/show_bug.cgi?id=207695 But apparently it has not been resized upstream. Best regards, Javier Carrasco