From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED829C4320E for ; Thu, 26 Aug 2021 03:04:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7DC30610CD for ; Thu, 26 Aug 2021 03:04:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7DC30610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A78588D0002; Wed, 25 Aug 2021 23:04:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A28DF8D0001; Wed, 25 Aug 2021 23:04:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 916FA8D0002; Wed, 25 Aug 2021 23:04:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 7542B8D0001 for ; Wed, 25 Aug 2021 23:04:35 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 24F71253C8 for ; Thu, 26 Aug 2021 03:04:35 +0000 (UTC) X-FDA: 78515738910.36.68BEB24 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf20.hostedemail.com (Postfix) with ESMTP id CFC0CD0000B2 for ; Thu, 26 Aug 2021 03:04:34 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id m17so889282plc.6 for ; Wed, 25 Aug 2021 20:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=Hf4b8kKe8+zCps4bUNp1ug1RGqjC8xfMz7Zwk5whBzY=; b=AdhaKecFsynrryav1LJhn4GpBg3BUa/8LEsccr/8oQstjlgJUHwMlii/xBzCN6bcxG oyBfpm5K3+yLYPiE0kYB70B7rj2uh8XJwVsxqem7TIsoVWDYZdrUzo59QEkndUQK3qgw eNpCAgg9Civ3hnAh9KMiHazns2fYng1BcVr/3725nr8X1lDBEcar1/ekBXDgaVM29HZf hoIvZDzdkZQxQQjFW3AYgEbkjYYKMaX/UiF5lDwXV+ESbNEW/fCQVrWkimJ+WTRj/a2v cnvASVT4zujztBYqZLaWdoyT5UtugtlgMHu1vErwY/h6UJ7EOXfY2GkMju78p2c943UA 9fvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=Hf4b8kKe8+zCps4bUNp1ug1RGqjC8xfMz7Zwk5whBzY=; b=AyiKabF2ij9PGFczxsY5b7J479frUKACHbtHSTsY2YN7XC0mXUndvAVXm+1Q8O51bC IoNLMA48EdSXWukPC3G30tJk0yNOz22cxn66J0bU58A0X63u8Jnsm1qW8zQIkwFTZX5U GTeF5O+9PeQqs1HezdsxAIwyGdSu97QCPBUPRKex7ePmULwIH4LDZCwF89hayGDF60Ev YSKe7q8vPUmQNmK2OShfBsQ7fi0EX7Eq1EnLlMEaczed/WKrTRiWGT+wZMNA+altqU1L YzhmwStJdXQPt1hrsvrDLiV7XNcVWFiIOFJ5kRmiKnJQ+nweLNSveDLwQ5grBNkJPaZd 7zlw== X-Gm-Message-State: AOAM533ehnTpOwq8wZ/icFYX83f/Lk6aKfDNYlrmuF5MWBP1rnEqo5wq NVHYgjS17yAHoq0bWhAYGiE5QA== X-Google-Smtp-Source: ABdhPJzTy3uY3MsGRvf9gr6ZiLtxFolfbghsfX0P0tg0lphiVjDFB8SoshdeyFzPIztuf/eqqCYRuw== X-Received: by 2002:a17:902:b10b:b0:134:de66:4f8c with SMTP id q11-20020a170902b10b00b00134de664f8cmr1419984plr.66.1629947073848; Wed, 25 Aug 2021 20:04:33 -0700 (PDT) Received: from [10.255.175.44] ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id e18sm922154pfv.172.2021.08.25.20.04.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 20:04:33 -0700 (PDT) Subject: Re: [PATCH v2 1/9] mm: introduce pmd_install() helper To: David Hildenbrand , akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, kirill.shutemov@linux.intel.com, mika.penttila@nextfour.com Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com References: <20210819031858.98043-1-zhengqi.arch@bytedance.com> <20210819031858.98043-2-zhengqi.arch@bytedance.com> <324674f0-399b-aea4-e9b9-fe054a926fdf@redhat.com> From: Qi Zheng Message-ID: <4154bc99-e9c9-d194-dc07-577b9e5131e8@bytedance.com> Date: Thu, 26 Aug 2021 11:04:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <324674f0-399b-aea4-e9b9-fe054a926fdf@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=AdhaKecF; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CFC0CD0000B2 X-Stat-Signature: y3tkdsegwtcchehrihtwi4bqofanj84w X-HE-Tag: 1629947074-229845 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/8/26 AM12:32, David Hildenbrand wrote: > On 25.08.21 18:20, Qi Zheng wrote: >> >> >> On 2021/8/25 AM12:26, David Hildenbrand wrote: >>> On 19.08.21 05:18, Qi Zheng wrote: >>>> Currently we have three times the same few lines repeated in the >>> >>> Reviewed-by: David Hildenbrand >> >> Thanks for your review, I will add this to the patch v3. >> >>> >>> That's mostly unrelated to the remaining part of the series and can be >>> picked up early. >> >> The implementation of subsequent patches depends on pmd_install(). >> So I am worried that if this patch is submitted as a separate patch, >> subsequent patches will not be updated until this patch is merged. >> What do you think? > > Usually I tend to send cleanups out independently, and then just base > the other series on top of the other series. LGTM, I will submit [PATCH v2 1/9] and [PATCH v2 2/9] as a separate patch series. > > I'll have some more comments in reply to v2. It's fairly hard to revie > because you do a lot of complicated stuff in only a handful of patches > :) I'll try to think of something reasonable on how to split this up to > make it easier to digest. > Thank you very much, and I look forward to your suggestions. At the same time, I'll also find ways to organize the code more clearly and concisely, and add documentation to explain the new APIs. Thanks, Qi