From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 514ABC77B72 for ; Mon, 17 Apr 2023 11:15:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD88C900005; Mon, 17 Apr 2023 07:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5FDC8E0001; Mon, 17 Apr 2023 07:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27F0900005; Mon, 17 Apr 2023 07:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B3CB68E0001 for ; Mon, 17 Apr 2023 07:15:24 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C5371604BE for ; Mon, 17 Apr 2023 11:15:24 +0000 (UTC) X-FDA: 80690626968.25.F77595B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 612D4180010 for ; Mon, 17 Apr 2023 11:15:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DfF/JwDR"; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681730122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dK3YDQscuz7YARntLdvlf6Mm4uVD1HP03aUvW3aEuQE=; b=RmQZ7Bey8er2VxucvQgdfq2Go/M5hLY98HCUFiSMCIh7Tg8dofimLFUnm+52RhCRmYuR4t E6wfIGVw7Nl7Tnhbj53O2gXa3vC+iEbSBC5lSMRS5D5QSun7C+YhBpckZ2CljpzAX0bvOg +TS1BISpjcSMqX3h1bq4yXS1nFouxlw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DfF/JwDR"; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681730122; a=rsa-sha256; cv=none; b=5afcaZ6jPe0QMXHvK/T5VV7/OC3GbmywGo7rShwgPpTD7lOfYAJOMFplHReWLNTw1m4OoJ y5I4LM35W6hHiRFLDAbE/pWU9qItnuiYSf8qMesC3dTmC50ae3vvkwzgsxnz00RKEIGqzN dSi+hkL5SRNsNvE04zYltgKUApO7X8w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681730121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dK3YDQscuz7YARntLdvlf6Mm4uVD1HP03aUvW3aEuQE=; b=DfF/JwDR2Arv+5TWsLohR7Fsc/D3NtffS+N+6mR6dZju+G96haThiV5uQLY0EbrzrM45o7 8ci9MuKPBLGAznk7yHIpkChao1wERyFLDrNBH+fygJM8chgXAvy8RODrKqI7ls/9vdxOzU iHxMKRL9G8rnXgLpR4XjF9UNMq0dAxI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-UPiV4Py7MveOH4uGlOuOow-1; Mon, 17 Apr 2023 07:15:18 -0400 X-MC-Unique: UPiV4Py7MveOH4uGlOuOow-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f08900cad7so6550215e9.3 for ; Mon, 17 Apr 2023 04:15:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681730117; x=1684322117; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dK3YDQscuz7YARntLdvlf6Mm4uVD1HP03aUvW3aEuQE=; b=WId9x26mr8ucAFCbM/5kk86Zu/k/Ffr6bCJcd1xjfE0h7kt44MWuY4hpYrB4eSae43 sRZaqNt0o8q/Y3XBHJm0g9C99aUs5epUsd1Jf3DeNwVYiNfTNtEZtx6AuxIzVNE4wz7t 7tpSwMjRV/pP2DHrXRqy9bS1U8SHq1ItHpYwvEClAezsHtFNQTKllI1kFek2aFiMI5Hl YYcx8YpP8hxE/X52ZcnfHAaJEHywksn+jeRT5zTu0ggQ2EOd1ss19oa4PJ/jK1O/YyiE X/kKTeg+OPRWH19/hKW2HbbfbrXhIy6DxGPwW+MEiGEyBNFRrTtkKcrN6DvqNMVMeGCQ JIxA== X-Gm-Message-State: AAQBX9fEbLfmjOLJ+jH4ItqoWtwdhKSXyWA/LKNYsWsLGqMxg1k3hSXZ 3WGO/PCsgKzzDNDQ95nAH07lQ2lqk6sCaXExvNWJUTEnSTWAEzo0dQUxZ8MAK9oKtc4cq1Vg0ds b0BRxxn/rTjY= X-Received: by 2002:adf:d4c7:0:b0:2cf:edd8:12d3 with SMTP id w7-20020adfd4c7000000b002cfedd812d3mr4920044wrk.66.1681730117465; Mon, 17 Apr 2023 04:15:17 -0700 (PDT) X-Google-Smtp-Source: AKy350ZPingJuVUImVb5bdJCXh3X5iMgw5vkOxKMjXUaLY0s0KRuA8IYcOK2uyIkVl4uUVkDE5Dlpg== X-Received: by 2002:adf:d4c7:0:b0:2cf:edd8:12d3 with SMTP id w7-20020adfd4c7000000b002cfedd812d3mr4920018wrk.66.1681730117168; Mon, 17 Apr 2023 04:15:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id k18-20020adfe3d2000000b002c55de1c72bsm10258441wrm.62.2023.04.17.04.15.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 04:15:16 -0700 (PDT) Message-ID: <4150a48f-8c6c-4631-d61a-abbd0ba83eeb@redhat.com> Date: Mon, 17 Apr 2023 13:15:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 7/7] mm/gup: remove vmas array from internal GUP functions To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , Mike Kravetz , Muchun Song References: <217d9369b15d657128746beeaf6d65c03214df42.1681558407.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <217d9369b15d657128746beeaf6d65c03214df42.1681558407.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 612D4180010 X-Stat-Signature: 4qpwzbj8zqdt9iu6gk986m8rkcsiod7g X-HE-Tag: 1681730122-475621 X-HE-Meta: U2FsdGVkX18MmLXu53Ac4mPC1gNQSxV7yT8WgPDbZ06fMNAE8eFoadikQ+VgS9iZR6C5osUKC1HqcpCX0Es9iuoXaav99PoOMwgNTGdRLWRremoE/xOnFnNKLB+ZjhdL3VMYNhvpxYBW0opeoupSoeDR2f9WbW/IFfzxDIs1kRA0YakdPLZiJ76fN01F2Nfw5e5umBwrmFMBadbdHy2nD7Ugh8hAfQ0Y12r+RLQIuwUR5KNV8+EoX+ys38Ehvr4hk8ziYoQNxYES9WBBUlvmDB+ZtbOv6Rg8iedqGJ2Ccs2S+EzsAAdMDnKVGUQRDUAUNOR9VMmgYyG19R5tRKiaSIXetUXbPl8CUwj8x1FAwFGPhQ6myriancP6b4g+MROn6FJtWHhaPTXd72tVy5cewYn3HovoKKVwVayaM4kUdC6lE0myd+NJEtVvSgRNWskUv0uFlGESmxYPrrfBl7gNeGuPDBrsKvZWC0Thp1cZN/UJoEoMnjdAbOMZO4gEJTFLajhmalGgmGslSkz3zTLHVbY0nQAs3CTpC4d4MKyDg3iq29qYLlbFcrIsjDFboSvEJjzUeVWyLefKOhKGu7kR38sGFI2/UYF7CU+PH7GPg+jRQJVb3qTytm0Oi5WY0jIrpJBtsWzBBwmk6p/cmyqNTL6BSOVIaUjgaRh5ZDCM6qag7xS5DsClokSMcNC/IjgV3RlEkFuZ6EVKtSSyDb4Qrswozr1WYar/DEmXRAZWFEz9oKCwfIifax1LSsAIFiLm/4CtuqdlSzrOLNGbnxLPBE/MEUrWYYXsssXBVyP2XwnjAw9xyq56vtKHVPu38neOQYvyjDrX4blJts6LcGcLjWv6bo/Y3t7ogSKc57QWS58evc6O5goqfK67s74ahBtfrcBp5hzQwIeD3Epud73fwyhRF0i/J/XzV5Yghgw/tikOf66SqMe1v2AJQSrJaHn968y1OvMS7jHpeOZG2QA 8UKWrDtC ePViFIBBLnB6bAQnPMUyd9RdL55MLg0pmyKyw4AC1AK/kH8ZuvuJfko/fVyIvK76wV1yITG2VOTW3pgQ/oZ25oauWbDm7ctxJrtsL2NWJ8IeMrKZ6aPufZO9/YZTUdsvVqkxOSVocu8A4VCdw0joz7lWKPVzAn030KcWSyRxwfj04qYYI0pRa+do4PrNB8l5C7+d6Lq7mgOM15Mj8KBUdEoXuprcTRn8ufLMO6rRe6mpkdTYtvZPUzvXM5jd59rK0S1KGtsrmsQAIHH3mZFakAl2XIyRFBAZksJLMzlZO415fGmWNhJ8PWbJ3XyDCHTy27PvXjovKYyC4TO0vLXOETGgFQOAvcwydiHYss4RmMsWvrx3W2G1PoNrE7/Dg1nG+Ff+5nifX77dfUOlgRYm+MjpA82cC9wHp29MZNPRFiBwfE7pXB+wMHoyz0hzyuimKe+Y1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.04.23 14:09, Lorenzo Stoakes wrote: > Now we have eliminated all callers to GUP APIs which use the vmas > parameter, eliminate it altogether. > > This eliminates a class of bugs where vmas might have been kept around > longer than the mmap_lock and thus we need not be concerned about locks > being dropped during this operation leaving behind dangling pointers. > > This simplifies the GUP API and makes it considerably clearer as to its > purpose - follow flags are applied and if pinning, an array of pages is > returned. > > Signed-off-by: Lorenzo Stoakes > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb