From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CDDDC83F01 for ; Thu, 31 Aug 2023 09:50:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AAC08D000A; Thu, 31 Aug 2023 05:50:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95A6C8D0001; Thu, 31 Aug 2023 05:50:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8493B8D000A; Thu, 31 Aug 2023 05:50:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 74B788D0001 for ; Thu, 31 Aug 2023 05:50:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 40482401CF for ; Thu, 31 Aug 2023 09:50:47 +0000 (UTC) X-FDA: 81183930534.15.E0B4A96 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf06.hostedemail.com (Postfix) with ESMTP id 5048C18001F for ; Thu, 31 Aug 2023 09:50:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kSt0U9Ky; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693475445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4hWsSdZV+d/r/C3M//CWRHenhxuyH6PXWTZ8m4C2T5w=; b=tT3WqJMSoUs2NmdxS51pxz1rIsUZwrh3LuqnguGr03GzqwX4TU6BdyTz7nXZf5ikPdlUeZ oir18xhCMiGdtDtS/CvjaVe7w0Ww+3thRPo9UqqzjtdqozXk2HkO4J7BtvU+mCAL9k8Gs1 bfiU4lhNNczeyLkMBBsTir2nDL22kIs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kSt0U9Ky; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693475445; a=rsa-sha256; cv=none; b=bI+B1R/ILhjDWIMQP5B+HcHaTGby0TidgqPbkpxpwbQqt0KLYDAOwZbRjmRD6g7G0d6qSB Ag3gSCF+hr7goYfzL0p33HSr6Uj52BA3pjUSxexN1wHVCAh/L9l8eCfjL2Lzybe10eDEUH bsqSjOS7EJ0stm2wuzlMNPoTD6iiIF4= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1bf095e1becso495865ad.1 for ; Thu, 31 Aug 2023 02:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1693475442; x=1694080242; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4hWsSdZV+d/r/C3M//CWRHenhxuyH6PXWTZ8m4C2T5w=; b=kSt0U9Ky5+suoKr0ntPUI20Ixmr10MedV6vutASN0FmY/IbthAuMYS7nSC3lwHz2iX pVYsZXtSCmT55Qw9AP0OePlmzhOp+3oVHab0JaJUpd/z0bXgKCzWYATmcflV5cVbYvVb IfFILBP5dTfJtWn84skYhfH6RjiJbLiL5ZoZ0+wpVLNV2VaC+f+/G705p6xCzQB715Ap Ib6KmnPsMDMWfNmMQpSQlpimJjjmIuKYdm780Z5i+G0dBgzeSQInWYs4MVgbjpJZRTu9 MIU0oRtzXMrW+VvcTd540MmUKJ25t+YcbAzbljn4GTrLGb6TpNh5l6NEadQGpfeg6mEw UAxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693475442; x=1694080242; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4hWsSdZV+d/r/C3M//CWRHenhxuyH6PXWTZ8m4C2T5w=; b=QRreLoG+K2Cs1ReMV0wUnvmyico9kMkCQUQuzfBAlZFx7Xvu179sjiExgx/B+rQz3z dOwiuAtA1OSSR3BSzn2TMsNefX8rFSvJoMIrGa6tDCJ09er1veryHOMbyOzSR0owi1MI 0H6qTpmOiL5cB0ao1dYiv2LvjHa6j3eRvmFvECBTjp/XbFWbHyk8Jx+8ArmJq5D7f2ug e032ylPzUnBaUL0E7YX4opolMS2MvIG9zjX1GAfIRd+geywTtgecgd6wVbdqhTQ5WarS 2dwKXDDH8kHKDzqGZc/OBa5v57iNK77i6njmv+pD/rKNaaCm18Wq2xtkCv8eFPI9zStw 3OAQ== X-Gm-Message-State: AOJu0Ywxkiy+UhTF7DVeXAGCYJtlEWnzP0jg3rT03DF4TgedctowYFCY The1OByvnPJooIRRr88JvL3XOA== X-Google-Smtp-Source: AGHT+IEnkrf0TI+aDPgBrUJ4hvYx5ldH5fkSZ7zbguENseaBUxfSfJnXVG+gK4GUU5F65oVTA/ERUg== X-Received: by 2002:a17:903:22cd:b0:1c2:c60:8388 with SMTP id y13-20020a17090322cd00b001c20c608388mr4731256plg.6.1693475442668; Thu, 31 Aug 2023 02:50:42 -0700 (PDT) Received: from [10.84.155.178] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id jg7-20020a17090326c700b001bbb1eec92esm893971plb.281.2023.08.31.02.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Aug 2023 02:50:42 -0700 (PDT) Message-ID: <414e5087-921f-4f80-06cc-b7b894fd3794@bytedance.com> Date: Thu, 31 Aug 2023 17:50:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v3 0/4] cleanups for lockless slab shrink To: akpm@linux-foundation.org Cc: david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, joel@joelfernandes.org, christian.koenig@amd.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org References: <20230824033539.34570-1-zhengqi.arch@bytedance.com> Content-Language: en-US From: Qi Zheng In-Reply-To: <20230824033539.34570-1-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5048C18001F X-Stat-Signature: gsoqkdaptxw3474ybx9kzjcopizfnn1j X-Rspam-User: X-HE-Tag: 1693475444-615376 X-HE-Meta: U2FsdGVkX18cllOv51ON3a1n3eylYQaW6GDc1h5hvsx+ZfYoiNISKFFPmNsDCK9SlA/zG4HrbdxNAFTTVox2ks8dHoCf0kJNKkEaOBSNnxRYEmf3S3KvXsJSemxamiCYLgVdOJCxgaWvkA1VEn+PagcNe9nNoTc2R9iEotxaCb1/j0ACGPH5gqghGOq7TlSjS9j4avXC/B5/dkPMueubE1wrpMyxxiceDUIGvnjMwb5uh59xulI+LmTyDDeDN64WI8MLtn2LUO/+FdVyBNKvqaCvj67H3cUic95ASiL+kl+pCYCRo12j55xp6H7ua6zQRUnuWvzqzO+TXKHOpbGLxyVGlEcKE99zQ5sYuCxfkT75z5FadMcUUDSjGcooh2MIZGF0K1BMJbHW213BipUe64y6xMN0UwUVWK+VLKBRj3Jh9POh3lTw20ZLRy4bkbuHP0Qf/ajB8dkPg+rXQH1imVC5hUHu1La4X84gzMpMRPzdYwWJWd4qQitm4gjEA+rF65SpJJJnv7NgE/oFx6dSSeYJnCHuAD6KL3fDPzYLWZqp2DOMvFUjqzv8AM9i+FwhpyHC9OmaoHQ3hA7DipKitEzmbuEh9KtdP87E0PgbgqI/lQfcb/gpCpxQuVe3mrRhboe6G7OmOSHpHA6bGP844j7Hzdlb7O3uzdoLXW71cfTT4TE56FMuwos91WzTrjSBn8O5/t3F2gsgVa3TsPkuxAfALYrdbOqNnymxFGY++YGxYTcezmhZNhsTQjadONuRQ5nR2DC+z6nlUJbdwu3M+koRsw9KOnZ/g0FrPocnCY4FTz+I6OI1ap/RwE8KiKli8voU9B3qekiIUaEn1hVijqm3gyeCIvc7HLjn+cpJAqzuK+pdrejIubrT2NWhdA6eSvjEKX69NTPQvQw9hNFY87WzEjRNAIkgep2aF8UkFbccuLnHU2q10QHnH/QLWAFeH1vtAvY72qCZIVMsqwK i5yRKpSf MS9rm2a8iVZuP2TWheDvKoBWi4nCAJBWh0syo4ufcF90a/o2BRc/sTb7OPTOuWgQ9xyihPaGd9h4Dca7drvIdHMee/I5Rd+2EsBiFKDG/o4WqgXgZyNrO+M4b4bCIDiZL5xeejB6ydQYYrPg9R2EgDJL7A5XZCChYRX9wglc+0t+2teuC8QcyO9PQahse2HMVoYpCQD4tf77QqmgD6GQhFEl/79sG73Z9A2oudXMS6zlFR4pCXO6S2o5RVonNwo33RbQxuGZU0BT7tCK95UzBLfuH0tZWkmbD+F9VBxFWAWksD9JJOrLWuHISwhd3hECIklzBZSOEJAlJIkOgY4KfBD2ZwKwXAIChWkGDBlP1fujwMBLwLLxd1Fp4kY0mgrXQh17mmw7cc2/MA9cLAqkiK8PcJlLyLj82S2iNCJZ0dxzQuX//0Qwb6AGObCv/YivYFi8xLbIu2RQ4nW+1C0mIE2Z3Ouv2DCg+ZtmJaMxaU1mqilA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/24 11:35, Qi Zheng wrote: > Hi all, > > This series is some cleanups split from the previous patchset[1], I dropped the > [PATCH v2 5/5] which is more related to the main lockless patch. > > This series is based on the next-20230823. > > Comments and suggestions are welcome. > > [1]. https://lore.kernel.org/lkml/20230807110936.21819-1-zhengqi.arch@bytedance.com/ > > Thanks, > Qi > > Changlog in part 1 v2 -> part 1 v3: > - drop [PATCH v2 5/5] > - collect Acked-by > - rebase onto the next-20230823 Hi Andrew, Can this cleanup series be merged? This part is relatively independent and has Reviewed-bys and Acked-by. Thanks, Qi > > Changlog in part 1 v1 -> part 1 v2: > - fix compilation warning in [PATCH 1/5] > - rename synchronize_shrinkers() to ttm_pool_synchronize_shrinkers() > (pointed by Christian König) > - collect Reviewed-by > > Changlog in v4 -> part 1 v1: > - split from the previous large patchset > - fix comment format in [PATCH v4 01/48] (pointed by Muchun Song) > - change to use kzalloc_node() and fix typo in [PATCH v4 44/48] > (pointed by Dave Chinner) > - collect Reviewed-bys > - rebase onto the next-20230815 > > Qi Zheng (4): > mm: move some shrinker-related function declarations to mm/internal.h > mm: vmscan: move shrinker-related code into a separate file > mm: shrinker: remove redundant shrinker_rwsem in debugfs operations > drm/ttm: introduce pool_shrink_rwsem > > drivers/gpu/drm/ttm/ttm_pool.c | 17 +- > include/linux/shrinker.h | 20 - > mm/Makefile | 4 +- > mm/internal.h | 28 ++ > mm/shrinker.c | 694 ++++++++++++++++++++++++++++++++ > mm/shrinker_debug.c | 18 +- > mm/vmscan.c | 701 --------------------------------- > 7 files changed, 743 insertions(+), 739 deletions(-) > create mode 100644 mm/shrinker.c >