From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49AB2C77B70 for ; Tue, 11 Apr 2023 17:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB899900002; Tue, 11 Apr 2023 13:49:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D69606B0075; Tue, 11 Apr 2023 13:49:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C30EF900002; Tue, 11 Apr 2023 13:49:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B4AF96B0074 for ; Tue, 11 Apr 2023 13:49:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 80C1DC02E5 for ; Tue, 11 Apr 2023 17:49:52 +0000 (UTC) X-FDA: 80669848224.20.7F9DD01 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 3DDD0180012 for ; Tue, 11 Apr 2023 17:49:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JSS2wtNw; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681235390; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ef8XnWFgsT04MkS5RM8aidy/rRVFyqx0755dVLzx4LY=; b=zJ7pLm+zFVYjm4HyYXmPnpJmpH5JW1SiDYSTSoAN5AdIpyeXraCqP5EsQbPOp2Vk5JV54d QJCPpMbzOqd/TDJZxxeepFaFT+62+Tq9RrGRRWzCzpFcyKiDdOEzrbcmnEXxNis54cwUPn DnT1CRafrP2iLKBSkjgmJLRqnEAVYGA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JSS2wtNw; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681235390; a=rsa-sha256; cv=none; b=K8yYXlwGBZzs0c/QUBoPLdKNgqwRdChGfPzaVOvW/zs+5KeQ2RJOiJxJlIWB4/C/gW+xpS 6m0L7S2bApcS4NNO8QzXAIg3uHGPxQRqQ3TcAUmW8iqQhDINSXijbTQ6DyRr4m25z1YVXW /NYQzJ5XedkVKBC2jN01gB/UwL1rLKc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681235389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ef8XnWFgsT04MkS5RM8aidy/rRVFyqx0755dVLzx4LY=; b=JSS2wtNwBjpDW4/eTbDo7W8AroW9229ab2hLCFK9BVIER3WlhAW+1I1w38esdrQsrXlt2A E8KYYEqyAvW3q46NiORGAIb3mB3LokKjXY1GLI3ZFC6lbVlu3IHP4lsMTpbeoGtDCnlENO lQh8a5GewIeD0ubtKUNaVPiM8c0qiCY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-C_cXOpSdMASPjUK6X9l8Jw-1; Tue, 11 Apr 2023 13:49:44 -0400 X-MC-Unique: C_cXOpSdMASPjUK6X9l8Jw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 668D985A588; Tue, 11 Apr 2023 17:49:43 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57602728FB; Tue, 11 Apr 2023 17:49:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230411160902.4134381-1-dhowells@redhat.com> <20230411160902.4134381-8-dhowells@redhat.com> To: Eric Dumazet Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v6 07/18] tcp: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4138302.1681235380.1@warthog.procyon.org.uk> Date: Tue, 11 Apr 2023 18:49:40 +0100 Message-ID: <4138303.1681235380@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Stat-Signature: sp4yxznbpux6zhaedky3afrpwhjyi774 X-Rspam-User: X-Rspamd-Queue-Id: 3DDD0180012 X-Rspamd-Server: rspam06 X-HE-Tag: 1681235390-294301 X-HE-Meta: U2FsdGVkX1/KK3PMuvqD8DOcEtI/x2U9ZVmm/+1hBczqCGOqALPPtTavl7VsMn5dFQN/QbOCw5IhwLlzyU0UEmFd49hven1MhTzEbigNL+P8rjJnAPQDZyfMfyQo5u2XOboX+Rtjs9Lsz8Zz2fH+Z/+loKQqbfHEIlQD8qPX9yOTrHAHMcdlZ9gXrFqB9888ZKCphhZedadycefBFx+LdJBJ5edyp+9TGFCnw9nwP61U7zcVSsA3spZcYB+hPR/TxZ2rBnF1nJ+IMvmA2YZk9ITmZ/bBakzbjSYO8egC+rix5hZCgr3LaKA4/JCe65zpDvmwOVGvkKU3mz0CYEfj8pww5pLHzUaW1sSgFltvJQe5cP0FgcxkM95KVsiZ+6+QcZ0+w6HCvsN+aRaP7ahnGf6/5JBwDxfVakAqLUnpdmAjIYH2IlCReR+9V/eAJkuyvsCqCCHAWyLIYEepeoLfcdZ0PbPL1rSYB2qBIZH9diGnNnlFzk9rfT1fGaLtGQBmSfklulQCBuN1e1Iz7YVH/CxAyzljdUyDblp0n2L0afXA0J8BEK77MvlZWj9swBwWhmRH87C0fCjaNIslOAxcusE433+CVCw87QbkgpQ8ITnrrfE4PQinhQ/043hZx5AMKtGfmo53TW6VEWfVwNNv+I5JUDC76w4TxZpUcwMskmSV2hQIAZohVNlgqjgMvij7ig+kT0TC0rxdujC2yTJvWMy5/SzBaVcLc9g54B4wzSljystAYoFuaaX2d85jkh2rudjwHM4zQkAfYW3ML2aLu4rQv9oREpNTT4BZZGbvNezcAAvOqyYYB5HCqbtUM4lEtGB7Im5iOWe5Yup8anEIxNyXLaW+EwuCOMOqrDbzOMWLoqrz9dtmwwRyFZG1Pj7jxQVpDH1AY4OxAIss/FNvxKtgypV/5EGKA6ZcgFXyQo3dG+0Z+63Pu7hKVctD9ZIq3WtEE4y+4Fti++w3eKY lxQGTl39 lv7d7UAc90RctNPybIRPmuyG10o8G2wd+6evTOYAeVOcV1WKu33VrHEgcYbfQH4ubVedc/Ylj+cMs1OVNMbi4C6DAh9FCKSBcItqoKkxDWDpYjMNjOWioD5BLC1OjuLRc0u52CIAnJ3Kv9QM+ZOoSSXaqSHUY/v7XF31J3vmQCVKLNJtbM2bsWh9BtgMbAS2Od/wXR1p+rfWxsUFw0HfG78TvtwpYYCG55235EGz8imf9xYmzCc83XQ5OFqZF/+f7/v54IeFkjYLV1vkwlhy19MBeO+eGabSF8PICLHTbEbNnVTuh2qXLy1GNpjT3QhoW0V9p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Eric Dumazet wrote: > > - zc = sk->sk_route_caps & NETIF_F_SG; > > + if (sk->sk_route_caps & NETIF_F_SG) > > + zc = 1; > > zc is set to 0, 1, MSG_ZEROCOPY , MSG_SPLICE_PAGES > > I find this a bit confusing. Maybe use a private enum ? Meh. That should be "zc = MSG_ZEROCOPY;". Will fix. David