From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DE0C369AB for ; Fri, 18 Apr 2025 10:38:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE7496B0006; Fri, 18 Apr 2025 06:38:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E703B280005; Fri, 18 Apr 2025 06:38:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9B476B0010; Fri, 18 Apr 2025 06:38:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A57566B0006 for ; Fri, 18 Apr 2025 06:38:40 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BE8BB161A47 for ; Fri, 18 Apr 2025 10:38:40 +0000 (UTC) X-FDA: 83346816000.11.36BC3F1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 932CC1C0002 for ; Fri, 18 Apr 2025 10:38:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bf0BU9dw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744972718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/aNfSyhKjVQEb782o1IDS6xvFTRwJ4+tUGq3ftPoOh4=; b=Qwb9awCXgDVaAXz2JpH527w3AV314fZtUhmngZrqeIeunPVru20jdanW5c2EM4RBQ7ntYa /6rjNan3VgvPiTr+uztF28gJnnIrUllAew4rU1R2d43PFKtDY0uLvYFKaS5AH2xpsshbmD aYiXEwU5QZ31II03YAtYIoUzdpfSskY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744972718; a=rsa-sha256; cv=none; b=eH/FFOf92AoMpj6YQL7m+j0JqJUL9z1ESjouQuTlsx8R5/HMgOIchk/oZpnic5SUVP1sma wLyAvm6ym6c4YgnO2z79LJAQpAHkRvMVd7MOoZnxqB6gLQkTVFoFh0yPLfpSD7xcD2HPfr rakND+nyOZS/24F5JE5HE/YZDhdLB5s= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bf0BU9dw; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744972717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/aNfSyhKjVQEb782o1IDS6xvFTRwJ4+tUGq3ftPoOh4=; b=Bf0BU9dwm/3bAU0ohXsmhgq6NvHeykvgrjoMrL3kk/ok0qaU84ZEMN8mtgvSkm8ZmhhiPt cED/iyTbQfD+CF3kPA/fsXybnEoU5hP0CrGc+dCr8T9+ldCTDu4SqqbA9V8rtIsYb1YfWO ls+7NmTi2zqv5FBcTurxNj+IzLzg/Wk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-501-RkR_MWkROq6jdbxvfC_uyQ-1; Fri, 18 Apr 2025 06:38:36 -0400 X-MC-Unique: RkR_MWkROq6jdbxvfC_uyQ-1 X-Mimecast-MFC-AGG-ID: RkR_MWkROq6jdbxvfC_uyQ_1744972715 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39126c3469fso667698f8f.3 for ; Fri, 18 Apr 2025 03:38:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744972715; x=1745577515; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/aNfSyhKjVQEb782o1IDS6xvFTRwJ4+tUGq3ftPoOh4=; b=JZ7qnW8gbkIBDeDVGIRByzYDBsoJ660XH08AbknXsAzccJ6uVUVMVIvjmPpRj7Jw7Y tjz/5/xt4ekBPX18tzrt58xBZysihm1AyIE6SUauM9JmleeBrAf/8HVFIl9lQILZ4b2T 6NVMZ2eBVwGFQfiL1GWT6YKnkZC7H+xNh7O46uewDEibDY3MNksLy08rekzcRKJ4KmmA ALkBEaRept/E2TnHp6u8FA3iUrI6rD59NlWmkd1TRbxvtC8ABrYLXPYpwLfpjbtPbyhN YSE132D9CT+szd+nfmPAESsqr6AbhL3yK39qR0CDfqRIvBXjlDESHGIig7A7exuWLIP7 qQkw== X-Gm-Message-State: AOJu0YwSomhU7Nz8ZpilKcwDcaF+wmn0KRuJwpg7Qt8yLgfvecFRu8x7 ZrXXuoGdlTlDuz2Fmv7vUlrO1wQMY7aR6gL56qaoyxMOHt9xbQ4XNGBzQVY/LolEYwMAsn0/gxQ FYTTS09R7NsEFmEEOEH6AdYLmcH0THa8LdcBDQYASgVz2zpGq X-Gm-Gg: ASbGncuyOgCyZz9z0Qkda0PjAL2Me6sxqG5+x6LLPk5we4++ouTNHA7K6DHdjrqIOZN XK1ELEIxe66h0DQ2RYnbLhjEfFhm7+zzeHwDWFX098YUO34guyJugG9zfAjkL53Q+hDafe5miWY iPVddrN5Ysyq+CLxd9LUdixyQHbw0zYsfLwsFV9lLeouVMVIhy1a/afTNPkBYkY4pR+16dsDuYP /hibLa/oGlbyavrwekiHAqoxEqXksMU96eUgq5lk/DMFnK/4ORn/5JarBctRtxbfiILaprDGllS KYpKEHI7j2VkvSTmgqYZIqdA/mwHqJKy32mEQ+5Ur8dF9YdhBwd3lj7Gk66GRbpFUoZUOJungiu cZh9tBeQ10wcaATC+OTpR++/nIjHDVj6DhzRYIUk= X-Received: by 2002:a05:6000:2911:b0:390:fdba:ac7 with SMTP id ffacd0b85a97d-39efbb058a3mr1764673f8f.51.1744972715057; Fri, 18 Apr 2025 03:38:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEdldEs4oBZMIiplVdHAWEDG5nshhWWpBHcNSsUuHWTg/9jYidiZpEKN9W6zNrB41wlwJ/xDA== X-Received: by 2002:a05:6000:2911:b0:390:fdba:ac7 with SMTP id ffacd0b85a97d-39efbb058a3mr1764657f8f.51.1744972714714; Fri, 18 Apr 2025 03:38:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6700:cada:5396:a4f8:1434? (p200300cbc70e6700cada5396a4f81434.dip0.t-ipconnect.de. [2003:cb:c70e:6700:cada:5396:a4f8:1434]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4406d6db10csm17021015e9.27.2025.04.18.03.38.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 03:38:34 -0700 (PDT) Message-ID: <413657ae-8271-4a5a-9507-e9161d1f08c2@redhat.com> Date: Fri, 18 Apr 2025 12:38:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() To: Lance Yang , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mingzhe Yang References: <20250417124908.58543-1-ioworker0@gmail.com> <20250417150237.ba3bbb3f55f992c692932841@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: m91Ap9qkQMvMtEzVi6qMeaOfN5aAVbzl-N53B13KYXw_1744972715 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 932CC1C0002 X-Rspam-User: X-Stat-Signature: kgxy7xohrrmn4573nmffg75grx5stwy3 X-HE-Tag: 1744972718-409874 X-HE-Meta: U2FsdGVkX1/359SB9/Qf7wMb3fA90x/XAAMCKpBccodpe+1Oee939Pld4oSR9fRu42BG5vuhOwTykb3cDbfdoBS9BR7vrTDk4g9qFD3K7TyegPm5SzXae+54fpTBY7kWKSzjwwe8WZILhbB7Zs6+MJ8MzOxgQe6wOso09VTdC747FEbnWsPcTnGSe1qSAteXsEY9PY8qaAYu/3Y+COHXpaOMNIUPVDLAFHMBSmk7xz7fOV/detx99XG9siArbygD2nMyAnH5x1S6U37mDDBXpmSIUKqYPWEgnEM5YOZ2VCOnCMEPpL0+uIc9sbsL5FDFgQmhBAv5z9xdHZ63esyukfAzWuiamtiKW1IakYBv8MIS70M4T6gJUmyrd5UyvXjc+MsW1ECbskFdCv7Vg2uHKyLsqt7fxUfqp4/Mfnt1oW4CKpaXDf96ddMOOit3ZtyWUlXy5JKyM0GUIiCIfjrQ0ii16zAQmkwozK5UJCyPb8G1/QLqEYWWvrADvPtjiQT3CRxUfCCyb4mvIXrYQrwXgJ+AEem0eHEQxTq2WU6uUWMMRPfmPoJrJZXD4DjSmoJxcA59n6IjIUfRqLZWhuV5tWKsc5u/Jyd57LyHnB8xoqe5ROQu6LNqm/a4A8YkI8ZYrNEs9/JfBfMGJgiRA1TLdLvg5Kn0xStOOY/IVEBfUV+zimUVSDLT9GpRux2xCQnVL44InJ6ypBuY6Qtyc6faz8MRuyLisGud/63IEPAGyTj9HhXvjHUhmbeA1nwkwpOWH+6R9kqqUOybdo1sqLH42vh/Xptye8btlOgTrXVgKXuANhdFNVZeZevtbaWD4bhOme62sop1AMpZr+gOY42k4tN4ibGYUz19Q15DLPxYRBrL5hZjLt23ouit4wDRoNGu9jF6GA/x5XIeKvsOECdUH0nJfEDehZRLP2b1UWgZSLl8t01+QdGNe4+53OxMiZM6sQWXUcJzHr6+1zu5CMM bKJbe6Ap qOve0/JX8lFJ27clTzcd9qb+PcYxfQfoJQ1/s1BHb/z1TCn9gGqli3+d2/ezjmt65ZqTNx8JPemNJmfI5027Jp/bSBP6mYRaNiozWfqNmJy5Rst6215IF8IJ6vA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.25 09:26, Lance Yang wrote: > Hi Andrew, > > Thanks for taking the time to review! > > On Fri, Apr 18, 2025 at 6:02 AM Andrew Morton wrote: >> >> On Thu, 17 Apr 2025 20:49:08 +0800 Lance Yang wrote: >> >>> Add a compile-time check to make sure folio_test_large_maybe_mapped_shared() >>> is only used with CONFIG_MM_ID enabled, as it directly accesses the _mm_ids >>> field that only works under CONFIG_MM_ID. >>> >>> ... >>> >>> --- a/include/linux/page-flags.h >>> +++ b/include/linux/page-flags.h >>> @@ -1232,6 +1232,8 @@ static inline int folio_has_private(const struct folio *folio) >>> >>> static inline bool folio_test_large_maybe_mapped_shared(const struct folio *folio) >>> { >>> + /* This function should never be called without CONFIG_MM_ID enabled. */ >>> + BUILD_BUG_ON(!IS_ENABLED(CONFIG_MM_ID)); >>> return test_bit(FOLIO_MM_IDS_SHARED_BITNUM, &folio->_mm_ids); >>> } >>> #undef PF_ANY >> >> I don't get it. Sounds like we're adding a compile-time check to check >> for a compilation error which would have happened anyway. >> >> If folio_test_large_maybe_mapped_shared() is only used with >> CONFIG_MM_ID enabled, then do >> >> #ifdef CONFIG_MM_ID >> static inline bool folio_test_large_maybe_mapped_shared(...) >> { >> } >> #endif >> >> ? > > Hmm... we considered using '#ifdef CONFIG_MM_ID' for > folio_test_large_maybe_mapped_shared(), > but since this function should never be called without CONFIG_MM_ID > enabled, compile-time errors might be the way to go -- and a compile-time > check here does the trick ;) Yeah, I deliberately used plenty of IS_ENABLED to avoid a #ifdef mess all over the place. Maybe clarify in the patch description that we want to prevent the function from getting used without CONFIG_MM_ID, and we don't want to use #ifdef because then we'd have to add even more #ifdef in callers that use IS_ENABLED(CONFIG_MM_ID). -- Cheers, David / dhildenb