From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDA3C4363A for ; Thu, 8 Oct 2020 12:06:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9959920B1F for ; Thu, 8 Oct 2020 12:06:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wq2WSf3z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9959920B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 919856B005C; Thu, 8 Oct 2020 08:06:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CAA46B005D; Thu, 8 Oct 2020 08:06:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B87B6B0062; Thu, 8 Oct 2020 08:06:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 4D2EC6B005C for ; Thu, 8 Oct 2020 08:06:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D9F6F1EE6 for ; Thu, 8 Oct 2020 12:06:38 +0000 (UTC) X-FDA: 77348631276.25.sleep40_1b0361d271d7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id B42341804E3A1 for ; Thu, 8 Oct 2020 12:06:38 +0000 (UTC) X-HE-Tag: sleep40_1b0361d271d7 X-Filterd-Recvd-Size: 4792 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 8 Oct 2020 12:06:38 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id c22so7777358ejx.0 for ; Thu, 08 Oct 2020 05:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=gXjtIH7dAAJciFaXwreITvtgTALD51vwZB1L5IfZhnE=; b=Wq2WSf3zZJQ4BBWUyL5VGwtoZDmet7UNRDliIwTtTITSFkUFE2pgG2EMtfEmspaGl6 +m2CoVlv02bMP1hxzUoyUNhgZjl8NrvIIqXcia7ZmK4CA9GryMFrLSG2lUWywThFUIq6 tNfjA3+nOv3TtLpTW9TZPEmf15u89ALe5wbq4diXDRilHBVlSh+r/21c6hsb0CgqExO4 xtaT3keqIu6jGCcMXo3qUHpkmv4Hr+ZL2htSqgViDoz+PCYz0iQLvBdzxfon/1ze4E30 pvZP7kv3HFJ0vTwpgzc8DWMf7WcD5KxYm7hBIC2JML8nVpte6otZd4CW11o/EpcGz0ub iqvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=gXjtIH7dAAJciFaXwreITvtgTALD51vwZB1L5IfZhnE=; b=AmnuSsLoBIYcOzW67p83wIQJhmq8ohRqAToNNF5LK5+WPaI71BMG/Kxhbd2BY4y9Ai k74XiLbmsymv1smWBRIQR0lUOC7m2Ep5V/DSna9WTHQWU3RUG+I0OUA8kQkwIxE0cFpS 70IMA1GxhLI87JTmiHSxGQmd/MLhdP/eRXk52iIMaI8fp8w29gTXXK/9zEuOyHJcy4KE FagUniCJAWxBUrleD0X4JMgY7r73ohiCSmhgRagboZckT96O0QMnVBl/KePliYAD/Dd5 qqDcwdk9o9UuUS66rK1SmtzlZbEtAbTFexulwKXZXcVRrbKAtOY2LHpXFJWNSTzqxTr9 dR1w== X-Gm-Message-State: AOAM5322ODCrqeWDK8AUCMqZG5yURRPoUQvffQBiKPy4UJXCKNGW0x/C WVjWP8aRfgqE5VDEmbLRuEk= X-Google-Smtp-Source: ABdhPJx6xc2xxF8cIvrcp9+s773JObUPxs9e5wJpF3CyCr5TW/ZXQKvGUYmaCfo2bUuLtvDCAuZ3ig== X-Received: by 2002:a17:906:b004:: with SMTP id v4mr8779129ejy.156.1602158796801; Thu, 08 Oct 2020 05:06:36 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id bu23sm3843061edb.69.2020.10.08.05.06.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 05:06:36 -0700 (PDT) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH 1/4] mm: introduce vma_set_file function v2 To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, akpm@linux-foundation.org, daniel@ffwll.ch, sumit.semwal@linaro.org References: <20201008112342.9394-1-christian.koenig@amd.com> <20201008113937.GB20115@casper.infradead.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <41323971-7869-ed09-6181-99a567dc6d7b@gmail.com> Date: Thu, 8 Oct 2020 14:06:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201008113937.GB20115@casper.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 08.10.20 um 13:39 schrieb Matthew Wilcox: > On Thu, Oct 08, 2020 at 01:23:39PM +0200, Christian K=C3=B6nig wrote: >> drivers/dma-buf/dma-buf.c | 16 +++++----------- >> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 4 +--- >> drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 +-- >> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++-- >> drivers/gpu/drm/msm/msm_gem.c | 4 +--- >> drivers/gpu/drm/omapdrm/omap_gem.c | 3 +-- >> drivers/gpu/drm/vgem/vgem_drv.c | 3 +-- >> drivers/staging/android/ashmem.c | 5 ++--- > ... >> +++ b/mm/mmap.c >> @@ -136,6 +136,22 @@ void vma_set_page_prot(struct vm_area_struct *vma= ) >> WRITE_ONCE(vma->vm_page_prot, vm_page_prot); >> } >> =20 >> +/* >> + * Change backing file, only valid to use during initial VMA setup. >> + */ >> +struct file *vma_set_file(struct vm_area_struct *vma, struct file *fi= le) >> +{ >> + if (file) >> + get_file(file); >> + >> + swap(vma->vm_file, file); >> + >> + if (file) >> + fput(file); >> + >> + return file; >> +} >> + > These users are all potentially modules. You need an EXPORT_SYMBOL()? Oh, good point. Yeah I totally missed that. The initial DMA-buf use case=20 was not inside a module. Thanks, Christian.