From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55CA8C433EF for ; Wed, 16 Mar 2022 14:56:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A10518D0001; Wed, 16 Mar 2022 10:56:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0CB6B0072; Wed, 16 Mar 2022 10:56:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 888A18D0001; Wed, 16 Mar 2022 10:56:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 79F786B0071 for ; Wed, 16 Mar 2022 10:56:30 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2D0051823E3E6 for ; Wed, 16 Mar 2022 14:56:30 +0000 (UTC) X-FDA: 79250550498.28.4E2838D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 5C7CC1C0003 for ; Wed, 16 Mar 2022 14:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647442588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=voZ1TowISuZDmUgM/T0ZeaglCupBmFtGBGvPfwVeUQc=; b=FhTTReakXrgj7HH1pnH4m/bl2WfdN+SplS6CcpXNsECuA6TN9zxETJNId57xAS7fZag7zf 4zexhNTPgGiSJ+nRq9zhmAyzFniGLYAPL2If/vD6gjZNXvulSVOGlaQAbSBgXqE/YDXRxa X3GRxr63PyD0C9MuPairsm05CHRceKk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-154-4stLAV4APlW5s_d9oI5ZTg-1; Wed, 16 Mar 2022 10:56:25 -0400 X-MC-Unique: 4stLAV4APlW5s_d9oI5ZTg-1 Received: by mail-wm1-f71.google.com with SMTP id f19-20020a7bcd13000000b0038c01defd5aso1135060wmj.7 for ; Wed, 16 Mar 2022 07:56:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=voZ1TowISuZDmUgM/T0ZeaglCupBmFtGBGvPfwVeUQc=; b=zgbgWwkYYTIKTrcaMoYb4cyfYJJgBm+oPL05KHElWCYELyzV6ESpCZyjkEK11a0F0t iARfyrQ8cBz4S/mkTsqw5LRswF5lxRLju2JtaeBRiEa+ZM6VLn5obxagRg3eaAsuZGsV nQGb6kzBr67+fZIvlbB+zXKMH6+Fl/jnkuXYrZDUhHZ+WaG956LLypueA8AhcL5DmAv6 7S+JW8/I+v5fFnH6gDj9F0nS0gBATYL3nIkydrXHfPFWvUgD3wqQ4Q+LErD+XpZ1N/cD 3JK3nUJh7/PkeadngY6JhGCSDrh8cKvIh4rGrrz/ZoyCR5Iohk8JL9GAcuRA6QNcSg1B Qgbw== X-Gm-Message-State: AOAM532FPtoFcH9X8XDRFnFWw9xaw4+Z1+UMh1b+kTaHnS2o9mj3+wUR 0AZA6GOHqpS+Lt7W2np0EURvGRDyPU6z6EOg5uH6r58UpbeOpnT8zksyzwGjcSTtae1rj7rlNS8 fnIf+DMz71Sk= X-Received: by 2002:a05:600c:500e:b0:38c:6d79:d5ac with SMTP id n14-20020a05600c500e00b0038c6d79d5acmr3017379wmr.42.1647442584519; Wed, 16 Mar 2022 07:56:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjIytKLVQ3f6gh/t2S1K26foAiH1BL5IwghKgUgeVEUI+0OpFvcs+A7kDilujtp46WA7cWbg== X-Received: by 2002:a05:600c:500e:b0:38c:6d79:d5ac with SMTP id n14-20020a05600c500e00b0038c6d79d5acmr3017362wmr.42.1647442584253; Wed, 16 Mar 2022 07:56:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:f900:aa79:cd25:e0:32d1? (p200300cbc706f900aa79cd2500e032d1.dip0.t-ipconnect.de. [2003:cb:c706:f900:aa79:cd25:e0:32d1]) by smtp.gmail.com with ESMTPSA id y13-20020adffa4d000000b00203e3ca2701sm737891wrr.45.2022.03.16.07.56.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 07:56:23 -0700 (PDT) Message-ID: <412dc01c-8829-eac2-52c7-3f704dbb5a98@redhat.com> Date: Wed, 16 Mar 2022 15:56:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] delayacct: track delays from ksm cow To: cgel.zte@gmail.com, bsingharora@gmail.com, akpm@linux-foundation.org Cc: yang.yang29@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20220316133420.2131707-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220316133420.2131707-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5C7CC1C0003 X-Stat-Signature: ani65ihoys6j6hxog1wzxo1yc8rmwyhj Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FhTTReak; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1647442589-920043 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.03.22 14:34, cgel.zte@gmail.com wrote: > From: Yang Yang > > Delay accounting does not track the delay of ksm cow. When tasks > have many ksm pages, it may spend a amount of time waiting for ksm > cow. > > To get the impact of tasks in ksm cow, measure the delay when ksm > cow happens. This could help users to decide whether to user ksm > or not. > > Also update tools/accounting/getdelays.c: > > / # ./getdelays -dl -p 231 > print delayacct stats ON > listen forever > PID 231 > > CPU count real total virtual total delay total delay average > 6247 1859000000 2154070021 1674255063 0.268ms > IO count delay total delay average > 0 0 0ms > SWAP count delay total delay average > 0 0 0ms > RECLAIM count delay total delay average > 0 0 0ms > THRASHING count delay total delay average > 0 0 0ms > KSM count delay total delay average > 3635 271567604 0ms > TBH I'm not sure how particularly helpful this is and if we want this. [...] > struct vm_area_struct *vma = vmf->vma; > + vm_fault_t ret = 0; > + bool delayacct = false; > > if (userfaultfd_pte_wp(vma, *vmf->pte)) { > pte_unmap_unlock(vmf->pte, vmf->ptl); > @@ -3294,7 +3296,11 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) > * > * PageKsm() doesn't necessarily raise the page refcount. > */ > - if (PageKsm(page) || page_count(page) > 3) > + if (PageKsm(page)) { > + delayacct = true; > + goto copy; > + } > + if (page_count(page) > 3) > goto copy; > if (!PageLRU(page)) > /* > @@ -3308,7 +3314,12 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) > goto copy; > if (PageSwapCache(page)) > try_to_free_swap(page); > - if (PageKsm(page) || page_count(page) != 1) { > + if (PageKsm(page)) { > + delayacct = true; > + unlock_page(page); > + goto copy; > + } > + if (page_count(page) != 1) { > unlock_page(page); > goto copy; > } > @@ -3328,10 +3339,18 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) > /* > * Ok, we need to copy. Oh, well.. > */ Why not simply check for PageKsm() here? I dislike the added complexity above. -- Thanks, David / dhildenb