From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D281AC27C53 for ; Fri, 7 Jun 2024 08:58:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 583266B00B2; Fri, 7 Jun 2024 04:58:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 533236B00B4; Fri, 7 Jun 2024 04:58:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FAB26B00B5; Fri, 7 Jun 2024 04:58:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 20B356B00B2 for ; Fri, 7 Jun 2024 04:58:21 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 812271C2975 for ; Fri, 7 Jun 2024 08:58:20 +0000 (UTC) X-FDA: 82203491160.24.ACCF27A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id 0EF5F180013 for ; Fri, 7 Jun 2024 08:58:16 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mXMAKFXd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8zD9PuLK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mXMAKFXd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8zD9PuLK; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717750698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U2bfCmFU6J95yjEZ2GgDnCsnnuBBOizhhetPYhTJkZo=; b=n9DsRCeeiw4KO8Z7WWkaD1fCnXOgydtBLbV5pvECD99kuJffIDnkz7Vtl9ssYIn3VY29gb mGNydrfoNEh0+G9wsle4ZZI2r2adNMaToZ6VU1EF40wW/MsxzboEsrUUPvesjIGkKBTs2+ 5FxQG99Z6I1L5GfbVsIzLoEgRMrBLbo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mXMAKFXd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8zD9PuLK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mXMAKFXd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8zD9PuLK; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717750698; a=rsa-sha256; cv=none; b=W8YNIKAQwJON0ySDsDa9eaTHcu88rceifPDhHICKR2JQ3KhyQfnWjvKWM0ADt+gdOiyuJO HartyhECfddEPH1z56Ba5vQcaUaHPl8NoqAweauqqVDWpNTwmDDgynjXl366caVRmCTNag 410+i7fO6mDAW9nIu74UOJWSltx6prs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 45C5D1FB8E; Fri, 7 Jun 2024 08:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717750695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=U2bfCmFU6J95yjEZ2GgDnCsnnuBBOizhhetPYhTJkZo=; b=mXMAKFXdUl6MwWdW5OiO17ldWWreA5WF6XLw2Fk+86/CCk1ysogc9UM45V8f2BR5KxSVyo HsvREcBGJTGuHk1CCIc+1oIzcO6nNNPtq1k4qf1PfJ2CdhPu2xOc95paDMZWe+Mqk3MiCh GDIttzBWRzSu2vWX1rED3bsJIC0i5IQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717750695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=U2bfCmFU6J95yjEZ2GgDnCsnnuBBOizhhetPYhTJkZo=; b=8zD9PuLKUrQ8XAmWUh5KVdhcp8JIGFoJ39Eg/ZB3OMGhNX+Mmyn0WztY6hr9+FMebGflG9 QEh3Rg2ulv5z1YCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717750695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=U2bfCmFU6J95yjEZ2GgDnCsnnuBBOizhhetPYhTJkZo=; b=mXMAKFXdUl6MwWdW5OiO17ldWWreA5WF6XLw2Fk+86/CCk1ysogc9UM45V8f2BR5KxSVyo HsvREcBGJTGuHk1CCIc+1oIzcO6nNNPtq1k4qf1PfJ2CdhPu2xOc95paDMZWe+Mqk3MiCh GDIttzBWRzSu2vWX1rED3bsJIC0i5IQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717750695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=U2bfCmFU6J95yjEZ2GgDnCsnnuBBOizhhetPYhTJkZo=; b=8zD9PuLKUrQ8XAmWUh5KVdhcp8JIGFoJ39Eg/ZB3OMGhNX+Mmyn0WztY6hr9+FMebGflG9 QEh3Rg2ulv5z1YCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 82AA313A42; Fri, 7 Jun 2024 08:58:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0rpCH6bLYmYfFwAAD6G6ig (envelope-from ); Fri, 07 Jun 2024 08:58:14 +0000 Message-ID: <412071b4-19cf-4b6c-bc91-1560f1dfb609@suse.cz> Date: Fri, 7 Jun 2024 10:58:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] slab: make check_object() more consistent Content-Language: en-US To: Chengming Zhou , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240607-b4-slab-debug-v3-0-bb2a326c4ceb@linux.dev> <20240607-b4-slab-debug-v3-1-bb2a326c4ceb@linux.dev> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240607-b4-slab-debug-v3-1-bb2a326c4ceb@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0EF5F180013 X-Stat-Signature: pbpkfgk8s13558er7urfod8xu87xxer4 X-Rspam-User: X-HE-Tag: 1717750696-442190 X-HE-Meta: U2FsdGVkX19Fnw3msRb3zbJmcEfkY6okDb97bZ+bS+tEIqMGhEontGd9PHroOpjBJIebQGER5o5pkUaBl182DK/pFMyYWvfEv0VCzAPpEW7t8FKDuvj3HgC/5TfwFPrkdbMuVbtJCoQXn7CB+onUQuOOGoo3x7xOVgn7kA7cffH4p3600BD8N8NNZbNiVu0w4Xbgv7a6oPNAAvQdJqV5e3osKPMZRw2iprBPmQqNqLmmJTYw+2puZ4v+XWU39Xr0CzPJXoHerU+qtv0qne7F1OkumDm751rFFXCmMebJT4dtl1EeEkk68zW/ecvPyq8o6PnrukhSTWswFUqW8DFVvc5GLSAFO/DT0yhFaDNY3Mmw7+evh4f9nmmKevgL4qgk/nWRyvd9fe+JQc5mt7xj3V+1S+FXSE5VEPRjWheWRQip9CJt8kbXCtDoVeM3ZlHMz231qCCJbcGTQmyP4zeEwX9x+GlOjZWGp/G2dDegfMVZgi+mj7udeN0KTXCMyz4zfblOaMS2s29xVbxGuBlxeHOQeY/zGVSa4GjlqyTsqI5WWWpNmR+wC4nJp5NOoU+SItJXxpDPPfpEXKmzSXH6049PhtrFdu7imF6X/sehkG9hnIElUKkW+3cDXpSYaOx+ovnKqK7U54cW9Q5yF+OuV2sDvxCMZk5FyG2go2Hq7N9ytJYm5GWqjCXJ4jTWuoqGC0fPevCpcZx0brjtobDdwSG6BdJ0YU53LNau0XsXAL+MAfwOzCXF/IEYvaqNwziZzTjubpMbR6Jf0AQYR/tmqgqRq9TA9evhCuYUzYW3/j+QgB8mPlAwl/OzXQ0c+ZtFwsgMnsrVGF4N/sG3hta94GumkhnOz2hGkabAdeJUbDQC13PjYP9faZqzC1txgN/XR2dfQouwokzE2QTh01ftqEivMNEY0q2ellEZsA9rfbTQQb3WZHanYUC8SFxTjzgXfgPGRuAa4EC4eqp+5D6 04KKvuiC i1hsVYFMLs+KEr66tq5FAGsO6O3D8yc6JRXWgnmxdGMKs3g54uUjNyDEHgVucvRtIc+8O67sTG7eWuKBClXTEHmW0zVoihToi+RccLaUvTWe0woYjiSnVN3tu33o/7qOIvz3Y+Ay3BKh1L8kGeClG582kajFG/RvDUnOo0wkvgBpIukP+/szMMXFG6XTCi1npqmaptPmsHJ9Qft6lIF2hTsrSAa4wLu7WHqoqyYSRj7Hq96Mz2JjoekCJ4RcJhtAnsW/+fG3ydcDKi1956KapkZ/taODGV8FBZKZ5rLTIO9NKShnoU1fpcpF1I5H3+u6vjikeWolXyCb2sveGDUyphbZCVLbzaDqINXtXUND1p6Be+tm5pAG58HRs4Zp+oOjYDiqo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/7/24 10:40 AM, Chengming Zhou wrote: > Now check_object() calls check_bytes_and_report() multiple times to > check every section of the object it cares about, like left and right > redzones, object poison, paddings poison and freepointer. It will > abort the checking process and return 0 once it finds an error. > > There are two inconsistencies in check_object(), which are alignment > padding checking and object padding checking. We only print the error > messages but don't return 0 to tell callers that something is wrong > and needs to be handled. Please see alloc_debug_processing() and > free_debug_processing() for details. > > We want to do all checks without skipping, so use a local variable > "ret" to save each check result and change check_bytes_and_report() to > only report specific error findings. Then at end of check_object(), > print the trailer once if any found an error. > > Suggested-by: Vlastimil Babka > Signed-off-by: Chengming Zhou Reviewed-by: Vlastimil Babka Thanks.