From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE4BC25B76 for ; Wed, 5 Jun 2024 09:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E13876B008A; Wed, 5 Jun 2024 05:14:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC3256B008C; Wed, 5 Jun 2024 05:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C15486B0092; Wed, 5 Jun 2024 05:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A49F76B008A for ; Wed, 5 Jun 2024 05:14:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3536714126A for ; Wed, 5 Jun 2024 09:14:32 +0000 (UTC) X-FDA: 82196274384.01.81440A5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id E409D40008 for ; Wed, 5 Jun 2024 09:14:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EJ6fIxek; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717578870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ECiqjrq4uqLZy0Wh/Ft8EG5eXJWRolWE786wAUykcz4=; b=zgJyx0fh2TRGlPn9WiN9Y4fuGPsEBfem7z5XVkKWwl71siWVsXzsRbZyBGZ12dNZqAUc2O juXFDQm/7+YJ30sSVp9q2bckoISsddZVpDOsl27qStRcC9GymDwoclfS/Ou18pW2yvXQiO rSab6kxnmttf9iMA03IyB74MoGhYP+E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717578870; a=rsa-sha256; cv=none; b=YkhDm+VwT5AS1ZRhk5WXApbT16pPn7sbWwWPxg4XCH9qtDvIyFkrbhcNNL3sCsocggL7iv NwxDHbM2rSPux9BpTGRzVFge2sOqETvxzPJqfNvyR+UkGjHDFg8sKXNJPzP3MCHLXmnqJE GvJ2FrDyNGa9Kp6Kw0i4KSgu/HWxdsY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EJ6fIxek; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717578869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ECiqjrq4uqLZy0Wh/Ft8EG5eXJWRolWE786wAUykcz4=; b=EJ6fIxekEIoEfOCNYHMrwkQJUSBHplNF0xcCEDTzAq49LOIE+QhbdQMjjw1r4pD4aWPUVt VY32I9cvqmtj4ayXZEioeTgnPr1BQLG/AmJTs9WtQ6vt6K09HwUC9DP2o0+RrhVLtDKMsr TKA0JLapEH0g1HIC6nBW4YK5LpB3Jpk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-IbA35A2iOOO3rmBhpC71Cg-1; Wed, 05 Jun 2024 05:14:27 -0400 X-MC-Unique: IbA35A2iOOO3rmBhpC71Cg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-35e4b4e0260so3251978f8f.0 for ; Wed, 05 Jun 2024 02:14:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717578866; x=1718183666; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ECiqjrq4uqLZy0Wh/Ft8EG5eXJWRolWE786wAUykcz4=; b=Xby5OPCIl7n//yGS1S6DtX0xyYiFABH9O8D6hpcPBqKXQ4OoOd5uwvxJqAkGX32vkH +WBu4SzMZ8IYfeQLMm6J3VtlWRnq03/TWPwV+m4MSIn2gdEftEfq8hJQGDRVpX3Kt9tH c1+f3xQm8rw4OYRUiCZ9blIevxAdHrRsyh5lSOlmgU0KadPRzApE7UCWxbhO25A6UBSd X9G/xr/9G8Ay5KpwM1KseVpiAAAmlXIS712vHwZTs1VlPDxYybLv+5MIIZycsoHTM7z6 mvWt6RSQayV9pSeF2WQ03BZMWEyQU7QUzB4MU194x+UCOFKrqXyXm1JAKoUjQnfa8TL9 xB6g== X-Forwarded-Encrypted: i=1; AJvYcCWigB+y3sr44mk3GAiUmmZC+HghgwmhUouZYWOy80DA2fivVgW4AP4CHLS5TVpAj6yrNuiRd80iBEgY+BbO56PoJZU= X-Gm-Message-State: AOJu0YxS2N+f1UC0MiWh2ciDqidOTx1olHP57RAfCtFNvLwc07+yO/ai Ag4qCQqG0q7u7baBFKVxKo/65rDjt5WNdiyzrgviVlpzGcMa8B6vrKZrxKkEqF0Xnb4x8U9bFef 1HjNhEfEEf2kXaYXtgTzvlf3Eoof+PdIeIx9tyqgsfLHA+VC9 X-Received: by 2002:a5d:4a4f:0:b0:35e:7d21:cad2 with SMTP id ffacd0b85a97d-35e8ef2553bmr1621911f8f.30.1717578866449; Wed, 05 Jun 2024 02:14:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbr7bZ3mwrCo97qmn6F/LwMydLWE42LGqqHM3APD05MO77ixOEX9zg6fxzwCNXm3yvaqL/tw== X-Received: by 2002:a5d:4a4f:0:b0:35e:7d21:cad2 with SMTP id ffacd0b85a97d-35e8ef2553bmr1621893f8f.30.1717578866053; Wed, 05 Jun 2024 02:14:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:3100:19a8:d898:8e69:6aff? (p200300cbc706310019a8d8988e696aff.dip0.t-ipconnect.de. [2003:cb:c706:3100:19a8:d898:8e69:6aff]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04c4388sm14002266f8f.14.2024.06.05.02.14.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 02:14:25 -0700 (PDT) Message-ID: <41130a02-80cc-4ee4-89ab-e889844a35f7@redhat.com> Date: Wed, 5 Jun 2024 11:14:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm/ksm: reduce the flush action for ksm merging page To: Alex Shi , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-2-alexs@kernel.org> <9ca730ce-2b2f-42d2-8c7a-78735a995c64@redhat.com> <4d299245-3166-4810-b22b-2a5b4f54a049@gmail.com> <7c6ae2a3-8ec3-4c9b-81c3-125f6973f0f3@redhat.com> <59921e08-d0f1-4bc8-acee-368a978286a4@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: jgozpa95739qe8hn5wht53zmhaxx85py X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E409D40008 X-HE-Tag: 1717578869-711982 X-HE-Meta: U2FsdGVkX1+1Q/iShh4MluzjVCLkRzdUjSU4MJppSsDWq8I+CGNN5iXHO6VI/4g/BokFuxEmc5GB6IWbtNx20btIBj7NMbLNC9+bVR3nRpv7HiIOiitWjPjHAmHe9vZf64WVJVMA3bqIeA//4gZZODC4EfqpevrlrY+sTce+CmcE83AETbvi+qchS5J+8hVJboghdv//r3w9ZaQx26OyLLNG9tLeaI0l5Nc3w2MSS/2lKXeM6bN8aRhI1hmCBO6RTFgrlkKgcacqUv3yuddOgE+A3BQEVi7aVFShIkw0vVX/F0oynbuA8STC+9l8d+zUj1RWqZouzDWrgXiAWlB7NUTTDr8tvbQo8aFaSBN1BDY7wD2kY6Dr11n5a/XSy9WWv2myrfDndySk/QJtvLexi5V6hGwpTsJkBbqYBlf7pBkYMqd0GHXaOUzkFYBSGUD2EeBpH7yYmyIiea1tUwMlEljCqY9jB19gab11hPYG1xO2kU2zW1xVFYTN8fncTvPTCjiqY+UxMcMpcj5W4Qatut+n4PqCEiTJ/CVhGzVjueTwesLEz4EdAqOQrD3cmlj4LLAZzPklrSK55u0Mp8m8fmciG8fgMicJWH2b8+YizL7TDhfxAEWHeOdiK4KjrfMN81EZHDlt0efgJuIVtwot2ZIzU8Z6V/khXB7daH8K38Q5t9sW9TKRcL+R8ti6r/ShdrNq0yIHPhXfk2aZKZM7XLYPbbvcVm39N/qAK6e3iuaon6k/T7YD9hPJSz0OHHKhxf1U+gyhD74olKgIXe9lBU08BF3sclp/Ju8G/jabK5B964BIgOxeUE0XVZAiiE0pZJZigJr2rwg5D8QjCO3HnBhl720bDyz1gR2/3XEtnwIv8ujZ8ESwNilRqppstQrDjX997K7zsNDKdqarvEn6L3xbEXOxKqnAfH5ri3/37IjL1llJKJ6z63u4DYED30xy/iql/uRqizYMhD5jAtC AD9wTcMv fLwJENDfhQ9hfSVtrbcFhI6rWLlHBeq9ytVcqGU2Uv37SSTbpFLt4ccYP+anyzbBZovgZ2YBjixdwfzWpjgzs8WUVTvalXuDz+2HxaDNYncgPUt6Bs6cA3cfKeVqo34A4V3PGW96BZK2r2kK/UahUMdikzbXPzZ2Okyk5OgdbIcnt1/3WvOS05+ksM9jtNP72PF05/sVy8Ik0Pp8OaxLbKD/1dyd3szSHU4a8X99TiEOrhJADEHepzzV9teHO9UMJ0QO68KMkfoS5Gan3XX/b2nwU8alnIcbhijil2lPdfAVvsiowsjzUe+1yYrEFNxxZR4ZQFGL3gzrgAyyx9ag2W/25RYeMng8OjwpKYiZqr6xoRrchUe82hNf5W64E+v7eiSKYMOKolr1j1AWKujyuGAH+9aS8igCxtc+iTDop6reCVYrmui7Bf4P8LngyyuR/DYVOizR2WDBNUBWbBUSquT8EXgdjIbP7exroiRdMQnGLDL1zRe1WYl1rxh03+AnfaZE1q1rYdOLJhYWQgj8c/WZ9FQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.24 11:10, Alex Shi wrote: > > > On 6/5/24 3:26 PM, David Hildenbrand wrote: >> On 04.06.24 15:02, Alex Shi wrote: >>> >>> >>> On 6/4/24 6:45 PM, David Hildenbrand wrote: >>>> On 04.06.24 12:26, Alex Shi wrote: >>>>> >>>>> >>>>> On 6/4/24 4:07 PM, David Hildenbrand wrote: >>>>>> On 04.06.24 06:24, alexs@kernel.org wrote: >>>>>>> From: "Alex Shi (tencent)" >>>>>>> >>>>>>> We can put off the flush action util a merging is realy coming. That >>>>>>> could reduce some unmerge page flushing. >>>>>>> BTW, flushing only do at arm, mips and few other archs. >>>>>>> >>>>>> >>>>>> I'm no expert on that flushing, but I thought we would have to do the flushing before accessing page content -- before calculating the checksum etc. >>>>>> >>>>>> Now you would only do it before the pages_identical() check, but not when calculating the checksum. >>>>>> >>>>> >>>>> Hi David, >>>>> >>>>> Thanks a lot for comments! >>>>> >>>>> If calc_checksum() is wrong before pages_idential(), (that's just after page was write_protected, that's a real guarantee for page context secured) pages_identical could recheck and make thing right. >>>>> >>>> >>>> Yes, but you would get more wrong checksums, resulting in more unnecessary pages_identical() checks. >>>> >>>> That is missing from the description, and why we want to change that behavior. >>>> >>>> What's the net win? >>>> >>>>> And as to 2 flush functions here, I didn't see the guarantee for other writer from any other place. So maybe we should remove these flush action? >>>> >>>> "I didn't see the guarantee for other writer from any other place" can you rephrase your comment? >>>> >>>> If you mean "the process could modify that page concurrently", then you are right. But that's different than "the process modified the page in the past and we are reading stale content because we missed a flush". >>> >>> >>> Maybe moving the flush before checksum could relief some worries. :) >>> But still no one knows what flush really help, since if page content only syncs to memory by the flush, the kernel or process can't be work with current code. >> >> Please explain to me why we care about moving the flushs at all :) >> >> If they are NOP on most architectures either way, why not simply leave them there and call it a day? > Uh, 2 reasons: > 1, it uses page and can't convert to folio now. > 2, as you pointed, flush action w/o page reading seems just waste time. Alex, I don't think the approach you take for coming up with the current set of patches is a good idea. Please reconsider what you can actually convert to folios and what must stay pages for now due to support for large folios in that code. Then, please explain properly why changes are required and why they are safe. For example, for in scan_get_next_rmap_item() we really *need* the page and not just the folio. So just leave the flushing there and be done with it. -- Cheers, David / dhildenb