From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7D2C52D7C for ; Fri, 9 Aug 2024 00:57:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ECF46B008C; Thu, 8 Aug 2024 20:57:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99C356B0092; Thu, 8 Aug 2024 20:57:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83D026B0095; Thu, 8 Aug 2024 20:57:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 665C36B008C for ; Thu, 8 Aug 2024 20:57:05 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 18FEE12049E for ; Fri, 9 Aug 2024 00:57:05 +0000 (UTC) X-FDA: 82430892810.29.85B29F5 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf15.hostedemail.com (Postfix) with ESMTP id 0F49EA000A for ; Fri, 9 Aug 2024 00:57:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LpLIDUDQ; dmarc=none; spf=pass (imf15.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723164969; a=rsa-sha256; cv=none; b=2Sg9YiB3BExrr5109q8G0hY7QJ/Oc9FwQRKD7+ZoBa5qBPsWULTgrKGIfV1QdhZL2cr5Dn NxhyDqFoOWvefsEdh656ZLCjHUyvX+xuTPTdeaUKBn9BRrj/1LYKgtj9WSnUbIPjNZce/U 0F9U9sTI68/B7JW6jus2L8YQk1UpvN8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LpLIDUDQ; dmarc=none; spf=pass (imf15.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723164969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/MtvB8mjyzu2IoB2Ws5JzlodQoFeEGwt1Z17iJ76PG0=; b=iwaAU18b8FtaWwRIFZsIHhAAKKHGBK7CEf60akUhxV7ozRVfB/TvVudnYQpua5ndWQ8pbN 471oErZ6t+GO5oh9zx5B1PSSK0DfOQAE13sDaD+hJ9c+hdHqQYNNs7w8e2MBSx9zgX7M2P NShT9P+OVEVxpjKYFVIQ/mUd3AA6u0E= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7106e2d0ec1so1372669b3a.2 for ; Thu, 08 Aug 2024 17:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723165022; x=1723769822; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=/MtvB8mjyzu2IoB2Ws5JzlodQoFeEGwt1Z17iJ76PG0=; b=LpLIDUDQFvpoy5FYhwSaLSGFIkBCohIt8TP9Zxn4C4LI2Vw0DhdTe5X3fpv9OT0P9R ZZtZ9IjC6BTvKZ34+1L/Z83nrUDhcsUG4cd+CEQQcZ61X1LAd3IFW2eJVJVKp0QUtovt v1QKh4vw0PydzuDAjWnCziS9f+SH0eVdOXlN2m52jMv0XuS/rigVRWsA5zacdDVPwZas B/UYXHWyFHGzUiU92+6Kp3uO8zxO952LFNsp/Fp7JjPJ+aqQrtIvOvcjkCZdj69FlEJG wjoM7ulwjqmu1Gv7nTLQtruf3Nzha6T03tlc29VvRBIhuvDktl5Auz/cDokhZuq5zVsM p9Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723165022; x=1723769822; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/MtvB8mjyzu2IoB2Ws5JzlodQoFeEGwt1Z17iJ76PG0=; b=GtO0ueFg2agW247dE/Apvh0mE5EBHYxPxQnXAM0HHj4JbuBOFjXhyx886C5vxSqkQz 9l9f/wjBaJCtO+OBjqog8qXtgz76/ELkHxQyE64XazCwSh13gETWhWNgWD3mLANbYXYD 66Wg/8GcpsgNMqoU73PxAld4IPjDGsktYZpbuTfFtT1QH126bHQDX7qyNgvv2ls6Iu+E 64vUcovTU9uc49AU+wQDbBMxCaSlcAzj70iBU9c5M/pAVcWVjUxMTSziXj0PXblxRust 4LEywRqrBWKYfFRAZ0Y9QLCnKYexmkTomn/c7NHHNbX+3+6ZmB6sMLLVhGQTYRKVEMlZ yaNQ== X-Forwarded-Encrypted: i=1; AJvYcCXujwHgBkhq97i6JzJb8QbnNsBuRC0u7Ysh9EuBjNvHRDuMZgAJgUMnwhi23SzWM3mLZ6XgnqXT6xaj639+GBWSlBQ= X-Gm-Message-State: AOJu0YzqGovLxHDBDd9BY3aQFAgXOIKBF5Y/FxuC1X83kXj2u1uRcBt2 dG5A4Og61xB+1KMOPKaEpyVVaTpgOrg2YncnX88XqX9qHbocfVx6 X-Google-Smtp-Source: AGHT+IFa9dMA8ylmc3SMI3EP4zQBbdjANMaHmDwgkP4r781TOsixfKKB97oJTKnj1Z4UkHWEmiFgew== X-Received: by 2002:a05:6a00:91e4:b0:70d:2ba1:2402 with SMTP id d2e1a72fcca58-710cae7a5bcmr4056210b3a.29.1723165021529; Thu, 08 Aug 2024 17:57:01 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710cb209fe9sm1686717b3a.42.2024.08.08.17.57.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 17:57:00 -0700 (PDT) Message-ID: <41080afd-86ab-4dc1-9c9f-eef4701692e0@roeck-us.net> Date: Thu, 8 Aug 2024 17:56:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review To: John David Anglin , Linus Torvalds , Thomas Gleixner Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , Helge Deller , linux-parisc@vger.kernel.org, Richard Henderson References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> <87le194kuq.ffs@tglx> <90e02d99-37a2-437e-ad42-44b80c4e94f6@suse.cz> <87frrh44mf.ffs@tglx> <76c643ee-17d6-463b-8ee1-4e30b0133671@roeck-us.net> <87plqjz6aa.ffs@tglx> <87a5hnyox6.ffs@tglx> <8734nezz0g.ffs@tglx> <37f94771-4ebc-46d2-ad10-f145d139dd9d@bell.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <37f94771-4ebc-46d2-ad10-f145d139dd9d@bell.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0F49EA000A X-Stat-Signature: 9kohx6aq8kj5o6c97zqaj9s88omzuh16 X-Rspam-User: X-HE-Tag: 1723165022-63203 X-HE-Meta: U2FsdGVkX18uEWH+8iF5gLM1h0aqzTtp+zcvK70wB4Rqwn3BZkG3iq47349O314GWqyY0IGnfba2Ac31MTm+In3ibSr2ZOgVh3WRBQ9juw2tCWNxfAgdJ5ACX4YZBtZ7fvq+zZwOS/BSrzQYiWclMYt+bzTnQW4j+nhxWATAyl0bL+tOFaQ/JFMi8tlIUIVocognBqc4IVCgovmS2ZRVuWMv5YTXZf5XTz4ikDaVvp17XOikT6Ppqx3/hIzFZrB2JOE5U2HeLnWM7IZFiX78B2Qbhaxa8wFV4wTs8gcugKOOPM/A6e4MTzZKNSUsLnwSW0qpY1axOQl1AOVbHqfzZxElgUsAcJrBhvxU1WYAFzP4Dbk0uo237I5lPUEKQR8W5M1rKFZb/idwKP8vrToVYcFy7sSja5b9nEdgiyUrXOO87QHwz5Ftcro1SjGnI64j9dwOVmh00hPJx99rW3Hz2QRB0qMO3SXebciRqFeJNOH5OvSpGjPECC8N+rK89p2z86fGqoew8izyf/w7bIX3jgewUMwIYoZjd6kEkNLXZ8g7FDZgtEU449d0Gotrkx5A0y3mBAOkTakbdY21Cz88yxK+lnxFvZpI2e5lpVxwz9UpLOUFAVRpBMg7qkO7/5Oz5kJPzZ5gnau7XjZf1yakf+9qahbmVB0YGHUko+dl7f3azjoKAFMAFLw2+6giv0hZR2w7yNVomLDO4gNKldL2FkwQU9BIw+sHoPQyzPnYlzzoEHD6ojKkSTRtusUW3nw4HEJqecsRID/i9hN2bvX+DQpgPBa0vIzn2rkGLpvVSQvRsSECLmy8adyeGZx5HHQQj5bCkJl+Xj4nprTBXpKIGKGjb69JwYI0TIBu0aF0m1elyyPih43MdKe06KqGpCzPqXGEXNTih9mZth9r5AbzarhtTI8wV3kl3cMfmk3za9cBTvUhcgF+ikI4Ww/duYA2KxVX2iHSEPYGq6tDHYq WUZPojKA zczbx2DP0H7WXbQpPWEv+kkno+FowuF+SzbbOd7I4Fg2hQFbia4y1luSh8V+nY4FXMiw2gCdBWubUPwEiqE4454z6LJDgdYpLl0KAx5fN4TiMmTqyeGtpMQ2SwKldWRfQ+Eijvrp2CS8dwEDKJy/WWN6+i/fklvvKbtRJet3rWVzbMYSvInALuEmjam5GYIaeq3dkGQBI28RKvOB5+v7h3rMOrjYBjHky6SP9Vo+YgAUatgmQYa0g5SzlW2dqgpCyvpQFTNmw1blqVkyAmP5r3jExRJ9rrVNhLVBBLc/O1mB/YmYGrn1xoMJJpwSQVqwYtdu0jtfLn9Tx0VseG84dnAXm00RZKc0a/GW3oNuctXnRXNlB6i5sWJGaLTqFGJ6mqauurQ8gkpNH1Hx7uO9XN/67sdBik548nUxsC5Rtxd1AC2OF+y1n15XPqwkUXzgeOkrlQ/rUdlZBy38rud2gkPDxRWkLhAVOJdIcbUtLiMmZfnUksigCzmQ+KZ/C/L2CWY0Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/8/24 15:29, John David Anglin wrote: > On 2024-08-08 5:50 p.m., John David Anglin wrote: >> The mode likely problem is the shladd instruction in the following macro in entry.S: >> >>         .macro          L2_ptep pmd,pte,index,va,fault >> #if CONFIG_PGTABLE_LEVELS == 3 >>         extru_safe      \va,31-ASM_PMD_SHIFT,ASM_BITS_PER_PMD,\index >> #else >>         extru_safe \va,31-ASM_PGDIR_SHIFT,ASM_BITS_PER_PGD,\index >> #endif >>         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ >> #if CONFIG_PGTABLE_LEVELS < 3 >>         copy            %r0,\pte >> #endif >>         ldw,s           \index(\pmd),\pmd >>         bb,>=,n         \pmd,_PxD_PRESENT_BIT,\fault >>         dep             %r0,31,PxD_FLAG_SHIFT,\pmd /* clear flags */ >>         SHLREG          \pmd,PxD_VALUE_SHIFT,\pmd >>         extru_safe      \va,31-PAGE_SHIFT,ASM_BITS_PER_PTE,\index >>         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ >>         shladd          \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ >>         .endm >> >> I believe the shladd instruction should be changed to shladd,l (shift left and add logical). > diff --git a/arch/parisc/kernel/entry.S b/arch/parisc/kernel/entry.S > index ab23e61a6f01..1ec60406f841 100644 > --- a/arch/parisc/kernel/entry.S > +++ b/arch/parisc/kernel/entry.S > @@ -399,7 +399,7 @@ >      SHLREG        \pmd,PxD_VALUE_SHIFT,\pmd >      extru_safe    \va,31-PAGE_SHIFT,ASM_BITS_PER_PTE,\index >      dep        %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ > -    shladd        \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ > +    shladd,l    \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */ >      .endm > >      /* Look up PTE in a 3-Level scheme. */ > > Boots okay.  Fixing the addi instruction is harder and it would take some time to test. > Odd, it doesn't help for me. Does it crash for you without the above change ? Or, in other words, is divI at the objecting location ? Guenter