From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: akpm@linux-foundation.org, hughd@google.com
Cc: willy@infradead.org, david@redhat.com,
wangkefeng.wang@huawei.com, 21cnbao@gmail.com,
ryan.roberts@arm.com, ying.huang@intel.com, shy828301@gmail.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 3/5] mm: shmem: add THP validation for PMD-mapped THP related statistics
Date: Mon, 22 Apr 2024 15:02:41 +0800 [thread overview]
Message-ID: <4107dcc957f3b62a37c83e30ca22305c373ef149.1713755580.git.baolin.wang@linux.alibaba.com> (raw)
In-Reply-To: <cover.1713755580.git.baolin.wang@linux.alibaba.com>
In order to extend support for mTHP, add THP validation for PMD-mapped THP
related statistics to avoid statistical confusion.
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
mm/shmem.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 893c88efc45f..b4afda71a3f0 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1662,7 +1662,7 @@ static struct folio *shmem_alloc_and_add_folio(gfp_t gfp,
return ERR_PTR(-E2BIG);
folio = shmem_alloc_hugefolio(gfp, info, index, order);
- if (!folio)
+ if (!folio && pages == HPAGE_PMD_NR)
count_vm_event(THP_FILE_FALLBACK);
} else {
pages = 1;
@@ -1680,7 +1680,7 @@ static struct folio *shmem_alloc_and_add_folio(gfp_t gfp,
if (xa_find(&mapping->i_pages, &index,
index + pages - 1, XA_PRESENT)) {
error = -EEXIST;
- } else if (huge) {
+ } else if (pages == HPAGE_PMD_NR) {
count_vm_event(THP_FILE_FALLBACK);
count_vm_event(THP_FILE_FALLBACK_CHARGE);
}
@@ -2046,7 +2046,8 @@ static int shmem_get_folio_gfp(struct inode *inode, pgoff_t index,
folio = shmem_alloc_and_add_folio(huge_gfp,
inode, index, fault_mm, true);
if (!IS_ERR(folio)) {
- count_vm_event(THP_FILE_ALLOC);
+ if (folio_test_pmd_mappable(folio))
+ count_vm_event(THP_FILE_ALLOC);
goto alloced;
}
if (PTR_ERR(folio) == -EEXIST)
--
2.39.3
next prev parent reply other threads:[~2024-04-22 7:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 7:02 [RFC PATCH 0/5] add mTHP support for anonymous share pages Baolin Wang
2024-04-22 7:02 ` [RFC PATCH 1/5] mm: memory: extend finish_fault() to support large folio Baolin Wang
2024-04-23 8:39 ` Lance Yang
2024-04-25 7:04 ` Baolin Wang
2024-04-23 11:03 ` Ryan Roberts
2024-04-24 3:23 ` Baolin Wang
2024-04-24 8:07 ` Ryan Roberts
2024-04-24 9:26 ` Baolin Wang
2024-04-24 9:57 ` Ryan Roberts
2024-04-22 7:02 ` [RFC PATCH 2/5] mm: shmem: add an 'order' parameter for shmem_alloc_hugefolio() Baolin Wang
2024-04-24 6:28 ` Kefeng Wang
2024-04-24 6:55 ` Baolin Wang
2024-04-22 7:02 ` Baolin Wang [this message]
2024-04-23 1:13 ` [RFC PATCH 3/5] mm: shmem: add THP validation for PMD-mapped THP related statistics Barry Song
2024-04-22 7:02 ` [RFC PATCH 4/5] mm: shmem: add mTHP support for anonymous share pages Baolin Wang
2024-04-22 7:02 ` [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters Baolin Wang
2024-04-23 1:17 ` Barry Song
2024-04-23 1:46 ` Baolin Wang
2024-04-23 11:39 ` Ryan Roberts
2024-04-24 3:48 ` Baolin Wang
2024-04-23 9:45 ` Lance Yang
2024-04-23 11:22 ` Lance Yang
2024-04-24 3:49 ` Baolin Wang
2024-04-23 11:37 ` David Hildenbrand
2024-04-24 6:10 ` Baolin Wang
2024-04-24 7:11 ` David Hildenbrand
2024-04-24 8:15 ` Ryan Roberts
2024-04-24 9:31 ` Baolin Wang
2024-04-23 10:41 ` [RFC PATCH 0/5] add mTHP support for anonymous share pages Ryan Roberts
2024-04-23 11:05 ` David Hildenbrand
2024-04-24 6:55 ` Baolin Wang
2024-04-24 8:26 ` Ryan Roberts
2024-04-24 9:55 ` Baolin Wang
2024-04-24 10:01 ` Ryan Roberts
2024-04-24 13:49 ` Baolin Wang
2024-04-24 14:20 ` Ryan Roberts
2024-04-25 6:20 ` Baolin Wang
2024-04-25 8:17 ` Ryan Roberts
2024-04-25 8:26 ` David Hildenbrand
2024-04-25 8:46 ` Ryan Roberts
2024-04-25 8:57 ` David Hildenbrand
2024-04-25 9:05 ` Baolin Wang
2024-04-25 9:20 ` David Hildenbrand
2024-04-25 9:50 ` Baolin Wang
2024-04-25 10:17 ` Ryan Roberts
2024-04-25 10:19 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4107dcc957f3b62a37c83e30ca22305c373ef149.1713755580.git.baolin.wang@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox