From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9035CD13CF for ; Mon, 2 Sep 2024 13:35:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FBB28D00DB; Mon, 2 Sep 2024 09:35:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 185328D0098; Mon, 2 Sep 2024 09:35:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F197D8D00DB; Mon, 2 Sep 2024 09:35:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CFE808D0098 for ; Mon, 2 Sep 2024 09:35:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9370B1C63B9 for ; Mon, 2 Sep 2024 13:35:51 +0000 (UTC) X-FDA: 82519896102.25.15CF24A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 47181100014 for ; Mon, 2 Sep 2024 13:35:49 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TdS/g8Xg"; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725284055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5I1ZguwmREVXAP9f5fGwSADsT+ugyzrxjCMFNpweO18=; b=yP4w1FRASxA3i9BRW+F+P0efaVg7qrxemwXo1YE840fw7mf9O/sobCuUN7VFAWPx4ggulc iXaY9tAsVuLORc/mKIEV0pzI81OD54lXw/U4qSZt1cBP21Lnv0TPtG6jt6eiVSkY9gS/y1 Smfrw4OWJWUw1+/g709tBYLn/eDDgUM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725284055; a=rsa-sha256; cv=none; b=2vxcuqjEWe1bhYDZGoK8jwF5sBhbulosdOZvGEfEVFUYfNfFFdeIfKbqLhp5NQXC52xyEM /oRELBScJMLwM9tI9B4ZXhtc8QcQwcUqLgZNogy55zFgB0A1PMKcEvR4KhKJszChZ1RAff OAHA6TWdgC2A2RLqg3u2FYCcqHGoaUU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="TdS/g8Xg"; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725284148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5I1ZguwmREVXAP9f5fGwSADsT+ugyzrxjCMFNpweO18=; b=TdS/g8XgnKtF9t120CNjj7oH31MTo9sAXUrNdmDWhA4IeDfV9e9NsDp4LYvFWu5q5j+ogN e2PGm34N5pjG/5pMjLCOxp/pB0KNVRXRGqm2Zfmcd9+4c+RbJTYKVqlYEB3y8mteckgM7m 6GH7TT7IiW9Bskq8lq3LPzeax2XFAaU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-JofFoQQ1MsqUvV_Gm_HrQA-1; Mon, 02 Sep 2024 09:35:45 -0400 X-MC-Unique: JofFoQQ1MsqUvV_Gm_HrQA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-374c44e58a9so943535f8f.1 for ; Mon, 02 Sep 2024 06:35:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725284144; x=1725888944; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5I1ZguwmREVXAP9f5fGwSADsT+ugyzrxjCMFNpweO18=; b=oxrZ0bmiClWYUKdq/a5hUs6bJQEeZZSKJnsJQmZZPm0Ok4gPjTK+jW0l67ctEXfevD Im659L6QOqNdczp6gjIpKZc3cyz16UF2/LEIGTm0RhMq7BqD/b76IR2zU3+xLiOpLYA5 kOvr611x/Ji0+12F++gHSNRG2AJSHdNeS2K00BWrj9kytBHXhcxNsFdKtpXfen0PqKqC 4f4TCIskSQdpi6yPVSm26ecwc0l19qoFTGXYYPhUzUSaaysH/+1T0ecMLH9U+zj09kSz WXMQu94Nl6AKSEssQcxwcd998y/iXIm/T4THtmRGz+RYcUN9X+jeTnc9MMtP2oRLE9r2 cFzw== X-Forwarded-Encrypted: i=1; AJvYcCVy5x8qZYN2+IPqFwSkSGmYWWu+HiNaHFubY4VxrFzusxEnRxt+gyUAux7lZq3N8myLMYDP0nXzcg==@kvack.org X-Gm-Message-State: AOJu0YyRUm4tdXEuCTss6A1CWxgkiNS8GexnAQLRKo+jUU7v+dSbNv6r iQdtLPxSOx0TNGkcLGYfNCx72RHznRSNQU+p/5qBuRjuyyzpU4So5pDV4H+UIJxdGTkvgo6n7DG dQ/opWrDGKu+YNnshvbDCpEDhbPRSot/EgeX2U6berWClnrVq X-Received: by 2002:adf:f40e:0:b0:371:8319:4dcc with SMTP id ffacd0b85a97d-374c945550emr2176960f8f.2.1725284144239; Mon, 02 Sep 2024 06:35:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjozoaHtSeQQflY8WoTmjwivc1NdN1yjUiU9/4O/eSkhEsySo0uU512Lc45erLwNu4qbbSpA== X-Received: by 2002:adf:f40e:0:b0:371:8319:4dcc with SMTP id ffacd0b85a97d-374c945550emr2176918f8f.2.1725284143299; Mon, 02 Sep 2024 06:35:43 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374c7fa443esm4064284f8f.41.2024.09.02.06.35.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 06:35:42 -0700 (PDT) Message-ID: <41029f58-1142-4629-b65f-8f919093f016@redhat.com> Date: Mon, 2 Sep 2024 15:35:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: don't convert the page to folio before splitting in split_huge_page() To: "Pankaj Raghav (Samsung)" , brauner@kernel.org, sfr@canb.auug.org.au, akpm@linux-foundation.org Cc: linux-next@vger.kernel.org, mcgrof@kernel.org, willy@infradead.org, ziy@nvidia.com, da.gomez@samsung.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Pankaj Raghav , Sven Schnelle References: <20240902124931.506061-2-kernel@pankajraghav.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240902124931.506061-2-kernel@pankajraghav.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: mccy1qpxy1ikwhg9yiutgyxdinku8ejc X-Rspamd-Queue-Id: 47181100014 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725284149-195750 X-HE-Meta: U2FsdGVkX1/Rb7CoOUYm80x8uP5mjTSysGQowj5G6eCac+WzvxX+raIRdNd4dBnv7kKOfdlYQdeNU26yLgtbSl19DLZ0Ymcv+PP5CQmf4DIJyZHYWTXfUcjcACHLEMfYAQumwqY/FKcmjXfTzsgj7MKvtasraHXEo4Ka98UTSaAuCULpTAZsKcp3jaSodFPgLb2IxhRU1sVcquUIn+YjUdcWPeqYNmHF01T2i7uRml/igKpZZaKKy+LoK9h6XEvL3NBdVZpGijn3/YKPQX+3mejBFqW6ZaokmbEb0Ey5/POHJMWDyIpj9uslQhC16F4Ij7/Phd5G4dmuMs3QZ69YOoyeUqgMkqQgpRM94i92FAOkqCGFTOEEPCS/iSxeYfblBelina/CiPeNHnO8jrX1U/kAg32H/Bf6ezlUHku96Fk7nWD94pJatwvhsP6Np3daPbw2E9F01Hln6ePXGd3zgYt4sYU9fH2ZvxiyUZCrFP9bv7ouAhZfPfEB5+ghK9pdc2sxmXXNw0e+gnJAhV5fmm6sDYVvrVdZheFp49t19FURcb7YRCN95kQf2mpwe6CtDKJkN4Y7K/KZKiBWVEeKBNqAjJEyv3JyDGK6we9+xxR70fFBMQKyWjoQRDYy1QaMX1uzzpGntT5JbCoiO1Gly0AL34ldYhNrkkjhnBfgjIUDOj6MpUexQen8F0RcygJe2kIDV+aC1sC4TS1Jlu8C+Eg520205yY90soxnkuyy5NnioKENBegt5wgh0wNZqYwbY0Kb3EivDzOsYUx8GtDTy1mRMi0IKYlCEJ1n1btfBo8DHezM36xx+CLVoPbKFrWvn4ckKgnO7pAY+4Kz83JBnzfSl8f6l3IVoqClicYYovV4erMuonh/yNjE/FgqXeTgoeZRvSIrZ/wEV9WyhIDgtz7d9XtcOSSnpoVDJpj0kuaSuNym2Jm4ADBYpwYyx42bw5v/yo7heNEXG++lQl WbF38OHz 5ieVQxQE7owqranVRe5WQoaOvykZvJ7zBghwCeN+Z65Uimw6pbqzUaV1jWmXnerArv3gjP86Je2npaESY6UAY6G+6AJ73YbWDBeitrL8wpqVdCAOIIze3OdXp5dbFLP0Ru6u9dpHuAuV3SFVMMc/Kow5wfc7XejDQiDiX+zzuLryo41b+c2eC3W6umRtKIqFIYJQONKz+dKSeHc8kjjFlJV/+r54mnBqwUoqxcoziVqX4Mddkpeu/qrsCamHtpINrfwkZWqSWxGlwWN3APH8QbISIFmvzYLQbARAlRgTPCyZXxijAGTvpQpN1sA2tcF3t9FNo+zfcM2xKGKNjU3MicNxd45glUO/AwdjZ6XxuORMrq4o9jON/JfUw06BgV1L6G+3rScZ+jN6fzJhHFEevmjKJyoqy0Ckk4OPHTlUOoT9cgOJMP/uQj1VgPIPRmpxkDblSshZiW+YWRHscvbjH+UIt+E08O8j1NzPpHSWmkbg86c8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.09.24 14:49, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > Sven reported that a commit from bs > ps series was breaking the ksm ltp > test[1]. > > split_huge_page() takes precisely a page that is locked, and it also > expects the folio that contains that page to be locked after that > huge page has been split. The changes introduced converted the page to > folio, and passed the head page to be split, which might not be locked, > resulting in a kernel panic. > > This commit fixes it by always passing the correct page to be split from > split_huge_page() with the appropriate minimum order for splitting. Looks reasonable. -- Cheers, David / dhildenb