From: David Hildenbrand <david@redhat.com>
To: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>,
brauner@kernel.org, sfr@canb.auug.org.au,
akpm@linux-foundation.org
Cc: linux-next@vger.kernel.org, mcgrof@kernel.org,
willy@infradead.org, ziy@nvidia.com, da.gomez@samsung.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Pankaj Raghav <p.raghav@samsung.com>,
Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH] mm: don't convert the page to folio before splitting in split_huge_page()
Date: Mon, 2 Sep 2024 15:35:41 +0200 [thread overview]
Message-ID: <41029f58-1142-4629-b65f-8f919093f016@redhat.com> (raw)
In-Reply-To: <20240902124931.506061-2-kernel@pankajraghav.com>
On 02.09.24 14:49, Pankaj Raghav (Samsung) wrote:
> From: Pankaj Raghav <p.raghav@samsung.com>
>
> Sven reported that a commit from bs > ps series was breaking the ksm ltp
> test[1].
>
> split_huge_page() takes precisely a page that is locked, and it also
> expects the folio that contains that page to be locked after that
> huge page has been split. The changes introduced converted the page to
> folio, and passed the head page to be split, which might not be locked,
> resulting in a kernel panic.
>
> This commit fixes it by always passing the correct page to be split from
> split_huge_page() with the appropriate minimum order for splitting.
Looks reasonable.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-09-02 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 12:49 Pankaj Raghav (Samsung)
2024-09-02 13:35 ` David Hildenbrand [this message]
2024-09-02 14:00 ` Matthew Wilcox
2024-09-02 14:21 ` Christian Brauner
2024-09-02 14:48 ` Pankaj Raghav (Samsung)
2024-09-02 19:08 ` Christian Brauner
2024-09-02 19:35 ` Pankaj Raghav (Samsung)
2024-09-03 7:53 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41029f58-1142-4629-b65f-8f919093f016@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=da.gomez@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=sfr@canb.auug.org.au \
--cc=svens@linux.ibm.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox