From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A88C77B7F for ; Tue, 16 May 2023 08:26:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE2F3900003; Tue, 16 May 2023 04:26:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C92A0900002; Tue, 16 May 2023 04:26:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5ABE900003; Tue, 16 May 2023 04:26:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A09D3900002 for ; Tue, 16 May 2023 04:26:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 527EE16013C for ; Tue, 16 May 2023 08:26:03 +0000 (UTC) X-FDA: 80795435406.12.4C916AE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 1DF7E20002 for ; Tue, 16 May 2023 08:25:59 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GvZOq1In; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684225560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U8pRuM5Q7Lxr05z3aZ6AYXk+Wr4qT28SznqmdXZL224=; b=KUC3YVlrXmnajtiY+KFw1WXyFARMfNpKGL+JH8QKxsMq9GflMBk/aNiNDzbll/gqbftK2S XMSDq08/yY1nZzCGg8OWFoWLK7BF96Z+hR2yETALmdSZmF4q9D8jp8YNFwqgMNqqzBTynF YOrfDkKU1bNRYz+uQcyYSzo0Us158jQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684225560; a=rsa-sha256; cv=none; b=VfSVM9gQyKwPFhw6f5gLZtYmDkv08jNJblv7D6eWmXDHRUQXTjHrrMjYdUE9DlDbRrwYwR B8zTPLvLzTLYFARdTesQ0/uq4+O952Dv5UMHgA73O4ZOequzvvINcVkc8mjVo1og6crLxy VnRE7ux6OaEKzt8BTUoxEWGMl3EeKtQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GvZOq1In; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684225559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U8pRuM5Q7Lxr05z3aZ6AYXk+Wr4qT28SznqmdXZL224=; b=GvZOq1Injm7fe9+1roQT0FVETyKTsfPOpzPKlrqrueq3Gvrt5lMepFOeGLkcVRNOHZXTIe SlylAn4w9k9x+3+nQzP6zYVD7hw3908wxJZ3D/8UhxugN9H98iGdSl8EipKGxrEPozHf4s fbd+SqqqqO9QyTFbvMHYX5wifTDM1LY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-rku0owVpNeeeJj6fH9UKKw-1; Tue, 16 May 2023 04:25:58 -0400 X-MC-Unique: rku0owVpNeeeJj6fH9UKKw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f33f8ffa95so51460615e9.3 for ; Tue, 16 May 2023 01:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684225557; x=1686817557; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U8pRuM5Q7Lxr05z3aZ6AYXk+Wr4qT28SznqmdXZL224=; b=iH6Avv87+kl0jU2QqeyEbDGH9qGTbSYW5A/kH5P/2fjyqPywiZkBkA7yoLQobyTOqQ sRfzf7mC9AdEcjqZjgnE7O351xUtX+QC2Es64ENfSQVy0TUwB8Uor+EXm6hNCESb3cki vZaxg8+CeCFlTaHJRhkXZ0PYY9wP1qUqwMwx9ecq5rc1m1nDgr7C6mmrhKbYXBTpkHTD AU8+ObcHjENAQDkdubJTdgpzw9fnloXpnq+Q7Cuw5buuAPmVZ8M7HG1cCB71auEDCptQ 9pDzSUzt4KzgaUwkCAupE6yhwj0O9nh6aDFgaQC2SF2WbtjRXjdSmJOD5C3h2RBdOdoA 1CQQ== X-Gm-Message-State: AC+VfDyenPz5I58Q4m5V2//2SqY9+cuBGNIfybB7ShE2pa/Et/sgTMSv VTq9DqOwtvmXEqupnyezQ1N4c7orAoH8F5Dy86DTeUAACQk/Qod2ctbl52bcJp/ESWw0aGlWP7a aQlzQVLLNaUU= X-Received: by 2002:adf:f1c5:0:b0:2f2:4db4:1f5b with SMTP id z5-20020adff1c5000000b002f24db41f5bmr24865829wro.29.1684225557043; Tue, 16 May 2023 01:25:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5uilFM9G/lgvaS5x/xIDzNheqY2Mg0oL4HgHBPWCYzZPU4T1kgSXWmXjjD7GSWMcihTxLoCQ== X-Received: by 2002:adf:f1c5:0:b0:2f2:4db4:1f5b with SMTP id z5-20020adff1c5000000b002f24db41f5bmr24865803wro.29.1684225556672; Tue, 16 May 2023 01:25:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c74f:2500:1e3a:9ee0:5180:cc13? (p200300cbc74f25001e3a9ee05180cc13.dip0.t-ipconnect.de. [2003:cb:c74f:2500:1e3a:9ee0:5180:cc13]) by smtp.gmail.com with ESMTPSA id h2-20020a1ccc02000000b003f423a04016sm1483337wmb.18.2023.05.16.01.25.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 01:25:56 -0700 (PDT) Message-ID: <40ed22bb-53e3-ddc2-45ca-f0e763f26242@redhat.com> Date: Tue, 16 May 2023 10:25:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 4/6] io_uring: rsrc: delegate VMA file-backed check to GUP To: Jens Axboe , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , Pavel Begunkov , io-uring@vger.kernel.org, Jason Gunthorpe , John Hubbard References: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: hek9o8upxxmsqohja5j7pk599iyjpb7y X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1DF7E20002 X-Rspam-User: X-HE-Tag: 1684225559-786037 X-HE-Meta: U2FsdGVkX1+z0OhFsSlnxCy02D7l/SPdKT3nNZxnTp0ohEOKK8w6HWZKS5f9YP+Zx/00XO6RuvnbcnhAN5fDk3agNQQRTIAzb9RAhIfn1PJS6Vz/3cTp+T0JGSPNwPeeyVg8WRLDvrBDk9FFU1iK5IocUNkhbjJKRUFd4bYawDv3LESfCWLAIszLQX49r67AOb3+WlfvBM6yRU2O/Pgx2tYWPcW1mL83Ngc2+FF7C/QW9uGf1YsqRKIjn6XEM6YPozwBEQiwAtgSteHQFwXED3H1GKAsaiXRts7BAyxoXhDvY83j7PvIHMkIJuFyvQ8bqLC7HG7AsC98OSJR3ovO46oJUG9Vk06SqyU63KLhbXeSZkD+zRVgmLDcEe0hzFNZsEKeqDo9T2PSHmY7EkOiokZZ1+AE1qadtSvdGAOLKdZ5equDWQeErU4fl6valrcHWP0obAkkCQXXaR/Ja6luLXLkyRGDejXF0/ANsvIQTGm8abFVnJtsnv8DWJmBjRxHHATkmXKwskpynDgKMve/rVrrqRBPNvwrjtjmexJy0l4++2MfnAmpPeQwvFB0FawWm75u7vCsqvJIYqU2O9pqmGomghrxz78DFj7u6kIQtngS8d8qtznaqHYBIkbNVDpRvvSPLK9OJs1CaVGggPxURisdKxZOpr1XE/v0bRr3AOaoaMl/V7N8PwZ+nY9Ep0HQcNeaWiSXvzgOFvYCT2nzRxpT8Num012ZzVzsF1Djrtx3xRn83te0nJy5mI/cR2F/3pkhxsTCMotT0raZM4+JXIhzaOJ7kFphLQ0iQWK16OGqBkIaWzAtFLz4AXt55M0+5ELaRuSJ5ENuBEvPZnwqDfLo+EHkiuCDtxLUw4fdj1HdQTq6zT77LPXBhjdUb3yfiO7Bx6a/agRRRycUBt2SwnX1XQkrevjjj+PW0kMIu9GqkzV9WWSw1/9gWKSz2zkY8gQEl69Zb+K1vGTmnrN Px6WmD0v 66mrMkA16g/tRE1zoiGphT73P0h61K88DMiu5u1JlmIHTmgCfF4oiLdgSieyb2g0OPEA/tOBsPY576+GdIOIdlLcszVYsmh5PovpQ0lRNE1GBGfDMCR6QMlMLvCZvelsv6Q0c2V4Fa4nIr3KzWFSOmwW/eywnbq4yggpCCR5ogA1Enamho/B7m/D80wCXxWO04mO3VoN0/Aoy9r4VxODIEkgbOMHeKCpuVJDkQ4qdtq6chKIVCrq8paCzdKGcKGdfw3kjWR+LnqXoBH0HfnC+Y2pa9d5J28FPxxKH+WesE2VrkDsV1xJMxqPhpCyqcc6izLXxwiEAncy3yR086Zbm70CU5lvSDcydff8+gYy/7RJO1F+h/ieok4Wd/w8ijw2KbiG6b3Se1AOuOtwg4q5bwIEsj+J0zCAanXV4YG6uulrA7TeJwnukDCwupxCn/YU8+RlOhM4o9lAkwtbu0DTP9b7IOtVGKv5z6UhXaWNDmQv+aTOssUwZy23+UsJoBjRN/g0/xYR4qhIRdmDnOenGU282YVg1n8o4Yv2s4YaI1fX920nmsIbXfmArC3tXeaJRDDHBiz85tYP9SwE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.05.23 21:55, Jens Axboe wrote: > On 5/14/23 3:26 PM, Lorenzo Stoakes wrote: >> Now that the GUP explicitly checks FOLL_LONGTERM pin_user_pages() for >> broken file-backed mappings in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast >> writing to file-backed mappings", there is no need to explicitly check VMAs >> for this condition, so simply remove this logic from io_uring altogether. > > Don't have the prerequisite patch handy (not in mainline yet), but if it > just moves the check, then: > > Reviewed-by: Jens Axboe > Jens, please see my note regarding iouring: https://lore.kernel.org/bpf/6e96358e-bcb5-cc36-18c3-ec5153867b9a@redhat.com/ With this patch, MAP_PRIVATE will work as expected (2), but there will be a change in return code handling (1) that we might have to document in the man page. -- Thanks, David / dhildenb