From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: add mm THP section
Date: Thu, 24 Apr 2025 19:11:03 +0100 [thread overview]
Message-ID: <40e69993-e83b-4019-943f-ab90a43eb0de@lucifer.local> (raw)
In-Reply-To: <aAp7ggknCytUyAXd@casper.infradead.org>
On Thu, Apr 24, 2025 at 06:57:22PM +0100, Matthew Wilcox wrote:
> On Thu, Apr 24, 2025 at 12:16:32PM +0100, Lorenzo Stoakes wrote:
> > As part of the ongoing efforts to sub-divide memory management
> > maintainership and reviewership, establish a section for Transparent Huge
> > Page support and add appropriate maintainers and reviewers.
>
> I'm quite queasy about this. I'm doing my best to make "THP" disappear
> as a concept. How would you define what THP is? Originally, it was
> PMD-sized-and-aligned allocations, and some of the way we expose it to
> userspace, that's still the interpretation. But we also have folios which
> are of some hardware-defined magic sizes, as well as (for filesystems,
> at least) random other non-zero orders.
>
> Memory is just managed in variously sized quantities. There should be
> nothing magic about "THP", and I'm still annoyed at the anon-mem people
> for baking various magic sizes into user-visible APIs.
Right, but as it stands, we already separate out handling for a whole host
of different THP things by file, which get_maintainers.pl knows nothing
about.
For:
include/linux/huge_mm.h
include/linux/khugepaged.h
include/trace/events/huge_memory.h
mm/huge_memory.c
mm/khugepaged.c
tools/testing/selftests/mm/khugepaged.c
tools/testing/selftests/mm/split_huge_page_test.c
tools/testing/selftests/mm/transhuge-stress.c
This is not a philosophical position as to where we _might go_ in future,
or how we might decide to treat varying folio sizes going forward, but
rather a purely practical step so these files get seen by people and the
de-facto maintainer is ack'ed as such.
When we get to the point where we can simply treat all as the same, we can
reflect as much in MAINTAINERS too, this is not set in stone.
next prev parent reply other threads:[~2025-04-24 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 11:16 Lorenzo Stoakes
2025-04-24 11:20 ` David Hildenbrand
2025-04-24 11:28 ` Dev Jain
2025-04-24 11:34 ` Lorenzo Stoakes
2025-04-24 11:39 ` Lorenzo Stoakes
2025-04-24 11:55 ` Ryan Roberts
2025-04-24 12:23 ` Baolin Wang
2025-04-24 17:57 ` Matthew Wilcox
2025-04-24 18:11 ` Lorenzo Stoakes [this message]
2025-04-24 18:44 ` David Hildenbrand
2025-04-24 19:38 ` Zi Yan
2025-04-24 19:50 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40e69993-e83b-4019-943f-ab90a43eb0de@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox