From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE36C369CB for ; Wed, 23 Apr 2025 17:03:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 112B46B002A; Wed, 23 Apr 2025 13:03:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C0B26B002B; Wed, 23 Apr 2025 13:03:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA2CF6B002C; Wed, 23 Apr 2025 13:03:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CADBB6B002A for ; Wed, 23 Apr 2025 13:03:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8A870C14ED for ; Wed, 23 Apr 2025 17:03:38 +0000 (UTC) X-FDA: 83365930116.23.2BD1A70 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id E947640012 for ; Wed, 23 Apr 2025 17:03:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNIc9Q2I; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745427816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+3+7SBYIT0EMoPG6wTKgHOcC2ipTqOMHgJd9hrWDUp8=; b=DYIZTwdiZNrhm9uwbP1WDpM83nBPtyCMIBeo/aO1sflq6JQ8SwsxDCDL9w3Wv9dYiZ+k+l A6CQHTZNZzAKn3oIxQuXPlR5Ok+O21fUQRG7eKBlbjsnMhoJW4BNQu0wtWru51EKmKgvSE ONgrE3krFzXYEUHpj7RDJijlrEafP6k= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cNIc9Q2I; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of llong@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745427816; a=rsa-sha256; cv=none; b=SGH0mQ5K5XzAFZlken4eQm6b6YdCNsVAUyPgm8izSKdYTKkuTxVXa1ysSiMKGhevrUut6e SHPR4V2dKUN2+dbVkCQqWiKN7HbuD85QgHeuunQTtxVpu6gnGsX94Ng7oJ0b+DYoxLj3BH W38EFa4uN+udBMnJdGJh8DcsiBk2mLY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745427815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+3+7SBYIT0EMoPG6wTKgHOcC2ipTqOMHgJd9hrWDUp8=; b=cNIc9Q2IKqCImx36/GS0GOQjwrOr5Wq4ELk+DNh4SqmDk5K5d0tMTZTHhqN5nB6kuYBUkf o3oIz8Obk8uUI6n7c2J5GLGnn7OciXhT+I5DLBEm/zaJaWmFQsRF4HsAdkCeQtWi7IcQVG OF+jLKkk7R88awGAtpUmJAUEZOTs71Q= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-59_dXkA7PWu4Z2urg1dy7w-1; Wed, 23 Apr 2025 13:03:33 -0400 X-MC-Unique: 59_dXkA7PWu4Z2urg1dy7w-1 X-Mimecast-MFC-AGG-ID: 59_dXkA7PWu4Z2urg1dy7w_1745427813 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6ecfbdaaee3so1580376d6.3 for ; Wed, 23 Apr 2025 10:03:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745427813; x=1746032613; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+3+7SBYIT0EMoPG6wTKgHOcC2ipTqOMHgJd9hrWDUp8=; b=YBHc9twscAjONVLB+qTBX5CHH4Du0mS+QIAboRwXyMg3qmqk9SU6yphDSik+zT6app p/pLy0uQ8XQfavUYGlAZNWOUmg1j5cbUnILRcuVy2yDtzmZEPcJLvmbCfRVxnfCzwDlG k/I3cDlo+GNazuivbmdup+pyc+IDM/s2uT8KrvPv1oawiZa7gzfDnLYm02LOKjgzEVer krl7uTKZlitu6uIAj6pDrW9PLSiSw7qDCKZb6PdoPiYJznPN9i6coGcPQ48I0IBn72m4 nsbtHU5Zu7VW4Qa6qBPPbycULvR2si4jDn9/RSI0ifryq5ijWfEgVlqpyAHFMZ8JC8Ff H9kQ== X-Forwarded-Encrypted: i=1; AJvYcCW4c39ff0/YNn54EDuNXTck1XF0RYDZmGuEuYYb8VqElPwQ3PDvTs66Q4jKqADLq5sXay5j3YxjmA==@kvack.org X-Gm-Message-State: AOJu0Yxt2sSgMPfjMbt7RphpKhMkfm8c/T/RKfSK33qQJVZPnC6alg9o B0ZDosVLfSMSUOQsmUQ1emYNZ7OJyP7scrAdDipmLBejjqGBlt1q5ZBCiDF1J6lPYvBa81PPXmk SKBhgRD/jyPok2MI7TfYntFgatmPQ48CVmJpVMGFXxc5oQ0iy X-Gm-Gg: ASbGncu9DwT4urv+ECHeWtQNhF0RQMP8eWVBWRCj7JhWzaeMR+v2SktZS/pfjKm2XB0 DGRYuNNKFUqhnV5bA0RQ2tYrkWRqlUj7GBe7Aboo+k/Gr58iSdUU6y8ytMK/c6SL5/fQclbS3y+ 2skyTSkwn1DKBDcerYkRAnpmjZJWZMQ8cYDiRqgTqjPrjafeKpjK5k0fw/KmCk0oCWyOmm4p1VD ydFInuMrZ3G6YqEWVlM1PlwLlkNqBAYfwfwkBeXGb9CPUDrcY36bZ9KSNt0/rU4g89jvdsnhUEy quG0ZQUqZG417VAkwOAhYlweK6pSp3wi0mm77cNJ8hOmm0Cgts2KQ2WA3Q== X-Received: by 2002:a05:6214:5292:b0:6e8:fbb7:6764 with SMTP id 6a1803df08f44-6f2c46992f3mr343421176d6.45.1745427813504; Wed, 23 Apr 2025 10:03:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0Jady51wQ0Po3UBtRHbwZVYJnEaUhKMy5jHguua0DBLjtBhN5wZ/fJFmpmlLKNdXjaqxXqQ== X-Received: by 2002:a05:6214:5292:b0:6e8:fbb7:6764 with SMTP id 6a1803df08f44-6f2c46992f3mr343420656d6.45.1745427813160; Wed, 23 Apr 2025 10:03:33 -0700 (PDT) Received: from ?IPV6:2601:408:c101:1d00:6621:a07c:fed4:cbba? ([2601:408:c101:1d00:6621:a07c:fed4:cbba]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2b33134sm72456966d6.54.2025.04.23.10.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Apr 2025 10:03:32 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <40e1ec0a-63a8-4c07-8b42-e31676453265@redhat.com> Date: Wed, 23 Apr 2025 13:03:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250415210415.13414-1-longman@redhat.com> <20250415210415.13414-2-longman@redhat.com> <0033f39f-ff47-4645-9b1e-f19ff39233e7@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PPTjEbX1gHnSNstPfHbCLiks2DE71rnJfCZGYebmqTQ_1745427813 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ftci4jnzxt5t1ewy5r57nubfm6tt59uq X-Rspamd-Queue-Id: E947640012 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745427815-650650 X-HE-Meta: U2FsdGVkX18osfdPfChg5U7Xn34FY8pxGEhkeo8XWJfONdJSSnoABGHgew9PQ+/+wxqdcgpiiMKCytzhXTrPx55N21YzQG485/DkEn+oyWRERVPlfHbCmN06UwT38zVvfyO28Z8UPxDsgRdBfX/lDWcX3ZUb/71q8ubJxRTALVEFLLoHJK4mE3zD5XYFU3gw/Z9iNGin+EJ8jdySsFzStiPjABX25QxYaMAbicK1102mgcrLtoM3ZZlpudsqGoCvW251L2BD2WTE41gOQ0DC/4RzK+IbrIwm8blB1lEXSuLLP2v1vJ5AGQTBenGIF/bAwirwRzcbpNU7e5svrrnGEhnpakbvmoH5/NSAJsdimJT0Bf5vOHCNeeN8k0NBUPfGPd9P+dmRqi2g4qwNFXiHsxXORyQelQI0rD8k86fdAHqx/yu7EEzmrO2qxjLriAy8pxrlytEnLDRZkHDLk/1PZ9S+myYBYAIM+88vq2vOy1FMlC7SxWD+J6yjAhPSukDTnWBJw+90HKGLuWtwIHqsvuZl5VVUpI2C0RVWI6M5afu2MftnxiXqZSHx0WSj8Ha42gJI5fNRHxicoTYbPhAiRjnniHvaZCGPUt7hLfuZzepPByKyMDyv+UMEG/ftUKAs4KFALQJR6J9g45mPxR+7pRYTuvvvneF6mnNSo9aMaPv8yMLL62Y9CNQYdJy7VPOexwjsg0UEQjrObjvYPZm8yL550z5m94mO/ErYe0cKFM6d1/FIhi0adzDVONsAnzhi/Y7OhFjOU5iOvaROxwFnUSql+pZY3sdROY588KiuFze4COlh+Rhkklilj+QUNjneAt5/KSA8sXvIUQaG+KvIxJ1GBIonCNPkqPGRP6b63VXojsPfog8EouMds4h6sIV0DU/ovzjn9myG2xSAeslEt1Z+GYk5v/9aC4l2P5lAcXWxGLLuatn7wvLlMJ4gelxoM6Px9wr8TlKdR8qhav7 zTFm5cG6 R9wAxI+XKgbPGTwC1uBKP1lgdi0/S8OOMMeDM2jYYt3ncrhl5RBO359AbBK3lEtS5jSspYhG+VQ1W23E9UjTacGtItujmD2fVaanwxQEnAZWXYO7t/XDR/0GY0vxHxX5LsjgjD0silZ8Kp9SyhFkBssUr10DAD7SEjuuba5My8GzUouFvmOmXsNFvuNzBxLeXtmIVvls25VjOMP0IAcKe65LKOpp+wURW2k08rEElZVvYAIWwd9Lr7G4EPR0J04x3wME6OHzNRyVgZqyNF9WVIjmIVF3M1L8ZJCslP5/6ozYEZUuIMdqHjJk/TA00Mn2U8ZkfsvHsL9+shOBlFife1zMFy5RekGg9V/fYrJXFiYV8i8UciCJRBApq14qnONRTkhQow2MuPymL8N5XGbArdzq3Aix6e0toM/M3MzaJU9etcM0rzlQxUJYvkmEhG6LG7shYzrf3w+IDCxVLXyX0FHFoUEJl2W/mUNjSsFxLHonfw7A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/23/25 12:49 PM, Michal Koutný wrote: > On Tue, Apr 22, 2025 at 07:58:56PM -0400, Waiman Long wrote: >> Am I correct to assume that the purpose of 1d09069f5313f ("selftests: >> memcg: expect no low events in unprotected sibling") is to force a >> failure in the test_memcg_low test to force a change in the current >> behavior? Or was it the case that it didn't fail when you submit your >> patch? > Yes, the failure had been intended to mark unexpected mode of reclaim > (there's still a reproducer somewhere in the references). However, I > learnt that: > a) it ain't easy to fix, > b) the only occurence of the troublesome behavior was in the test and > never reported by users in real life. > > I've started to prefer the variant where the particular check is > indefinite since that. OK, I will update the patch as you had suggested. I am fine doing that, just that I did not understand why you wanted the result to be undefined in the first place. Cheers, Longman