From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <dlemoal@kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>
Cc: linux-block@vger.kernel.org, Song Liu <song@kernel.org>,
Yu Kuai <yukuai@fnnas.com>,
linux-raid@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] block: remove bdev_nonrot()
Date: Mon, 2 Mar 2026 14:04:01 -0700 [thread overview]
Message-ID: <40e13629-aa4c-45ba-a2da-b7614961def0@kernel.dk> (raw)
In-Reply-To: <a2993605-2cdb-42b2-85fc-b071f07af4c3@kernel.org>
On 2/26/26 5:27 AM, Damien Le Moal wrote:
> > Is it worth the change, as it looks quite subjective if you prefer the
>> one or the other way?
>
> I think it is a nice cleanup, but I will let Jens and other
> maintainers decide on the worth of this patch.
It's a bit of pointless churn, but I kind of suspected this was coming
when we added the bdev_rot() helper and now had both of them. So I guess
we may as well finish it, as we're half-way there anyway.
--
Jens Axboe
next prev parent reply other threads:[~2026-03-02 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 7:54 Damien Le Moal
2026-02-26 10:04 ` Paul Menzel
2026-02-26 12:27 ` Damien Le Moal
2026-03-02 21:04 ` Jens Axboe [this message]
2026-02-28 23:06 ` Martin K. Petersen
2026-03-02 21:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40e13629-aa4c-45ba-a2da-b7614961def0@kernel.dk \
--to=axboe@kernel.dk \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=chrisl@kernel.org \
--cc=dlemoal@kernel.org \
--cc=dsterba@suse.com \
--cc=kasong@tencent.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pmenzel@molgen.mpg.de \
--cc=song@kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox